From 03275fe0b3d1f692dd8543daff69ed4c3959ee11 Mon Sep 17 00:00:00 2001 From: Abdessamad Derraz <3028866+Abdess@users.noreply.github.com> Date: Sat, 17 Oct 2026 01:55:49 +0200 Subject: [PATCH] chore: fail the slots check when nothing is settled --- tests/test_slots.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/test_slots.py b/tests/test_slots.py index d23b6d6d..24ee635d 100644 --- a/tests/test_slots.py +++ b/tests/test_slots.py @@ -598,8 +598,10 @@ class ManifestFollowsTheArbitration(unittest.TestCase): config, profiles, db, build_zip_contents_index(db), load_data_dir_registry(str(repo / "platforms")), ) - if not overrides: - self.skipTest("no contested slot the pack settles on its own") + # RetroArch serves a core's own copy at contested slots (ATARIOSB.ROM, + # dsi_bios7/9.bin): an arbitration that settles nothing is the + # failure, not a reason to skip. + self.assertTrue(overrides, "pack_overrides settles no RetroArch slot") manifest = generate_pack.generate_manifest( "retroarch", str(repo / "platforms"), db, str(repo / "bios"), str(repo / "platforms" / "_registry.yml"),