From 08e603fb8325ba7429ab410223f8d4ec9531239a Mon Sep 17 00:00:00 2001 From: Abdessamad Derraz <3028866+Abdess@users.noreply.github.com> Date: Tue, 10 Nov 2026 06:51:08 +0100 Subject: [PATCH] fix: read a missing name with spaces whole The parity test cut each MISSING line at the first space. openMSX's ROM names hold spaces (Japanese MSX-Write (1986) (Ascii) (J).rom), so the msx pack's list read 'Japanese' where verify named the file. Both sides now name the same 81 files. --- tests/test_system_pack_parity.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/test_system_pack_parity.py b/tests/test_system_pack_parity.py index 9925a4310..289c3fe7e 100644 --- a/tests/test_system_pack_parity.py +++ b/tests/test_system_pack_parity.py @@ -51,7 +51,9 @@ class SystemPackMatchesVerify(unittest.TestCase): "--output-dir", str(self.out / system), ) report = json.loads(_run("scripts/verify.py", "--system", system, "--json")) - pack_missing = sorted(re.findall(r"^ MISSING: (\S+)", packed, re.M)) + # The rest of the line is the name: openMSX's ROM names hold + # spaces ("Japanese MSX-Write (1986) (Ascii) (J).rom"). + pack_missing = sorted(re.findall(r"^ MISSING: (.+)$", packed, re.M)) # One per destination, as the pack reports them. An entry the # collection cannot hold is counted apart on both sides. verify_missing = sorted({