fix: read target overrides as the builder does

tests/test_check_freshness.py

@@ -160,9 +160,9 @@ class CoreResolutionTests(unittest.TestCase):
                 "linux": {"cores": ["ghost"]},
             }
         }
-        removed = {"android": {"na"}}
+        overrides = {"android": {"remove_cores": ["na"]}}
         self.assertEqual(
-            cf.unresolved_target_cores(targets, index, removed),
+            cf.unresolved_target_cores(targets, index, overrides),
             {"ghost": ["android", "linux"]},
         )
 
@@ -182,12 +182,24 @@ class CoreResolutionTests(unittest.TestCase):
                 }
             }
         }
-        removed = cf._removed_cores(overrides, "plat")
         self.assertEqual(
-            cf.unresolved_target_cores(targets, index, removed),
+            cf.unresolved_target_cores(targets, index, cf._platform_overrides(overrides, "plat")),
             {"ghost": ["x86_64"]},
         )
 
+    def test_an_added_core_is_read_as_the_builder_reads_it(self):
+        """add_cores without a profile is the false skip this check exists
+        for, and a target may add back what _default removes."""
+        index = cf.profile_name_index(self.PROFILES)
+        targets = {"targets": {"board": {"cores": ["mednafen_psx"]}}}
+        overrides = {
+            "_default": {"remove_cores": ["mednafen_psx"]},
+            "board": {"add_cores": ["mednafen_psx", "citron"]},
+        }
+        self.assertEqual(
+            cf.unresolved_target_cores(targets, index, overrides), {"citron": ["board"]}
+        )
+
     def test_coreinfo_gaps_fold_case_and_flag_standalone_profiles(self):
         names = ["FreeIntvTSOverlay", "eka2l1", "wqxemu", "mednafen_psx"]
         unprofiled, standalone = cf.coreinfo_gaps(names, self.PROFILES)

tests/test_scraper_contract.py

@@ -477,7 +477,7 @@ class EveryTargetCoreReachesAProfile(unittest.TestCase):
                 continue
             unresolved = check_freshness.unresolved_target_cores(
                 yaml.safe_load(Path(path).read_text()), index,
-                check_freshness._removed_cores(overrides, platform),
+                check_freshness._platform_overrides(overrides, platform),
             )
             with self.subTest(platform=platform):
                 if platform == "retropie":