From a02d30f90c2879106faded8df9133087332de676 Mon Sep 17 00:00:00 2001 From: Abdessamad Derraz <3028866+Abdess@users.noreply.github.com> Date: Mon, 9 Nov 2026 20:06:44 +0100 Subject: [PATCH 1/2] fix: wait for the Confirm count in the tap test Confirm has no Install row until its dry run ends, so an Enter sent on its title alone fell on "Counting the files" and did nothing on the runner. The test now waits for "Counted again for these choices", drawn once the Install row exists. --- tests/test_install_tui.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/test_install_tui.py b/tests/test_install_tui.py index e14c35e8f..ec324b6d7 100644 --- a/tests/test_install_tui.py +++ b/tests/test_install_tui.py @@ -12374,10 +12374,10 @@ class TapsOnAPtySeeFirst(unittest.TestCase): break term.send("\x1b[A") term.send("\r") - # The changed choices are counted again on Confirm. Waiting on the - # bare title matched the screen before it, and a runner that drew - # Confirm after one settle never pressed Enter there. - term.wait("RetroBIOS: Confirm") + # The changed choices are counted again on Confirm, which has no + # Install row until its dry run ends: Enter sent on the title alone + # fell on "Counting the files" and did nothing on a slow runner. + term.wait("Counted again for these choices") term.settle() term.send("\r") term.wait("files installed") From e4f8bb336a35e2869de4b6039e79cca4deb35643 Mon Sep 17 00:00:00 2001 From: Abdessamad Derraz <3028866+Abdess@users.noreply.github.com> Date: Mon, 9 Nov 2026 21:00:45 +0100 Subject: [PATCH 2/2] fix: read a wrapped BIOS folder line whole A long checkout path wraps "BIOS folder:" after the label, and the test joined the lines without the space it dropped. It now compares without spaces, which holds for either wrap point. --- tests/test_install_tui.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/test_install_tui.py b/tests/test_install_tui.py index ec324b6d7..056523882 100644 --- a/tests/test_install_tui.py +++ b/tests/test_install_tui.py @@ -11269,8 +11269,10 @@ class TapsGameDataAndExitCodes(_CardFixtures, unittest.TestCase): lines = [str(line).strip() for line in install.tui_view(state, 120, 40)] folder = next(i for i, line in enumerate(lines) if line.startswith("BIOS folder:")) named = next(i for i, line in enumerate(lines) if line.startswith("Named by")) - # Nothing between the folder, wrapped or not, and what named it. - self.assertEqual("".join(lines[folder:named]), f"BIOS folder: {state.dest}", lines) + # Nothing between the folder, wrapped or not, and what named it. A + # long path wraps after the label, a longer one inside the path. + self.assertEqual("".join(lines[folder:named]).replace(" ", ""), + f"BIOS folder: {state.dest}".replace(" ", ""), lines) self.assertLess(named, next(i for i, line in enumerate(lines) if line.startswith(("For ", "Copy them"))))