From 190c06976771298181e11cc1e3914fad6ba64ef9 Mon Sep 17 00:00:00 2001 From: Abdessamad Derraz <3028866+Abdess@users.noreply.github.com> Date: Fri, 6 Nov 2026 14:49:56 +0100 Subject: [PATCH] chore: check every registered scraper's pin --- tests/test_scraper_contract.py | 49 +++++++++++++++++++--------------- 1 file changed, 27 insertions(+), 22 deletions(-) diff --git a/tests/test_scraper_contract.py b/tests/test_scraper_contract.py index cf9e04c20..c30491c9f 100644 --- a/tests/test_scraper_contract.py +++ b/tests/test_scraper_contract.py @@ -642,21 +642,26 @@ class UnreadableReleaseStopsTheScrape(unittest.TestCase): def _refuse(*_args, **_kwargs): raise urllib.error.HTTPError("https://api.github.com/x", 403, "rate limited", {}, None) + # Read at a release tag: the pin is the tag, not a branch commit. + TAG_PINNED = {"amberelec", "batocera", "bizhawk", "emuelec", "knulli", "recalbox", + "rocknix", "romm"} + + @staticmethod + def _registry_scrapers() -> list[str]: + """Every platform scraper the registry names: a hand-written list + left rocknix, retrodeck, minui, nextui and myminui unchecked.""" + import yaml # noqa: PLC0415 + + registry = yaml.safe_load((REPO_ROOT / "platforms" / "_registry.yml").read_text()) + return sorted({entry["scraper"] for entry in registry["platforms"].values() + if entry.get("scraper")}) + + def test_the_tag_pinned_scrapers_are_registered(self): + self.assertLessEqual(self.TAG_PINNED, set(self._registry_scrapers())) + def test_every_pinned_scraper_raises(self): - for name in ( - "scraper.bizhawk_scraper", - "scraper.romm_scraper", - "scraper.batocera_scraper", - "scraper.recalbox_scraper", - "scraper.libretro_scraper", - "scraper.retrobat_scraper", - "scraper.emudeck_scraper", - "scraper.misterfpga_scraper", - "scraper.retropie_scraper", - "scraper.amberelec_scraper", - "scraper.emuelec_scraper", - "scraper.knulli_scraper", - ): + for scraper in self._registry_scrapers(): + name = f"scraper.{scraper}_scraper" module = importlib.import_module(name) with self.subTest(scraper=name), mock.patch( "urllib.request.urlopen", self._refuse @@ -679,16 +684,16 @@ class UnreadableReleaseStopsTheScrape(unittest.TestCase): def answer(request, timeout=None): return Answer(json.dumps({"sha": sha}).encode()) - for name in ( - "scraper.libretro_scraper", - "scraper.retrobat_scraper", - "scraper.emudeck_scraper", - "scraper.misterfpga_scraper", - "scraper.retropie_scraper", - ): + branch_read = [s for s in self._registry_scrapers() if s not in self.TAG_PINNED] + self.assertGreater(len(branch_read), 8) + for scraper in branch_read: + name = f"scraper.{scraper}_scraper" module = importlib.import_module(name) with self.subTest(scraper=name), mock.patch("urllib.request.urlopen", answer): - self.assertRegex(module.Scraper().url, f"/{sha}(/|$)") + instance = module.Scraper() + # RetroDECK reads a tree of manifests and keeps the commit apart. + recorded = getattr(instance, "revision", "") or instance.url + self.assertRegex(recorded, f"(^|/){sha}(/|$)") def test_the_export_reads_the_recorded_tarball(self): from export_native import _tarball_at