From 1cc12d8e2aa08c329389ba7fc36dfef9bba4b26b Mon Sep 17 00:00:00 2001 From: Abdessamad Derraz <3028866+Abdess@users.noreply.github.com> Date: Tue, 3 Nov 2026 14:56:45 +0100 Subject: [PATCH] docs: which-pack names the folder in fewer words --- scripts/generate_site.py | 12 +++++------- tests/test_doc_pages.py | 2 +- tests/test_install_tui.py | 4 +++- tests/test_site_r3_entry.py | 3 +-- tests/test_site_validation.py | 1 + 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/scripts/generate_site.py b/scripts/generate_site.py index 34be02506..0b0ff5c9b 100644 --- a/scripts/generate_site.py +++ b/scripts/generate_site.py @@ -3945,9 +3945,8 @@ def first_screen_words() -> list[str]: # above on the page (tui_audit_16 P3-10). # Nothing found, the folder comes before Install: which-pack left it # out (tui_audit_17 P3-9). - return [f"It asks **{installer.TUI_FOUND_TITLE}**, or **{installer.TUI_CHOOSE_TITLE}** " - f"and **{installer.TUI_FOLDER_TITLE}** when it finds nothing, then offers " - f"**{installer.TUI_INSTALL_ROW}**."] + return [f"It asks **{installer.TUI_FOUND_TITLE}** (or **{installer.TUI_CHOOSE_TITLE}** " + f"and **{installer.TUI_FOLDER_TITLE}**), then offers **{installer.TUI_INSTALL_ROW}**."] def check_pass_line() -> str: @@ -4116,8 +4115,7 @@ def only_some_consoles(name: str, prefix: str = "") -> list[str]: """The way to a smaller download, in the words Get your files uses.""" return [ f"Only some consoles? [Pick them]({prefix}which-pack.md?platform={name}" - f"#only-some-consoles), or run the command: **{_installer().TUI_SYSTEMS_ROW}** " - "is on its second screen.", + f"#only-some-consoles), or the command's **{_installer().TUI_SYSTEMS_ROW}**.", "", ] @@ -11414,8 +11412,8 @@ def generate_which_pack() -> str: "", "## Only some consoles?", "", - "Pick them here, and get the files and the command. Or run the command " - f"below: **{_installer().TUI_SYSTEMS_ROW}** is on its second screen.", + "Pick them here, and get the files and the command. Or use the command's " + f"**{_installer().TUI_SYSTEMS_ROW}**.", "", "", "", diff --git a/tests/test_doc_pages.py b/tests/test_doc_pages.py index 286bd0b28..5d919dfdd 100644 --- a/tests/test_doc_pages.py +++ b/tests/test_doc_pages.py @@ -187,7 +187,7 @@ class InstallerSamplesSayWhatTheCodePrints(unittest.TestCase): refused = _generated(page, "check-refused") self.assertRegex(refused, r"\n \d+ files? [a-z ]+:\n") self.assertIn("read by beetle_psx, pcsx_rearmed at", refused) - self.assertNotIn("opened at", page) + self.assertNotRegex(page, r"opened at /\S+ by ") self.assertIn('"read by ', inspect.getsource(install.opened_line)) ending = _generated(page, "from-run") self.assertRegex(ending, r"Done\. \d+ files installed\.\n \d+ files copied from ") diff --git a/tests/test_install_tui.py b/tests/test_install_tui.py index 511bebc7f..7b147259e 100644 --- a/tests/test_install_tui.py +++ b/tests/test_install_tui.py @@ -11816,7 +11816,9 @@ class AuditTwentyAndThirteen(unittest.TestCase): self.assertEqual(said.returncode, 1, said.stdout + said.stderr) self.assertIn("No supported platform detected: RetroArch was not found here, and " "the pack does not say where it goes.", said.stderr) - alone = install_run("--yes", env=env) + # The standalone emulators' lists come from the network: offline, + # no request leaves the machine (code_audit_24 P3-13). + alone = install_run("--yes", env={**env, install.OFFLINE_VARIABLE: "1"}) self.assertIn("No supported platform detected", alone.stdout + alone.stderr) hint = install._manual_usage_hint("linux") self.assertTrue(hint[0].startswith(" Name the setup with --platform and its folder " diff --git a/tests/test_site_r3_entry.py b/tests/test_site_r3_entry.py index 84ca38a90..8ed8ad9db 100644 --- a/tests/test_site_r3_entry.py +++ b/tests/test_site_r3_entry.py @@ -160,8 +160,7 @@ class SetupPagesOfferPartOfThePack(unittest.TestCase): self.assertIn(f"/retrobios/which-pack/?platform={key}#only-some-consoles", text) # The screen's own row: the line menu's c is not what the # one-liner opens. - self.assertIn("or run the command: **Choose systems** is on its second " - "screen.", text) + self.assertIn("or the command's **Choose systems**.", text) # Never "choose **Choose systems**" (tui_audit_17 P3-9). self.assertNotIn("choose **Choose systems**", text) diff --git a/tests/test_site_validation.py b/tests/test_site_validation.py index 35acb41e7..feac2d14a 100644 --- a/tests/test_site_validation.py +++ b/tests/test_site_validation.py @@ -279,6 +279,7 @@ class EveryTestDependencyIsInstalledInCi(unittest.TestCase): {p.stem for p in (root / "scripts").rglob("*.py")} | {p.name for p in (root / "scripts").iterdir() if p.is_dir()} | {p.stem for p in (root / "tests").glob("*.py")} + | {p.name for p in (root / "tests").iterdir() if p.is_dir()} | {"scripts", "tests", "install"} ) imported: set[str] = set()