From 21b8d902e3c9a0282d57ed2b0c42936c5976da52 Mon Sep 17 00:00:00 2001
From: Abdessamad Derraz <3028866+Abdess@users.noreply.github.com>
Date: Thu, 5 Nov 2026 14:36:14 +0100
Subject: [PATCH] fix: name a served sha1 only when it differs

A RomM row printed the served copy's sha1 under the same SHA1 it
had just declared, 313 times on the page. The note stays where the
copy is not one the row declares.
---
 scripts/generate_site.py        | 11 +++++++----
 tests/test_site_r2_reference.py |  5 +++++
 2 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/scripts/generate_site.py b/scripts/generate_site.py
index 2a763163b..f7525cba2 100644
--- a/scripts/generate_site.py
+++ b/scripts/generate_site.py
@@ -3380,11 +3380,13 @@ def _emulator_named_link(key: str, prefix: str = "") -> str:
     return f"[{label}]({prefix}emulators/{key}.md)"
 
 
-def _served_line(f: dict) -> str:
+def _served_line(f: dict, declared_sha1: str = "") -> str:
     """Which collection file answers the entry, from the resolver's result.
 
     "OK" with no path gave an expert nothing to check: Batocera's
     scph1001.bin is served by bios/Sony/PlayStation/scph1001_v20.bin.
+    The copy's sha1 is named only when it is not one the row already
+    declares (Recalbox joins several with commas).
     """
     path = str(f.get("path") or "")
     if f.get("status") == "missing":
@@ -3399,8 +3401,9 @@ def _served_line(f: dict) -> str:
         return f"{label}: {_code(path)}"
     # The card of that copy: every hash, provenance and the download.
     page = urllib.parse.quote(card_page(path, sha1))
-    return (f"{label}: [{_code(path)}](../systems/{page}.md#sha1-{sha1[:12]}) "
-            f"(sha1 `{sha1[:8]}`)")
+    link = f"{label}: [{_code(path)}](../systems/{page}.md#sha1-{sha1[:12]})"
+    declared = {value.strip().lower() for value in declared_sha1.split(",")}
+    return link if sha1 in declared else f"{link} (sha1 `{sha1[:8]}`)"
 
 
 # Platforms whose launcher records are read from the repository and revision
@@ -3559,7 +3562,7 @@ def _platform_file_row(f: dict, cfg_entry: dict, hash_type: str = "",
             "unread": "No core the platform runs opens it"}.get(f.get("category", ""))
     if kind:
         facts.append(kind)
-    served = _served_line(f)
+    served = _served_line(f, str(hashes["sha1"] or ""))
     if served:
         facts.append(_inline_html(served))
     if f.get("category_evidence"):
diff --git a/tests/test_site_r2_reference.py b/tests/test_site_r2_reference.py
index cd6f9aaee..1e75f5a4a 100644
--- a/tests/test_site_r2_reference.py
+++ b/tests/test_site_r2_reference.py
@@ -152,6 +152,11 @@ class EachEntryNamesItsFile(unittest.TestCase):
         self.assertRegex(served, rf"\]\(\.\./systems/[^)]+\.md#sha1-{digest[:12]}\)")
         self.assertTrue(served.startswith("Served by: "))
         self.assertIn(f"`{digest[:8]}`", served)
+        # The row already shows the declared sha1: repeating it said nothing.
+        quiet = generate_site._served_line({"status": "ok", "path": path}, f"aaaa, {digest.upper()}")
+        self.assertNotIn(digest[:8], quiet.split(")", 1)[1])
+        self.assertIn(f"`{digest[:8]}`", generate_site._served_line(
+            {"status": "ok", "path": path}, "a" * 40))
         self.assertEqual(generate_site._served_line({"status": "missing"}), "Not held")
         self.assertTrue(generate_site._served_line(
             {"status": "untested", "path": path}).startswith("Held, not the declared hash"))