kmoody/libretro
1
0 Fork 0
mirror of https://github.com/Abdess/retroarch_system.git synced 2026-11-01 00:27:20 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: one total and the same words in both modes

Browse Source 
Commands break between shell words with a continuation the shell reads,
an option kept with its value. The 40x12 setup and plan keep a note or a
folder whole. Line mode counts files in place and missing, and names the
BIOS folder, as the screen does. The systems question fits its terminal.
This commit is contained in:
Abdessamad Derraz committed 2026-10-28 12:19:50 +01:00
1 parent 5bf29b3dab
commit 23804a8da3
31 files changed
+558 -186
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

tests/fixtures/tui/colour-120x40.txt
Vendored
+4 -4
View File
@@ -618,8 +618,8 @@
The same choice without questions:
python3 install.py --platform retroarch --dest /home/user/.config/retroarch/system --system
nintendo-gba
python3 install.py --platform retroarch --dest /home/user/.config/retroarch/system \
--system nintendo-gba
@@ -743,8 +743,8 @@
BIOS folder: ^[[0;1m/home/user/.config/retroarch/system^[[0m
^[[0;1;31mfailed:^[[0m scph5500.bin (HTTP 404)
The files it replaced are kept in /home/user/.config/retroarch/retrobios-backup/2026-10-23_1200
To put them back: python3 install.py --restore
/home/user/.config/retroarch/retrobios-backup/2026-10-23_1200
To put them back: python3 install.py \
--restore /home/user/.config/retroarch/retrobios-backup/2026-10-23_1200
Same choice without questions:
python3 install.py --platform retroarch --dest /home/user/.config/retroarch/system
Details: /tmp/retrobios-x/install.log
tests/fixtures/tui/colour-40x12.txt
Vendored
+6 -6
View File
@@ -9,7 +9,7 @@
BIOS folder:
^[[0;1m/home/user/.config/retroarch/system^[[0m
ES-DE found: its BIOS files go to each
ES-DE: files go to each emulator.
^[[0;1;35mA^[[0m Continue ^[[0;2mB^[[0m Quit ^[[0;2m?^[[0m Help
=== platforms
^[[0;1m ^[[0;1;35mRetroBIOS^[[0;1m: Which setup?^[[0m
@@ -198,11 +198,11 @@
The same choice without questions:
python3 install.py --platform
retroarch --dest
/home/user/.config/retroarch/system
python3 install.py \
--platform retroarch \
--dest .../retroarch/system \
--system nintendo-gba
^[[0;2m Shortened to fit this window.^[[0m
^[[0;1;35mA^[[0m Back
@@ -242,7 +242,7 @@
The files it replaced are kept in
/home/user/.config/retroarch/
retrobios-backup/2026-10-23_1200
To put them back: python3 install.py
To put them back: python3 install.py \
^[[0;2m 1-8 of 16^[[0m
^[[0;1;35mA^[[0m Exit ^[[0;2m^v^[[0m Scroll
=== error
tests/fixtures/tui/colour-40x15.txt
Vendored
+8 -8
View File
@@ -243,11 +243,11 @@
The same choice without questions:
python3 install.py --platform
retroarch --dest
/home/user/.config/retroarch/system
python3 install.py \
--platform retroarch \
--dest .../retroarch/system \
--system nintendo-gba
^[[0;2m Shortened to fit this window.^[[0m
@@ -296,10 +296,10 @@
The files it replaced are kept in
/home/user/.config/retroarch/
retrobios-backup/2026-10-23_1200
To put them back: python3 install.py
--restore
/home/user/.config/retroarch/retrobios-backup/2026-10-23_1200
To put them back: python3 install.py \
--restore .../2026-10-23_1200
^[[0;2m Shortened to fit this window.^[[0m
Same choice without questions:
^[[0;2m 1-11 of 16^[[0m
^[[0;1;35mA^[[0m Exit ^[[0;2m^v^[[0m Scroll
=== error
tests/fixtures/tui/colour-80x24.txt
Vendored
+6 -6
View File
@@ -378,8 +378,8 @@
The same choice without questions:
python3 install.py --platform retroarch --dest
/home/user/.config/retroarch/system --system nintendo-gba
python3 install.py --platform retroarch \
--dest /home/user/.config/retroarch/system --system nintendo-gba
@@ -456,11 +456,11 @@
^[[0;1;31mfailed:^[[0m scph5500.bin (HTTP 404)
The files it replaced are kept in
/home/user/.config/retroarch/retrobios-backup/2026-10-23_1200
To put them back: python3 install.py --restore
/home/user/.config/retroarch/retrobios-backup/2026-10-23_1200
To put them back: python3 install.py \
--restore /home/user/.config/retroarch/retrobios-backup/2026-10-23_1200
Same choice without questions:
python3 install.py --platform retroarch --dest
/home/user/.config/retroarch/system
python3 install.py --platform retroarch \
--dest /home/user/.config/retroarch/system
Details: /tmp/retrobios-x/install.log
tests/fixtures/tui/command-120x40.txt
Vendored
+2 -2
View File
@@ -2,8 +2,8 @@
The same choice without questions:
python3 install.py --platform retroarch --dest /home/user/.config/retroarch/system --system
nintendo-gba
python3 install.py --platform retroarch --dest /home/user/.config/retroarch/system \
--system nintendo-gba
tests/fixtures/tui/command-40x12.txt
Vendored
+4 -4
View File
@@ -2,11 +2,11 @@
The same choice without questions:
python3 install.py --platform
retroarch --dest
/home/user/.config/retroarch/system
python3 install.py \
--platform retroarch \
--dest .../retroarch/system \
--system nintendo-gba
Shortened to fit this window.
A Back
tests/fixtures/tui/command-40x15.txt
Vendored
+4 -4
View File
@@ -2,11 +2,11 @@
The same choice without questions:
python3 install.py --platform
retroarch --dest
/home/user/.config/retroarch/system
python3 install.py \
--platform retroarch \
--dest .../retroarch/system \
--system nintendo-gba
Shortened to fit this window.
tests/fixtures/tui/command-80x24.txt
Vendored
+2 -2
View File
@@ -2,8 +2,8 @@
The same choice without questions:
python3 install.py --platform retroarch --dest
/home/user/.config/retroarch/system --system nintendo-gba
python3 install.py --platform retroarch \
--dest /home/user/.config/retroarch/system --system nintendo-gba
tests/fixtures/tui/result-120x40.txt
Vendored
+2 -2
View File
@@ -4,8 +4,8 @@
BIOS folder: /home/user/.config/retroarch/system
failed: scph5500.bin (HTTP 404)
The files it replaced are kept in /home/user/.config/retroarch/retrobios-backup/2026-10-23_1200
To put them back: python3 install.py --restore
/home/user/.config/retroarch/retrobios-backup/2026-10-23_1200
To put them back: python3 install.py \
--restore /home/user/.config/retroarch/retrobios-backup/2026-10-23_1200
Same choice without questions:
python3 install.py --platform retroarch --dest /home/user/.config/retroarch/system
Details: /tmp/retrobios-x/install.log
tests/fixtures/tui/result-40x12.txt
Vendored
+1 -1
View File
@@ -7,6 +7,6 @@
The files it replaced are kept in
/home/user/.config/retroarch/
retrobios-backup/2026-10-23_1200
To put them back: python3 install.py
To put them back: python3 install.py \
1-8 of 16
A Exit ^v Scroll
tests/fixtures/tui/result-40x15.txt
Vendored
+4 -4
View File
@@ -7,9 +7,9 @@
The files it replaced are kept in
/home/user/.config/retroarch/
retrobios-backup/2026-10-23_1200
To put them back: python3 install.py
--restore
/home/user/.config/retroarch/retrobios-backup/2026-10-23_1200
To put them back: python3 install.py \
--restore .../2026-10-23_1200
Shortened to fit this window.
Same choice without questions:
1-11 of 16
A Exit ^v Scroll
tests/fixtures/tui/result-80x24.txt
Vendored
+4 -4
View File
@@ -5,11 +5,11 @@
failed: scph5500.bin (HTTP 404)
The files it replaced are kept in
/home/user/.config/retroarch/retrobios-backup/2026-10-23_1200
To put them back: python3 install.py --restore
/home/user/.config/retroarch/retrobios-backup/2026-10-23_1200
To put them back: python3 install.py \
--restore /home/user/.config/retroarch/retrobios-backup/2026-10-23_1200
Same choice without questions:
python3 install.py --platform retroarch --dest
/home/user/.config/retroarch/system
python3 install.py --platform retroarch \
--dest /home/user/.config/retroarch/system
Details: /tmp/retrobios-x/install.log
tests/fixtures/tui/route-evmapy.txt
Vendored
+3 -3
View File
@@ -9,7 +9,7 @@
BIOS folder:
/home/user/.config/retroarch/system
ES-DE found: its BIOS files go to each
ES-DE: files go to each emulator.
A Continue B Quit
=== setup 40x15
RetroBIOS: Where do you play?
@@ -755,8 +755,8 @@
The same choice without questions:
python3 install.py --platform retroarch --dest
/home/user/.config/retroarch/system --system nintendo-gba
python3 install.py --platform retroarch \
--dest /home/user/.config/retroarch/system --system nintendo-gba
tests/fixtures/tui/route-gptokeyb.txt
Vendored
+3 -3
View File
@@ -9,7 +9,7 @@
BIOS folder:
/home/user/.config/retroarch/system
ES-DE found: its BIOS files go to each
ES-DE: files go to each emulator.
A Continue B Quit
=== setup 40x15
RetroBIOS: Where do you play?
@@ -755,8 +755,8 @@
The same choice without questions:
python3 install.py --platform retroarch --dest
/home/user/.config/retroarch/system --system nintendo-gba
python3 install.py --platform retroarch \
--dest /home/user/.config/retroarch/system --system nintendo-gba
tests/fixtures/tui/route-gptokeyb_muxterm.txt
Vendored
+3 -3
View File
@@ -9,7 +9,7 @@
BIOS folder:
/home/user/.config/retroarch/system
ES-DE found: its BIOS files go to each
ES-DE: files go to each emulator.
A Continue B Quit
=== setup 40x15
RetroBIOS: Where do you play?
@@ -755,8 +755,8 @@
The same choice without questions:
python3 install.py --platform retroarch --dest
/home/user/.config/retroarch/system --system nintendo-gba
python3 install.py --platform retroarch \
--dest /home/user/.config/retroarch/system --system nintendo-gba
tests/fixtures/tui/route-keys.txt
Vendored
+20 -20
View File
@@ -9,7 +9,7 @@
BIOS folder:
/home/user/.config/retroarch/system
ES-DE found: its BIOS files go to each
ES-DE: files go to each emulator.
Enter Continue Esc Quit ? Help
=== setup 40x15
RetroBIOS: Where do you play?
@@ -759,11 +759,11 @@
The same choice without questions:
python3 install.py --platform
retroarch --dest
/home/user/.config/retroarch/system
python3 install.py \
--platform retroarch \
--dest .../retroarch/system \
--system nintendo-gba
Shortened to fit this window.
Enter Back
@@ -772,11 +772,11 @@
The same choice without questions:
python3 install.py --platform
retroarch --dest
/home/user/.config/retroarch/system
python3 install.py \
--platform retroarch \
--dest .../retroarch/system \
--system nintendo-gba
Shortened to fit this window.
@@ -788,8 +788,8 @@
The same choice without questions:
python3 install.py --platform retroarch --dest
/home/user/.config/retroarch/system --system nintendo-gba
python3 install.py --platform retroarch \
--dest /home/user/.config/retroarch/system --system nintendo-gba
@@ -926,7 +926,7 @@
The files it replaced are kept in
/home/user/.config/retroarch/
retrobios-backup/2026-10-23_1200
To put them back: python3 install.py
To put them back: python3 install.py \
1-8 of 16
Enter Exit ^v Scroll
=== result 40x15
@@ -939,10 +939,10 @@
The files it replaced are kept in
/home/user/.config/retroarch/
retrobios-backup/2026-10-23_1200
To put them back: python3 install.py
--restore
/home/user/.config/retroarch/retrobios-backup/2026-10-23_1200
To put them back: python3 install.py \
--restore .../2026-10-23_1200
Shortened to fit this window.
Same choice without questions:
1-11 of 16
Enter Exit ^v Scroll
=== result 80x24
@@ -953,11 +953,11 @@
failed: scph5500.bin (HTTP 404)
The files it replaced are kept in
/home/user/.config/retroarch/retrobios-backup/2026-10-23_1200
To put them back: python3 install.py --restore
/home/user/.config/retroarch/retrobios-backup/2026-10-23_1200
To put them back: python3 install.py \
--restore /home/user/.config/retroarch/retrobios-backup/2026-10-23_1200
Same choice without questions:
python3 install.py --platform retroarch --dest
/home/user/.config/retroarch/system
python3 install.py --platform retroarch \
--dest /home/user/.config/retroarch/system
Details: /tmp/retrobios-x/install.log
tests/fixtures/tui/route-miyoo.txt
Vendored
+3 -3
View File
@@ -9,7 +9,7 @@
BIOS folder:
/home/user/.config/retroarch/system
ES-DE found: its BIOS files go to each
ES-DE: files go to each emulator.
A Continue R2 Quit
=== setup 40x15
RetroBIOS: Where do you play?
@@ -784,8 +784,8 @@
The same choice without questions:
python3 install.py --platform retroarch --dest
/home/user/.config/retroarch/system --system nintendo-gba
python3 install.py --platform retroarch \
--dest /home/user/.config/retroarch/system --system nintendo-gba
tests/fixtures/tui/route-muxterm.txt
Vendored
+11 -11
View File
@@ -9,7 +9,7 @@
BIOS folder:
/home/user/.config/retroarch/system
ES-DE found: its BIOS files go to each
ES-DE: files go to each emulator.
Start Continue B Quit
=== setup 40x15
RetroBIOS: Where do you play?
@@ -813,11 +813,11 @@
The same choice without questions:
python3 install.py --platform
retroarch --dest
/home/user/.config/retroarch/system
python3 install.py \
--platform retroarch \
--dest .../retroarch/system \
--system nintendo-gba
Shortened to fit this window.
Start Back
@@ -826,11 +826,11 @@
The same choice without questions:
python3 install.py --platform
retroarch --dest
/home/user/.config/retroarch/system
python3 install.py \
--platform retroarch \
--dest .../retroarch/system \
--system nintendo-gba
Shortened to fit this window.
@@ -842,8 +842,8 @@
The same choice without questions:
python3 install.py --platform retroarch --dest
/home/user/.config/retroarch/system --system nintendo-gba
python3 install.py --platform retroarch \
--dest /home/user/.config/retroarch/system --system nintendo-gba
tests/fixtures/tui/setup-40x12.txt
Vendored
+1 -1
View File
@@ -8,5 +8,5 @@
BIOS folder:
/home/user/.config/retroarch/system
ES-DE found: its BIOS files go to each
ES-DE: files go to each emulator.
A Continue B Quit ? Help
tests/test_doc_pages.py
+9 -5
View File
@@ -97,7 +97,7 @@ class InstallerOutputExample(unittest.TestCase):
for part in omitted.group(1).split(", "):
self.assertIn(part.rsplit(":", 1)[0], install.OMISSION_REASONS.values())
count, size = re.search(r"\n (\d+) files \(([\d.]+ [KMG]B)\)", run).groups()
self.assertIn(f"0/{count} present", run)
self.assertIn(f"0 in place, {count} missing", run)
self.assertSplitAddsUp(run, count, size)
menu = re.search(r"RetroArch: (\d+) files, ([\d.]+ [KMG]B)[.,]([^`]*)", text)
self.assertEqual(menu.groups()[:2], (count, size))
@@ -118,10 +118,14 @@ class InstallerOutputExample(unittest.TestCase):
r"files \(([\d.]+) ([KMG]B)\)", text)
self.assertIsNotNone(split, "a categorized list says its BIOS files and game data")
bios, bios_size, bios_unit, games, game_size, game_unit = split.groups()
self.assertEqual(int(bios) + int(games), int(count))
# The data files in the one total, the third kind (code_audit_21 P3-8).
data = re.search(r"and (\d+) data files \(([\d.]+) ([KMG]B)\)", text)
data_count, data_size, data_unit = data.groups() if data else ("0", "0", "KB")
self.assertEqual(int(bios) + int(games) + int(data_count), int(count))
units = {"KB": 1, "MB": 1024, "GB": 1024 ** 2}
total, unit = size.split()
added = (float(bios_size) * units[bios_unit] + float(game_size) * units[game_unit])
added = (float(bios_size) * units[bios_unit] + float(game_size) * units[game_unit]
+ float(data_size) * units[data_unit])
self.assertLessEqual(abs(added - float(total) * units[unit]), 0.15 * units[unit])
@@ -744,10 +748,10 @@ class FirstInstallWalkthrough(unittest.TestCase):
self.assertIn(f'title = "{ending}"', source)
self.assertNotRegex(self.text, r"Done\. \d+ files")
count, size = re.search(r"\n (\d+) files \(([\d.]+ [KMG]B)\)", step3).groups()
self.assertIn(f"0/{count} present", step3)
self.assertIn(f"0 in place, {count} missing", step3)
self.assertIn(f"Downloading {count} files ({size})", step3)
self.assertIn(f"Done. {count} files installed", step4)
self.assertIn(f"{count}/{count} present ({count} verified", step5)
self.assertIn(f"{count} in place, 0 missing", step5)
manifest = json.loads((ROOT / "install" / "batocera.json").read_text(encoding="utf-8"))
omitted = re.search(r"Not installable: (\d+) files \((\d+) required", step3)
if manifest.get("omitted_files"):
tests/test_install.py
+3 -3
View File
@@ -3550,7 +3550,7 @@ class ARefusedStandaloneCopyIsNamed(unittest.TestCase):
install._report_outcome([bios], 0, 1, failed, 0, False, failures=failures)
text = out.getvalue()
self.assertIn(str(target / "scph5501.bin"), text)
self.assertIn(str(target), text.split("Location")[1])
self.assertIn(str(target), text.split("BIOS folder")[-1])
self.assertIn("cannot write there", text)
@@ -4534,7 +4534,7 @@ class ANetworkFailureNamesTheNetwork(unittest.TestCase):
self.assertEqual(raised.exception.code, 2)
text = out.getvalue()
self.assertIn("HTTPS_PROXY", text)
self.assertIn("Destination: /bios", text)
self.assertIn("BIOS folder: /bios", text)
self.assertNotIn("being written to", text)
@@ -5225,7 +5225,7 @@ class EventsDescribeTheRun(unittest.TestCase, _SyntheticTree):
"interrupted": False},
{"event": "end", "code": 1},
])
self.assertIn("2/4 present (1 verified, 1 wrong hash)", proc.stderr)
self.assertIn("1 in place, 2 missing, 1 wrong copy", proc.stderr)
self.assertFalse((self.bios / "c.bin").exists())
def test_an_install_run(self):
tests/test_install_experience.py
+2 -2
View File
@@ -678,7 +678,7 @@ class AHomeThisUserCannotOpen(unittest.TestCase):
with self.subTest(run=name):
self.assertNotIn("Traceback", proc.stderr)
# A named folder needs no detection and is checked.
self.assertIn("0/5 present", runs["named"].stdout)
self.assertIn("0 in place, 5 missing", runs["named"].stdout)
self.assertIn(f"Could not look for setups: this user cannot open {home}",
runs["detected"].stderr)
@@ -811,7 +811,7 @@ class APartlyClosedHome(unittest.TestCase):
self.assertNotIn(str(home / ".config" / "retroarch" / "system"),
proc.stdout + proc.stderr)
self.assertIn(f"Found RetroArch at {system}", runs["detected"].stdout)
self.assertIn("0/5 present", runs["named"].stdout)
self.assertIn("0 in place, 5 missing", runs["named"].stdout)
self.assertNotIn("not detected", runs["named"].stdout)
events = [json.loads(line) for line in runs["events"].stdout.splitlines()]
kinds = [event["event"] for event in events]
tests/test_install_selection.py
+1 -1
View File
@@ -1459,7 +1459,7 @@ class ThePlatformsOwnListAlone(unittest.TestCase):
with self.subTest(mode=mode), FakeRepository() as repo:
proc = repo.run("--declared-only", mode)
self.assertIn("5 to 3 files", proc.stdout, proc.stderr)
self.assertIn("0/3 present", proc.stdout)
self.assertIn("0 in place, 3 missing", proc.stdout)
self.assertEqual(repo.installed(), [])
def test_it_composes_with_the_other_narrowings(self):
tests/test_install_tui.py
+185 -14
View File
@@ -771,7 +771,8 @@ class PlanWarnings(unittest.TestCase):
self.assertIn("You cannot write to this folder: choose another one.", text)
# sudo changes the home folder: the advice names this one.
self.assertIn("Or run it as root, this folder named: sudo python3 install.py "
f"--platform retroarch --dest {SYSTEM_DIR}", " ".join(text.split()))
f"--platform retroarch --dest {SYSTEM_DIR}",
" ".join(text.replace(" \\", "").split()))
rows = install.tui_rows(state)
self.assertEqual([row.action for row in rows[:2]], ["folder", "install"])
self.assertEqual(state.focus.get("plan", 0), 0)
@@ -3737,8 +3738,9 @@ class AuditFive(unittest.TestCase):
saves = {"files": 1, "folder": str(HOME / ".config" / "retroarch" / "saves" / "<core>")}
lines = install._saves_lines(state, saves)
# In words: "saves/<core>" read as a folder named <core>.
# The folder at the BIOS folder's indent (tui_audit_14 P3-9).
self.assertEqual(lines, ["1 file read from RetroArch's save directory goes to a "
"folder per core under:", "~/.config/retroarch/saves"])
"folder per core under:", " ~/.config/retroarch/saves"])
def test_the_shared_note_is_one_line(self):
state = self.long_list()
@@ -7578,7 +7580,7 @@ class LineModeAndScreenDecideAlike(_LineModeFindings, _OutsideTextFindings,
self.assertIn("g) Game data: kept (3 files, 120 B): leave it out", text)
self.assertIn(" 4 files (123 B)\n 1 BIOS file (3 B) and 3 game data files (120 B).",
text)
self.assertIn("0/4 present", text)
self.assertIn("0 in place, 4 missing, 0 wrong copies", text)
self.assertIn("4 files (123 B)", text[text.index("Checking existing files"):])
def test_g_counts_the_systems_chosen_and_leaves_out_what_it_said(self):
@@ -9966,8 +9968,12 @@ class TheAndroidResultReadsWhole(unittest.TestCase):
lines = [str(line).strip() for line in self.result(cols)]
words = [word for line in lines for word in line.split()]
self.assertIn("--restore", words)
# The command keeps it whole, to be copied as one word.
self.assertIn(full, words)
# The command keeps it whole where its line holds it, cut to
# its last folders and said so where not (tui_audit_14 P3-8).
if cols >= 60:
self.assertIn(full, words)
else:
self.assertIn(install.TUI_SHORTENED, lines)
# Prose breaks it after a separator only, never inside a name
# (tui_audit_13 P3-3): glued again, it is whole.
self.assertIn(full, re.sub(r"/ ", "/", " ".join(lines)))
@@ -9979,8 +9985,11 @@ class TheAndroidResultReadsWhole(unittest.TestCase):
state.stack.append("result")
pieces = install._text_lines([command], 38, whole=True)
joined = [str(piece).strip() for piece in pieces if piece.style != "cont"]
self.assertIn(install.BOOTSTRAP_URL, joined)
self.assertIn("'/storage/emulated/0/a b/20261027-223524'", joined)
# The address never cut, the option with its value, each line but
# the last ending with the shell's continuation.
self.assertIn(f"{install.BOOTSTRAP_URL} \\", joined)
self.assertTrue(any(line.startswith("--restore '") for line in joined), joined)
self.assertTrue(all(len(str(piece)) <= 38 for piece in pieces), pieces)
def test_a_long_line_folds_in_the_terminal(self):
terminal = install._TuiTerminal.__new__(install._TuiTerminal)
@@ -10854,10 +10863,12 @@ class AuditNineteenAndTwelve(_CardFixtures, unittest.TestCase):
width = len(path) + 1
lines = install._wrap(f"BIOS folder: {path}", width, whole="text")
self.assertEqual(lines, ["BIOS folder:", path])
command = install._wrap(f" python3 install.py --dest {path}", width + 1,
# A command keeps the option with its value, the path whole where
# the line holds them (tui_audit_14 P3-8).
command = install._wrap(f" python3 install.py --dest {path}", width + 10,
whole="command")
self.assertIn(f" {path}", command)
self.assertTrue(all(len(line) <= width + 1 for line in command), command)
self.assertIn(f" --dest {path}", command)
self.assertTrue(all(len(line) <= width + 10 for line in command), command)
def test_the_result_spells_each_folder_one_way(self):
"""tui_audit_12 P3-7: the save folder as ~/ beside full paths."""
@@ -10865,7 +10876,7 @@ class AuditNineteenAndTwelve(_CardFixtures, unittest.TestCase):
state.done_saves = {"event": "saves", "files": 2,
"folder": "/home/user/.config/retroarch/saves/<core>"}
_title, lines = install.tui_outcome(state)
self.assertIn("/home/user/.config/retroarch/saves", lines)
self.assertIn("/home/user/.config/retroarch/saves", [line.strip() for line in lines])
self.assertFalse(any(line.startswith("~") for line in lines))
def test_minui_names_the_folder_of_its_plan(self):
@@ -11506,7 +11517,11 @@ class AuditTwentyAndThirteen(unittest.TestCase):
while pieces[-1].endswith("/") and lines[at + len(pieces)]:
pieces.append(lines[at + len(pieces)])
spelled.append(pieces)
self.assertNotIn("...", " ".join(lines))
# A command's path may be cut to fit, said so: a folder
# in prose never is.
self.assertNotIn("...", " ".join(
line for line in lines if install.tui_command(state)[:10] not in line
and not line.startswith("--")))
self.assertTrue(all(len(piece) <= cols - 2 for piece in pieces), pieces)
self.assertEqual(spelled[0], spelled[1])
self.assertEqual("".join(spelled[0]), f"BIOS folder: {dest}")
@@ -11516,9 +11531,9 @@ class AuditTwentyAndThirteen(unittest.TestCase):
under an indent of 6."""
path = "/home/moi/retroarch_system/tmp/tui_audit13/pack/MinUI_2025-11_BIOS_Pack.zip"
self.assertEqual(len(path), 75)
lines = install._wrap(f" python3 install.py --from-pack {path}", 78,
lines = install._wrap(f" python3 install.py --from-pack {path}", 95,
whole="command")
self.assertIn(path, lines)
self.assertIn(f" --from-pack {path}", lines)
def test_the_definition_is_said_once_and_never_spliced(self):
"""tui_audit_13 P3-5."""
@@ -12346,6 +12361,162 @@ class AuditTwentyOneAndFourteen(unittest.TestCase):
_title, lines = install.tui_outcome(state)
self.assertIn("7 data files not installed: not in RetroArch_BIOS_Pack.zip.", lines)
def test_a_command_at_40_columns_breaks_between_shell_words(self):
"""tui_audit_14 P3-8: the terminal folded commands inside a word,
"--platform" ended a line with its value on the next."""
words = ["--platform", "retroarch", "--dest", "/a/b/c/system", "--manifest",
"/home/moi/x.json", "--system", "nintendo-gba"]
text = "printf '%s\\n' " + " ".join(words)
with mock.patch.dict(os.environ, {"RETROBIOS_BOOTSTRAP": "sh"}):
lines = install._wrap(text, 38, whole="command")
self.assertGreater(len(lines), 1)
self.assertTrue(all(install.cell_width(line) <= 38 for line in lines), lines)
self.assertTrue(all(line.endswith(" \\") for line in lines[:-1]), lines)
for line in lines:
# An option never ends a line without its value.
self.assertFalse(line.removesuffix(" \\").rstrip().endswith(
("--platform", "--dest", "--manifest", "--system")), lines)
# The shell reads the lines as the command: the same words.
proc = subprocess.run(["sh", "-c", "\n".join(lines)], capture_output=True, text=True,
check=True)
self.assertEqual(proc.stdout.split(), words)
# A path wider than a line keeps its last folders, said so, and the
# address of the one-liner is never cut.
state = _installed_state(Path("/home/moi/retroarch_system/tmp/tui_audit14/sb/a/b/bios"))
state.summary["kept"] = [{"folder": "/home/moi/retroarch_system/tmp/tui_audit14/sb/"
"retrobios-backup/2026", "files": 1, "bytes": 1}]
with mock.patch.dict(os.environ, {"RETROBIOS_BOOTSTRAP": "sh"}):
screen = [str(line) for line in install.tui_view(state, 40, 40)]
self.assertTrue(all(install.cell_width(line) <= 40 for line in screen), screen)
self.assertIn(install.TUI_SHORTENED, " ".join(screen))
self.assertIn(install.BOOTSTRAP_URL, " ".join(screen))
state.exit_code = 0
farewell = "\n".join(install.tui_farewell(state))
self.assertIn("/home/moi/retroarch_system/tmp/tui_audit14/sb/a/b/bios", farewell)
def test_a_folder_on_its_own_line_has_one_indent(self):
"""tui_audit_14 P3-9: the save folder at the label's indent, the
BIOS folder under it, a path's last piece without its indent."""
state = checked_state()
state.dest = Path("/home/moi/retroarch_system/tmp/tui_audit14/sb/esmiyoo/home/"
".config/retroarch/system")
state.saves = {"files": 1, "folder": "/home/moi/retroarch_system/tmp/tui_audit14/"
"sb/and2/storage/RetroArch/saves/<core>"}
for cols in (40, 80):
with self.subTest(cols=cols):
lines = [str(line) for line in install.tui_view(state, cols, 40)]
folder = next(i for i, line in enumerate(lines) if "BIOS folder:" in line)
under = next(i for i, line in enumerate(lines) if "under:" in line)
for at in (folder, under):
pieces = []
for line in lines[at + 1:]:
if not line.strip() or "/" not in line or " " in line.strip():
break
pieces.append(line)
indents = {len(piece) - len(piece.lstrip()) for piece in pieces}
self.assertLessEqual(len(indents), 1, pieces)
if pieces:
self.assertEqual(indents, {3}, pieces)
def test_no_shift_where_there_is_no_shift_key(self):
"""tui_audit_14 P3-3: "Shift and a drag" on Android."""
for os_type, said in (("linux", True), ("android", False)):
with self.subTest(os_type=os_type):
state = _installed_state(SYSTEM_DIR)
state.os_type, state.mouse = os_type, True
_title, lines = install.tui_outcome(state)
self.assertEqual(any("Shift" in line for line in lines), said)
self.assertIn(install.TUI_RESULT_AGAIN, lines[-1])
state.help = True
text = " ".join(install.tui_view(state, 80, 24))
self.assertEqual("Shift+drag" in text, said)
def test_the_40x12_setup_never_ends_mid_sentence(self):
"""tui_audit_14 P3-5."""
state = fresh_state()
state.notes = [install.TUI_ESDE_NOTE]
text = [str(line).strip() for line in install.tui_view(state, 40, 12)]
self.assertIn(install.TUI_ESDE_SHORT, text)
self.assertFalse(any(line.startswith("ES-DE found") for line in text), text)
text = " ".join(" ".join(install.tui_view(state, 80, 24)).split())
self.assertIn(install.TUI_ESDE_NOTE, text)
def test_the_40x12_plan_keeps_its_folder_and_version_note(self):
"""tui_audit_14 P3-6: the plan named ~/.var/app/ as the folder, and
the version note was absent."""
state = checked_state()
state.dest = HOME / ".var/app/org.libretro.RetroArch/config/retroarch/system"
state.version = "This list was built for RetroBat 8.3.1, this machine runs 8.2.0.1."
lines = [str(line).strip() for line in install.tui_view(state, 40, 12)]
joined = "".join(line for line in lines if line.endswith("/") or "system" in line)
self.assertIn("~/.var/app/org.libretro.RetroArch/config/retroarch/system", joined)
self.assertIn(state.version, " ".join(" ".join(lines).split()))
self.assertTrue(any(re.fullmatch(r"1-\d+ of \d+", line) for line in lines), lines)
self.assertIn("> Install", lines)
def test_one_count_said_once_in_both_modes(self):
"""tui_audit_14 P3-10: "22 files installed." over "22 files copied
from packx.", and line mode's Location, wrong hash and zero count."""
state = _installed_state(SYSTEM_DIR)
state.summary["installed"] = 5
state.finished = [(f"f{n}.bin", True, "") for n in range(5)]
state.local_dests = {f"f{n}.bin": ("/media/packx", "") for n in range(5)}
_title, lines = install.tui_outcome(state)
self.assertEqual(lines[0], "5 files copied from packx.")
self.assertNotIn("5 files installed.", lines)
files = [self.entry("gba_bios.bin", b"gba", ["nintendo-gba"])]
listing = self.listing("retroarch", files)
proc = install_run("--platform", "retroarch", "--manifest", str(listing),
"--dest", str(self.here), "--check", "--offline")
self.assertIn("0 in place, 1 missing, 0 wrong copies", proc.stdout)
self.assertNotIn("present (", proc.stdout)
source = (REPO_ROOT / "install.py").read_text(encoding="utf-8")
self.assertNotIn('say(f"Location', source)
self.assertNotIn("already up to date.\")\n", source.split("\nDone.", 1)[-1][:300])
def test_quit_names_stay_once(self):
"""tui_audit_14 P3-11: "A/Enter Stay B/Esc Stay"."""
state = fresh_state()
state.stack.append("quit")
state.focus["quit"] = 1
self.assertEqual(str(install.tui_view(state, 80, 24)[-1]).count("Stay"), 1)
def test_the_yes_stop_example_keeps_yes(self):
"""tui_audit_14 P3-12: a script copying the example stopped at a
question."""
files = [self.entry("gba_bios.bin", b"gba", ["nintendo-gba"])]
listing = self.listing("retroarch", files)
proc = install_run("--yes", "--manifest", str(listing), "--offline",
env={"HOME": str(self.root / "home"), "RETROBIOS_OS": "linux"})
example = next(line for line in proc.stderr.splitlines()
if "--platform retroarch --dest" in line)
self.assertIn(" --yes", example)
def test_the_systems_question_fits_the_terminal(self):
"""code_audit_21 P3-9: 53 of 66 rows wider than 80 columns."""
rows = [(f"system-{n}", [{"dest": f"{n}.bin", "size": 10 ** n}]) for n in range(6)]
labels = {"system-0": "Sega Dreamcast-based arcade boards, each "
"them sega-dreamcast-arcade",
**{f"system-{n}": f"Short {n}" for n in range(1, 6)}}
with mock.patch.object(install.shutil, "get_terminal_size",
return_value=os.terminal_size((80, 24))), \
mock.patch.object(install, "_ask", return_value=""), \
contextlib.redirect_stdout(io.StringIO()) as out:
install._pick("Systems:", rows, labels=labels)
printed = out.getvalue().splitlines()
self.assertTrue(all(install.cell_width(line) <= 80 for line in printed), printed)
# The long label on its own line, its size under it in the column.
at = next(i for i, line in enumerate(printed) if "sega-dreamcast-arcade" in line)
self.assertNotIn("B", printed[at].split("arcade", 1)[1])
sizes = {line.index("1 file") for line in printed[at + 1:] if "1 file" in line}
self.assertEqual(len(sizes), 1, printed)
def test_the_save_dir_sentence_is_written_once(self):
"""code_audit_21 P3-10."""
source = (REPO_ROOT / "install.py").read_text(encoding="utf-8")
self.assertEqual(source.count('"Name it with --save-dir next time."'), 1)
self.assertEqual(source.count("args.declared_only or len(files) + game_data_cut"), 1)
def test_a_missing_folder_does_not_exist_yet_on_every_row(self):
"""code_audit_21 P3-7: line mode said "(created)" of folders nobody
created, and the screen said "does not exist yet" of the Windows row