fix: skip scratch downloads in the restore scan

This commit is contained in:
Abdessamad Derraz committed 2026-11-05 11:40:17 +01:00
1 parent d38cd58036
commit 28a8eec1c4
2 files changed
+34

No files matched your search

+29
View File
@@ -214,5 +214,34 @@ class ScratchFilesGetThePlainMode(unittest.TestCase):
self.assertEqual(unset, [])
class RestoreSkipsDownloadsInProgress(unittest.TestCase):
"""A scratch file another run is still writing is neither hashed nor read."""
def test_a_scratch_promoted_mid_scan_does_not_stop_the_restore(self) -> None:
import restore_large_files
with tempfile.TemporaryDirectory() as tmp:
cache = Path(tmp)
(cache / "done.bin").write_bytes(b"whole")
scratch = cache / "big.bin.ab12.tmp"
scratch.write_bytes(b"part")
real_isfile = os.path.isfile
def check_then_promote(path: str) -> bool:
found = real_isfile(path)
# The concurrent fetch renames its scratch file right after
# the check, before the open.
if path == str(scratch) and found:
os.replace(scratch, cache / "big.bin")
return found
with mock.patch.object(restore_large_files.os.path, "isfile",
side_effect=check_then_promote):
index = restore_large_files.index_cache(str(cache))
self.assertNotIn(str(scratch), index.values())
self.assertIn(str(cache / "done.bin"), index.values())
if __name__ == "__main__":
unittest.main()