kmoody/libretro
1
0
Fork 0
mirror of https://github.com/Abdess/retroarch_system.git synced 2026-04-13 12:22:33 -05:00
Code Issues Packages Projects Releases Wiki Activity

feat: support min_size/max_size validation in verify.py

Browse Source 
reproduces ground truth size checks from emulator profiles: exact
size, min_size lower bound, max_size upper bound. all 66 tests pass.
This commit is contained in:
Abdessamad Derraz
2026-03-24 10:53:01 +01:00
parent ef365c6680
commit 470bb6ceb9
1 changed files with 23 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
scripts/verify.py
View File

@@ -111,21 +111,27 @@ def _build_validation_index(profiles: dict) -> dict[str, dict]:
if fname not in index:
index[fname] = {
"checks": set(), "size": None,
"min_size": None, "max_size": None,
"crc32": None, "md5": None, "sha1": None,
}
sources[fname] = {}
index[fname]["checks"].update(checks)
if "size" in checks and f.get("size") is not None:
new_size = f["size"]
prev_size = index[fname]["size"]
if prev_size is not None and prev_size != new_size:
prev_emu = sources[fname].get("size", "?")
raise ValueError(
f"validation conflict for '{fname}': "
f"size={prev_size} ({prev_emu}) vs size={new_size} ({emu_name})"
)
index[fname]["size"] = new_size
sources[fname]["size"] = emu_name
if "size" in checks:
if f.get("size") is not None:
new_size = f["size"]
prev_size = index[fname]["size"]
if prev_size is not None and prev_size != new_size:
prev_emu = sources[fname].get("size", "?")
raise ValueError(
f"validation conflict for '{fname}': "
f"size={prev_size} ({prev_emu}) vs size={new_size} ({emu_name})"
)
index[fname]["size"] = new_size
sources[fname]["size"] = emu_name
if f.get("min_size") is not None:
index[fname]["min_size"] = f["min_size"]
if f.get("max_size") is not None:
index[fname]["max_size"] = f["max_size"]
if "crc32" in checks and f.get("crc32"):
new_crc = f["crc32"].lower()
if new_crc.startswith("0x"):
@@ -174,10 +180,14 @@ def check_file_validation(
if not entry:
return None
checks = entry["checks"]
if "size" in checks and entry["size"] is not None:
if "size" in checks:
actual_size = os.path.getsize(local_path)
if actual_size != entry["size"]:
if entry["size"] is not None and actual_size != entry["size"]:
return f"size mismatch: expected {entry['size']}, got {actual_size}"
if entry["min_size"] is not None and actual_size < entry["min_size"]:
return f"size too small: min {entry['min_size']}, got {actual_size}"
if entry["max_size"] is not None and actual_size > entry["max_size"]:
return f"size too large: max {entry['max_size']}, got {actual_size}"
# Hash checks — compute once, reuse
need_hashes = any(
h in checks and entry.get(h) for h in ("crc32", "md5", "sha1")