From 479ada29fee440630f32161e7b15d657650ab767 Mon Sep 17 00:00:00 2001 From: Abdessamad Derraz <3028866+Abdess@users.noreply.github.com> Date: Tue, 20 Oct 2026 19:47:40 +0200 Subject: [PATCH] docs: word removal candidates by what was searched "No core opens it" claimed more than the search shows: what was checked is that no profile of a core the platform runs names the entry by name, path or hash. The reason and the page sentence now say that. --- scripts/exporter/candidates.py | 2 +- scripts/siteexports.py | 3 ++- tests/test_export_report.py | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/scripts/exporter/candidates.py b/scripts/exporter/candidates.py index 2a944553..99016c1a 100644 --- a/scripts/exporter/candidates.py +++ b/scripts/exporter/candidates.py @@ -132,7 +132,7 @@ def _loads_romsets(profile: dict) -> bool: _ARCHIVES = (".zip", ".7z") REASONS = { - "candidate": "no core the platform runs opens it", + "candidate": "no profile of a core the platform runs names it", "unresolved": "a core the platform names has no profile yet", "romset": "a ROM set, and these cores open sets their profiles do not list", } diff --git a/scripts/siteexports.py b/scripts/siteexports.py index e378295b..bf85862b 100644 --- a/scripts/siteexports.py +++ b/scripts/siteexports.py @@ -124,7 +124,8 @@ def candidate_lines(candidates: list[dict]) -> list[str]: count = _plural(len(candidates), "entry", "entries") sentence = ( f"{count} of the original {'is' if len(candidates) == 1 else 'are'} not " - "opened by any profiled emulator this platform runs. " + "named, by name, path or hash, in the profile of any emulator this " + "platform runs. " f"{'It stays' if len(candidates) == 1 else 'They stay'} in the updated file" ) if open_question: diff --git a/tests/test_export_report.py b/tests/test_export_report.py index 77db124d..d6486af1 100644 --- a/tests/test_export_report.py +++ b/tests/test_export_report.py @@ -418,7 +418,7 @@ class RemovalCandidatesNeedAReadingNoCoreAnswers(unittest.TestCase): "cores_examined": [], "unresolved_cores": []}, ]) page = generate_exports_page([report], {}) - self.assertIn("1 entry of the original is not opened", page) + self.assertIn("1 entry of the original is not named, by name, path or hash", page) self.assertIn("- `Enterprise` `zt18hfnt.rom`", page) self.assertNotIn("no entry the platform declares is removed", page)