From 4b38e255052069d5ec8ce3e16a470f8c3f413e39 Mon Sep 17 00:00:00 2001 From: Abdessamad Derraz <3028866+Abdess@users.noreply.github.com> Date: Fri, 16 Oct 2026 06:44:25 +0200 Subject: [PATCH] fix: drop advancemame archive-level checks --- emulators/advancemame.yml | 26 -------------------------- tests/test_profile_checks.py | 14 ++++++++++++++ 2 files changed, 14 insertions(+), 26 deletions(-) diff --git a/emulators/advancemame.yml b/emulators/advancemame.yml index f90008b2..619335e6 100644 --- a/emulators/advancemame.yml +++ b/emulators/advancemame.yml @@ -130,7 +130,6 @@ files: Eight MVS BIOS variants selected with misc_bios (euro, euro-s1, us, us-e, asia, japan, japan-s2, japan-s1), euro by default. sm1.sm1, 000-lo.lo and sfix.sfx are loaded whichever variant is selected. - validation: [size, crc32, sha1] contents: - name: sp-s2.sp1 description: Europe MVS (Ver. 2) @@ -194,7 +193,6 @@ files: category: bios_zip system: igs-pgm source_ref: "src/drivers/pgm.c:3708-3719,5487" - validation: [size, crc32, sha1] contents: - name: pgm_p01s.rom description: 68000 BIOS @@ -221,7 +219,6 @@ files: note: >- Nine BIOS variants selected with misc_bios (japan, japana, us, japanb, taiwan, europe, unknown, dev1061, japanc), japan by default. - validation: [size, crc32, sha1] contents: - name: epr19730.ic8 description: Japan (bios epr19730) @@ -278,7 +275,6 @@ files: note: >- Two BIOS variants selected with misc_bios (ver1, ver2), ver1 by default. - validation: [size, crc32, sha1] contents: - name: ep15294.ic2 description: Mega Play BIOS (Ver. 1) @@ -297,7 +293,6 @@ files: category: bios_zip system: sega-megatech source_ref: "src/drivers/megatech.c:454-457,866" - validation: [size, crc32, sha1] contents: - name: epr12664.20 size: 32768 @@ -314,7 +309,6 @@ files: Two main CPU BIOS variants selected with misc_bios (bios0, bios1), bios0 by default. The audio CPU, MCU and PROMs are loaded whichever variant is selected. - validation: [size, crc32, sha1] contents: - name: rms8.cpu description: main CPU BIOS (bios0) @@ -366,7 +360,6 @@ files: note: >- Two BIOS variants selected with misc_bios (dual, single), dual by default. Tiles and PROMs are loaded whichever variant is selected. - validation: [size, crc32, sha1] contents: - name: pch1-c.8t description: Dual Monitor Version @@ -415,7 +408,6 @@ files: category: bios_zip system: nintendo-nss source_ref: "src/drivers/nss.c:524-526,657" - validation: [size, crc32, sha1] contents: - name: spc700.rom description: SPC700 IPL ROM @@ -446,7 +438,6 @@ files: source_ref: "src/drivers/suprnova.c:1269-1276,1744" note: >- Five region BIOS ROMs, all loaded into the same region. - validation: [size, crc32, sha1] contents: - name: sknsj1.u10 description: Japan @@ -480,7 +471,6 @@ files: category: bios_zip system: konami-gx source_ref: "src/drivers/konamigx.c:2138-2141,3485" - validation: [size, crc32, sha1] contents: - name: 300a01.34k size: 131072 @@ -493,7 +483,6 @@ files: category: bios_zip system: konami-gv source_ref: "src/drivers/konamigv.c:972-976,1058" - validation: [size, crc32, sha1] contents: - name: 999a01.7e size: 524288 @@ -506,7 +495,6 @@ files: category: bios_zip system: century-cvs source_ref: "src/drivers/cvs.c:420-430,1401" - validation: [size, crc32, sha1] contents: - name: 5b.bin description: sound CPU @@ -530,7 +518,6 @@ files: category: bios_zip system: capcom-zn1 source_ref: "src/drivers/zn.c:3127-3129,4513" - validation: [size, crc32, sha1] contents: - name: coh-1000c.353 size: 524288 @@ -543,7 +530,6 @@ files: category: bios_zip system: capcom-zn2 source_ref: "src/drivers/zn.c:3362-3364,4531" - validation: [size, crc32, sha1] contents: - name: coh-3002c.353 size: 524288 @@ -556,7 +542,6 @@ files: category: bios_zip system: tecmo-tps source_ref: "src/drivers/zn.c:3805-3807,4578" - validation: [size, crc32, sha1] contents: - name: coh-1002m.353 size: 524288 @@ -569,7 +554,6 @@ files: category: bios_zip system: taito-fx1 source_ref: "src/drivers/zn.c:4040-4042,4603" - validation: [size, crc32, sha1] contents: - name: coh-1000t.353 size: 524288 @@ -582,7 +566,6 @@ files: category: bios_zip system: eighting-zn1 source_ref: "src/drivers/zn.c:4312-4314,4630" - validation: [size, crc32, sha1] contents: - name: coh-1002e.353 size: 524288 @@ -595,7 +578,6 @@ files: category: bios_zip system: atlus-zn1 source_ref: "src/drivers/zn.c:4483-4485,4642" - validation: [size, crc32, sha1] contents: - name: coh-1001l.353 size: 524288 @@ -608,7 +590,6 @@ files: category: bios_zip system: atari-zn1 source_ref: "src/drivers/zn.c:4398-4400,4558" - validation: [size, crc32, sha1] contents: - name: coh-1000w.353 size: 524288 @@ -621,7 +602,6 @@ files: category: bios_zip system: acclaim-zn1 source_ref: "src/drivers/zn.c:4421-4423,4567" - validation: [size, crc32, sha1] contents: - name: coh-1000a.353 size: 524288 @@ -634,7 +614,6 @@ files: category: bios_zip system: hyper-neogeo64 source_ref: "src/drivers/hng64.c:1425-1431,1718" - validation: [size, crc32, sha1] contents: - name: brom1.bin description: R4300 BIOS @@ -662,7 +641,6 @@ files: Three BIOS variants selected with misc_bios (onep300, onep211, tenp211), onep300 by default. kick12.rom is loaded whichever variant is selected. - validation: [size, crc32, sha1] contents: - name: kick12.rom description: Amiga Kickstart 1.2 @@ -726,7 +704,6 @@ files: category: bios_zip system: exidy-maxaflex source_ref: "src/drivers/maxaflex.c:518-527,583" - validation: [size, crc32, sha1] contents: - name: atarixl.rom description: main CPU ROM @@ -750,7 +727,6 @@ files: category: bios_zip system: brezzasoft-crystal source_ref: "src/drivers/crystal.c:854-857,923" - validation: [size, crc32, sha1] contents: - name: mx27l1000.u14 size: 131072 @@ -763,7 +739,6 @@ files: category: bios_zip system: imax-macs source_ref: "src/drivers/macs.c:394-402,612" - validation: [size, crc32, sha1] contents: - name: macsos_l.u43 description: BIOS low byte @@ -781,7 +756,6 @@ files: required: true category: bios_zip source_ref: "src/drivers/mpu4.c:2014-2017,2175" - validation: [size, crc32, sha1] contents: - name: vid.p1 size: 65536 diff --git a/tests/test_profile_checks.py b/tests/test_profile_checks.py index 438f4e61..2cff83b3 100644 --- a/tests/test_profile_checks.py +++ b/tests/test_profile_checks.py @@ -190,5 +190,19 @@ class EightyOneRoms(_Probe): self.assertNotIn("crc32", entry.get("validation") or []) +class AdvanceMameArchives(_Probe): + """verify_length_and_hash checks each member and only adds a warning; the + archive itself has no size or hash anyone checks (src/romload.c:327-363 + at 21f8f6f). The 26 BIOS archives declared archive-level checks with no + archive values.""" + + def test_no_archive_level_check(self): + for entry in _profile("advancemame")["files"]: + if entry.get("category") == "bios_zip": + with self.subTest(name=entry["name"]): + self.assertFalse(entry.get("validation")) + self.assertTrue(entry.get("contents")) + + if __name__ == "__main__": unittest.main()