refactor: one emudeck script-to-profile rule

The target scraper kept its own copy of the EmuScripts table and took
.ps1 files the platform scraper never read, so emudeck-we's template
skeleton was published as a core and removed afterwards by an override.
Both scrapers now read emulator_of_script, and the platform scraper
lists the installers at the pinned revision, as launchers: and the
SteamOS target already did. Targets rescraped, override dropped.

scripts/scraper/emudeck_launchers.py

@@ -46,14 +46,18 @@ STORAGE = "${storagePath}"
 FLATPAK_DATA = "${HOME}/.var/app/"
 
 # EmuScripts file names that differ from the emulator profile they set up.
+# The platform and target scrapers both read them here.
 SCRIPT_EMULATORS = {
     "pcsx2qt": "pcsx2",
     "rpcs3legacy": "rpcs3",
     "cemuproton": "cemu",
     "rmg": "mupen64plus_next",
 }
-# The main RetroArch config script installs no emulator.
-NOT_EMULATORS = {"retroarch_maincfg"}
+# The main RetroArch config script installs no emulator, and emudeck-we's
+# emuDeckTemplate.ps1 is the skeleton new installers are copied from.
+NOT_EMULATORS = {"retroarch_maincfg", "template"}
+# EmuDeck's SteamOS installers are shell scripts, emudeck-we's PowerShell.
+SCRIPT_SUFFIXES = (".sh", ".ps1")
 
 # What the emulator does with a directory written into each key.
 DIRECTORY_KINDS = {
@@ -66,9 +70,10 @@ DIRECTORY_KINDS = {
 
 def emulator_of_script(file_name: str) -> str | None:
     """The emulator an EmuScripts file sets up, None for a helper script."""
-    if not file_name.endswith(".sh"):
+    stem, dot, suffix = file_name.rpartition(".")
+    if not dot or f".{suffix}" not in SCRIPT_SUFFIXES:
         return None
-    key = re.sub(r"^emuDeck", "", file_name[: -len(".sh")], flags=re.IGNORECASE).lower()
+    key = re.sub(r"^emuDeck", "", stem, flags=re.IGNORECASE).lower()
     if not key or key in NOT_EMULATORS:
         return None
     return SCRIPT_EMULATORS.get(key, key)

scripts/scraper/emudeck_scraper.py

@@ -469,9 +469,10 @@ class Scraper(BaseScraper):
 
         version = fetch_github_latest_version("dragoonDorise/EmuDeck")
 
-        cores = self._fetch_installed_emulators()
+        revision = launcher_revision(self.checkbios_url)
+        cores = self._fetch_installed_emulators(revision)
         standalone = [core for core in cores if core != "retroarch"]
-        tree = RepoTree.github(EMUDECK_REPO, launcher_revision(self.checkbios_url))
+        tree = RepoTree.github(EMUDECK_REPO, revision)
         libretro = set(installed_libretro_cores(tree.read(RETROARCH_SCRIPT)))
 
         return {
@@ -501,16 +502,16 @@ class Scraper(BaseScraper):
             "launchers": extract_launchers(tree),
         }
 
-    def _fetch_installed_emulators(self) -> list[str]:
-        """Fetch the list of emulators installed by EmuDeck from EmuScripts.
-
-        Returns core names normalized to match emulator profile keys.
+    def _fetch_installed_emulators(self, revision: str) -> list[str]:
+        """The emulators EmuDeck's EmuScripts install at the pinned revision,
+        named as their profiles are: the launcher layer and the SteamOS
+        target are read at that revision too.
         """
         import json
 
         api_url = (
             "https://api.github.com/repos/dragoonDorise/EmuDeck/"
-            "contents/functions/EmuScripts"
+            f"contents/functions/EmuScripts?ref={revision}"
         )
         try:
             req = urllib.request.Request(api_url, headers=github_headers())

scripts/scraper/targets/emudeck_targets_scraper.py

@@ -12,7 +12,6 @@ from __future__ import annotations
 
 import argparse
 import json
-import re
 import sys
 import urllib.error
 import urllib.request
@@ -22,6 +21,7 @@ import yaml
 
 from common import github_token, yaml_load
 
+from ..emudeck_launchers import SCRIPT_SUFFIXES, emulator_of_script
 from . import BaseTargetScraper
 
 PLATFORM_NAME = "emudeck"
@@ -33,24 +33,6 @@ WINDOWS_API = (
     "https://api.github.com/repos/EmuDeck/emudeck-we/contents/functions/EmuScripts"
 )
 
-# Map EmuDeck script names to emulator profile keys
-# Script naming: emuDeckDolphin.sh -> dolphin
-# Some need explicit mapping when names differ
-_NAME_OVERRIDES: dict[str, str] = {
-    "pcsx2qt": "pcsx2",
-    "rpcs3legacy": "rpcs3",
-    "cemuproton": "cemu",
-    "rmg": "mupen64plus_next",
-    "bigpemu": "bigpemu",
-    "eden": "eden",
-    "suyu": "suyu",
-    "ares": "ares",
-}
-
-# Scripts that are not emulators (config helpers, etc.)
-_SKIP = {"retroarch_maincfg", "retroarch"}
-
-
 def _fetch(url: str) -> str:
     headers = {"User-Agent": "retrobios-scraper/1.0"}
     token = github_token()
@@ -69,26 +51,13 @@ def _list_emuscripts(api_url: str) -> list[str]:
     """List emulator script filenames from GitHub API."""
     entries = json.loads(_fetch(api_url))
     names = [
-        e["name"] for e in entries if e.get("name", "").endswith((".sh", ".ps1"))
+        e["name"] for e in entries if e.get("name", "").endswith(SCRIPT_SUFFIXES)
     ]
     if not names:
         raise RuntimeError(f"no emulator scripts listed at {api_url}")
     return names
 
 
-def _script_to_core(filename: str) -> str | None:
-    """Convert EmuScripts filename to core profile key."""
-    # Strip extension and emuDeck prefix
-    name = re.sub(r"\.(sh|ps1)$", "", filename, flags=re.IGNORECASE)
-    name = re.sub(r"^emuDeck", "", name, flags=re.IGNORECASE)
-    if not name:
-        return None
-    key = name.lower()
-    if key in _SKIP:
-        return None
-    return _NAME_OVERRIDES.get(key, key)
-
-
 class Scraper(BaseTargetScraper):
     """Fetches emulator lists for EmuDeck SteamOS and Windows targets."""
 
@@ -114,14 +83,13 @@ class Scraper(BaseTargetScraper):
         seen: set[str] = set()
         has_retroarch = False
         for script in scripts:
-            core = _script_to_core(script)
-            if core and core not in seen:
+            core = emulator_of_script(script)
+            # RetroArch stands for its libretro cores, added below.
+            if core == "retroarch":
+                has_retroarch = True
+            elif core and core not in seen:
                 seen.add(core)
                 cores.append(core)
-            # Detect RetroArch presence (provides all libretro cores)
-            name = re.sub(r"\.(sh|ps1)$", "", script, flags=re.IGNORECASE)
-            if name.lower() in ("emudeckretroarch", "retroarch_maincfg"):
-                has_retroarch = True
 
         standalone_count = len(cores)
         # EmuDeck ships RetroArch = all its libretro cores are available