diff --git a/scripts/exporter/recalbox_exporter.py b/scripts/exporter/recalbox_exporter.py index 5fe9f845..676a30fa 100644 --- a/scripts/exporter/recalbox_exporter.py +++ b/scripts/exporter/recalbox_exporter.py @@ -84,7 +84,9 @@ class Exporter(BaseExporter): elif hash_match is True: attrs.append('hashMatchMandatory="true"') - note = " ".join(str(fe.native("note", "")).split()) + # The platform's own note only: ours is prose about our profiles, with + # file:line citations, and the format does not carry note corrections. + note = " ".join(str((fe.platform or {}).get("note") or "").split()) if note: attrs.append(f"note={quoteattr(note)}") diff --git a/tests/test_export_counts.py b/tests/test_export_counts.py index 6bb88c3c..a951306c 100644 --- a/tests/test_export_counts.py +++ b/tests/test_export_counts.py @@ -169,5 +169,13 @@ class OneFileOneIdentity(unittest.TestCase): declared = next(f for f in systems["dc"].files if f.platform is not None) self.assertIsNone(declared.truth) +class RecalboxKeepsItsOwnNotes(unittest.TestCase): + def test_no_profile_prose_reaches_a_note(self): + from exporter.recalbox_exporter import Exporter as Recalbox + + fe = NativeFile("bios.bin", "bios.bin", "psx", platform={"md5": A}, + truth={"md5": A, "note": "Loaded at libretro.c:120"}) + self.assertNotIn("note=", Recalbox()._bios_element(fe, "psx")) + if __name__ == "__main__": unittest.main()