fix: never prove a file by another emulator's tree

lrps2 names no hash for its GameIndex.yaml, and the only full-tail
copy was ARMSX2's: it counted as path proof and replaced the file
RetroArch pins on desktop targets, which have no ARMSX2. Upstream
PCSX2 took ARMSX2's patches.zip by name the same way. A copy in
another emulator's tree now proves nothing at any tail length, and
LRPS2's own GameIndex comes from the tree the buildbot publishes.
This commit is contained in:
Abdessamad Derraz committed 2026-10-17 08:12:24 +02:00
1 parent b9a65cd622
commit 6810e8df9a
3 files changed
+100 -13

No files matched your search

+9 -9
View File
@@ -19,6 +19,10 @@ bios_directory: "pcsx2/bios/"
resources_directory: "pcsx2/resources/"
notes: |
pcsx2/resources/GameIndex.yaml, the per-game patch, settings override and
compatibility database, is the one the buildbot publishes in LRPS2.zip (the
lrps2 data directory). An OSD warning is shown if it is missing; some games
do not boot without it.
Hard fork of PCSX2 (pre-Qt, 1.7-dev era) ported to libretro. x86_64 only.
BIOS detection is filename-agnostic: scans pcsx2/bios/ for any file between 4-8 MB
with a valid romdir structure (RESET + ROMVER entries). No hash validation.
@@ -28,6 +32,11 @@ notes: |
.info firmware_count=2 counts the bios folder and GameIndex.yaml.
.info description mentions EROM.BIN but no EROM loading path exists in the code.
data_directories:
- ref: lrps2
destination: ""
source_ref: "pcsx2/GameDatabase.cpp:49, pcsx2/GameDatabase.cpp:979"
files:
- name: "<bios>.bin"
path: "pcsx2/bios/<bios>.bin"
@@ -85,15 +94,6 @@ files:
Mechacon (disc drive controller) version as u32.
Auto-created with default 0x00020603 if missing.
- name: "GameIndex.yaml"
path: "pcsx2/resources/GameIndex.yaml"
required: false
description: "game compatibility database"
source_ref: "pcsx2/GameDatabase.cpp:49, pcsx2/GameDatabase.cpp:979"
note: >
YAML database of per-game patches, settings overrides, and compatibility fixes.
OSD warning shown if missing. Some games may not boot or have issues without it.
- name: "cheats_ws.zip"
path: "pcsx2/resources/cheats_ws.zip"
required: false