fix: refuse profile narrowings without cores

MiSTer and BizHawk declare cores: []. --region, --one-per-slot and
--no-game-data read the profiles of the cores a platform runs, so their
packs and manifests withdrew nothing under a name and README that said
they had. generate_pack and verify now refuse the flags for a named
platform and leave it out under --all.
This commit is contained in:
Abdessamad Derraz committed 2026-11-06 15:01:58 +01:00
1 parent 13a10da993
commit 6bf62d5746
6 files changed
+123 -1

No files matched your search

+25
View File
@@ -65,6 +65,7 @@ from common import (
load_database,
load_emulator_profiles,
load_platform_config,
profile_blind_platforms,
resolve_system_arg,
print_platform_listing,
select_systems,
@@ -3017,6 +3018,30 @@ def _main(held: contextlib.ExitStack) -> None:
print(f"ERROR: {reason}", file=sys.stderr)
sys.exit(1)
# generate_pack refuses these on a platform whose cores no profile
# describes, and the report answers the same request the same way.
flags = [
flag for flag, given in (
("--region", requested_regions),
("--no-game-data", getattr(args, "no_game_data", False)),
) if given
]
if flags:
blind = profile_blind_platforms(
platforms, args.platforms_dir, emu_profiles,
target_cores_cache if args.target else None,
)
for name in blind:
message = (
f"{name} runs no core a profile describes, and "
f"{', '.join(flags)} reads the profiles"
)
if not args.all:
print(f"ERROR: {message}: drop {', '.join(flags)}", file=sys.stderr)
sys.exit(1)
print(f" {message}: left out")
platforms = [name for name in platforms if name not in blind]
# Group identical platforms (same function as generate_pack)
groups = group_identical_platforms(
platforms, args.platforms_dir, target_cores_cache if args.target else None