kmoody/libretro
1
0
Fork 0
mirror of https://github.com/Abdess/retroarch_system.git synced 2026-04-13 12:22:33 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: cross-reference checks inside ZIP archives

Browse Source 
_build_supplemental_index scans both data/ directories and
contents of bios/ ZIP files. Eliminates 197 false positives
where files existed inside archive ZIPs (neogeo.zip, pgm.zip,
stvbios.zip, etc.) but were counted as missing. True missing
drops from 645 to 448.
This commit is contained in:
Abdessamad Derraz
2026-03-28 18:00:11 +01:00
parent c6a24446ba
commit 76fe7dd76f
4 changed files with 29 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
scripts/cross_reference.py
View File

@@ -50,16 +50,29 @@ def load_platform_files(platforms_dir: str) -> tuple[dict[str, set[str]], dict[s
return declared, platform_data_dirs
def _build_data_dir_index(data_root: str = "data") -> set[str]:
"""Build a set of filenames available in data/ directories."""
def _build_supplemental_index(data_root: str = "data",
bios_root: str = "bios") -> set[str]:
"""Build a set of filenames in data/ directories and inside bios/ ZIPs."""
names: set[str] = set()
root_path = Path(data_root)
if not root_path.is_dir():
return names
for fpath in root_path.rglob("*"):
if fpath.is_file() and not fpath.name.startswith("."):
names.add(fpath.name)
names.add(fpath.name.lower())
if root_path.is_dir():
for fpath in root_path.rglob("*"):
if fpath.is_file() and not fpath.name.startswith("."):
names.add(fpath.name)
names.add(fpath.name.lower())
bios_path = Path(bios_root)
if bios_path.is_dir():
import zipfile
for zpath in bios_path.rglob("*.zip"):
try:
with zipfile.ZipFile(zpath) as zf:
for member in zf.namelist():
if not member.endswith("/"):
basename = member.rsplit("/", 1)[-1] if "/" in member else member
names.add(basename)
names.add(basename.lower())
except (zipfile.BadZipFile, OSError):
pass
return names
@@ -226,7 +239,7 @@ def main():
declared, plat_data_dirs = load_platform_files(args.platforms_dir)
db = load_database(args.db)
data_names = _build_data_dir_index()
data_names = _build_supplemental_index()
report = cross_reference(profiles, declared, db, plat_data_dirs, data_names)
if args.json: