From 7dcb427e2751d0276cca676abec194ccabe4b9dd Mon Sep 17 00:00:00 2001 From: Abdessamad Derraz <3028866+Abdess@users.noreply.github.com> Date: Fri, 6 Nov 2026 15:13:55 +0100 Subject: [PATCH] fix: hint at --verbose when no bundled name shows With no required firmware among the bundled entries the line read '20 (20 more, --verbose lists them)'. It now reads '20 (--verbose lists them)', and reading-reports.md quotes the run as it prints. --- scripts/verify.py | 3 ++- tests/test_verify_listing.py | 7 +++++++ wiki/reading-reports.md | 2 +- 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/scripts/verify.py b/scripts/verify.py index ef62d1116..dcd9eb37a 100644 --- a/scripts/verify.py +++ b/scripts/verify.py @@ -1904,7 +1904,8 @@ def _print_undeclared_section(result: dict, verbose: bool) -> None: # The required firmware alone read as the whole count: 14 names # for 154 entries, nothing saying the rest existed. hidden = len({u["name"] for u in bundled}) - len(named) - items = named + ([f"{hidden} more, --verbose lists them"] if hidden else []) + more = f"{hidden} more, " if named else "" + items = named + ([f"{more}--verbose lists them"] if hidden else []) print( f" Bundled with their emulator, not collected: {len(bundled)}" + (f" ({', '.join(items)})" if items else "") diff --git a/tests/test_verify_listing.py b/tests/test_verify_listing.py index 267b5885c..5d6a208f9 100644 --- a/tests/test_verify_listing.py +++ b/tests/test_verify_listing.py @@ -2,6 +2,8 @@ from __future__ import annotations +import tests # noqa: F401 offline, scratch under tmp/, the suite's own cache + import subprocess import sys import unittest @@ -270,6 +272,11 @@ class TheBundledLineSaysWhatItLeavesOut(unittest.TestCase): "Bundled with their emulator, not collected: 3 (a.frag, b.dll, fw.bin)", verbose.getvalue(), ) + result["undeclared_files"] = result["undeclared_files"][1:] + with contextlib.redirect_stdout(io.StringIO()) as unnamed: + verify._print_undeclared_section(result, verbose=False) + self.assertIn("Bundled with their emulator, not collected: 2 (--verbose lists them)", + unnamed.getvalue()) class TheCheckLineSaysWhatItIs(unittest.TestCase): diff --git a/wiki/reading-reports.md b/wiki/reading-reports.md index a3bfd6765..844d03a78 100644 --- a/wiki/reading-reports.md +++ b/wiki/reading-reports.md @@ -110,7 +110,7 @@ RetroDECK: 2007/2008 OK, 1 untested [md5] Core files: 1764 in pack, 1 required missing, 26 optional missing (--verbose lists them) Core files held but not packed: 154 (142 installed with its emulator, 8 read below a save folder per system and no system runs the core there, 4 a packed file occupies its directory) MISSING (required): FinalBurn Neo needs sfiii2a.zip (1 file) - Bundled with their emulator, not collected: 20 + Bundled with their emulator, not collected: 20 (--verbose lists them) Game data: 5099 in pack, 30 missing (--verbose lists them) Game data held but not packed: 30 (installed with its emulator) No external files: 78 cores (--verbose lists them)