From 84ab0ea6d355de46762926e20a44455a36dddb72 Mon Sep 17 00:00:00 2001 From: Abdessamad Derraz <3028866+Abdess@users.noreply.github.com> Date: Wed, 18 Mar 2026 06:01:21 +0100 Subject: [PATCH] fix: revert verify dedup (breaks counts), optimize pack generation verify.py: removed destination dedup - verify counts ALL platform entries (398 for RetroArch). Pack deduplicates at generation (395). The delta (3 files: c52/g7400/jopac.bin) is correct behavior. generate_pack.py: skip build_zip_contents_index() when no zipped_file entries exist. RetroArch pack: 20s -> 11s (no ZIP scan needed). --- scripts/generate_pack.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/scripts/generate_pack.py b/scripts/generate_pack.py index 71567c8b..bc056574 100644 --- a/scripts/generate_pack.py +++ b/scripts/generate_pack.py @@ -321,7 +321,13 @@ def generate_pack( config = load_platform_config(platform_name, platforms_dir) db = load_database(db_path) - zip_contents = build_zip_contents_index(db) + # Only build the expensive ZIP contents index if the platform has zipped_file entries + has_zipped = any( + fe.get("zipped_file") + for sys in config.get("systems", {}).values() + for fe in sys.get("files", []) + ) + zip_contents = build_zip_contents_index(db) if has_zipped else {} verification_mode = config.get("verification_mode", "existence") platform_display = config.get("platform", platform_name)