From 87683d9bd7eb66c6e3312fd88cc5f60410a5d4c4 Mon Sep 17 00:00:00 2001 From: Abdessamad Derraz <3028866+Abdess@users.noreply.github.com> Date: Wed, 11 Nov 2026 12:17:04 +0100 Subject: [PATCH] refactor: keep build refs out of conditions A line cited in a config_reads condition is read as prose at the profile's pin, not at the build the entry describes. The lines move into the key's source_ref, which is read at that build. --- emulators/hatari2014.yml | 4 ++-- emulators/hatarib.yml | 4 ++-- emulators/retroarch.yml | 4 ++-- emulators/yabasanshiro.yml | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/emulators/hatari2014.yml b/emulators/hatari2014.yml index ff7f84be6..7970e7a32 100644 --- a/emulators/hatari2014.yml +++ b/emulators/hatari2014.yml @@ -30,8 +30,8 @@ config_reads: source_ref: "source libretro/libretro.c:264-300, 372, 393-413, 437-440, 984-1001, 1418, source libretro/libretro_core_options.h:129-145" keys: - key: "hatari_tosimage" - source_ref: "source libretro/libretro.c:617, 639-649, 1612-1617, source src/main.c:913-917, source src/tos.c:575-590" - condition: "a value other than default is a file of system/hatari/tos ending in img (libretro/libretro.c:288-299)" + source_ref: "source libretro/libretro.c:288-299, 617, 639-649, 1612-1617, source src/main.c:913-917, source src/tos.c:575-590" + condition: "a value other than default is a file of system/hatari/tos ending in img" notes: | Hatari 2014 is the libretro port of Hatari 1.8.0 (src/includes/version.h:16), diff --git a/emulators/hatarib.yml b/emulators/hatarib.yml index 97b3fa8b9..f2bf7913f 100644 --- a/emulators/hatarib.yml +++ b/emulators/hatarib.yml @@ -28,8 +28,8 @@ config_reads: source_ref: "core/core.c:963-976, core/core_config.c:961-969, 985, 1286-1318, 1408-1413, hatari/src/main.c:898, 921-925, 1019" keys: - key: "hatarib_tos" - source_ref: "core/core_config.c:1082-1104, core/core_file.c:256-259, 763-769, hatari/src/tos.c:996-1056" - condition: " is offered only when system/tos.img exists, a hatarib/ value only for a file with an img, rom, bin or tos extension (core/core_config.c:1293-1318, core/core_file.c:707-716)" + source_ref: "core/core_config.c:1082-1104, 1293-1318, core/core_file.c:256-259, 707-716, 763-769, hatari/src/tos.c:996-1056" + condition: " is offered only when system/tos.img exists, a hatarib/ value only for a file with an img, rom, bin or tos extension" notes: | hatariB carries Hatari 2.6.1 in its hatari/ directory, every change diff --git a/emulators/retroarch.yml b/emulators/retroarch.yml index 6a04ef897..e5feda3ef 100644 --- a/emulators/retroarch.yml +++ b/emulators/retroarch.yml @@ -34,8 +34,8 @@ config_reads: source_ref: "retroarch.c:6968-6969, 7148-7155, 7244, configuration.c:3469, 3779, 3824, 3863-3884, 5014-5018, libretro-common/file/config_file.c:840" keys: - key: "system_directory" - source_ref: "configuration.c:1645, 4063-4069, 4110-4115, 4346-4347, libretro-common/file/config_file.c:1180-1189, libretro-common/file/file_path.c:1060-1098, runloop.c:1935-1976" - condition: "systemfiles_in_content_dir false (its default, config.def.h:925); LIBRETRO_SYSTEM_DIRECTORY in the environment replaces the value, an empty value hands the content's folder" + source_ref: "configuration.c:1645, 4063-4069, 4110-4115, 4346-4347, libretro-common/file/config_file.c:1180-1189, libretro-common/file/file_path.c:1060-1098, runloop.c:1935-1976, config.def.h:925" + condition: "systemfiles_in_content_dir false, its default; LIBRETRO_SYSTEM_DIRECTORY in the environment replaces the value, an empty value hands the content's folder" - file: "retroarch.cfg" platforms: [rocknix] source_ref: "retroarch.c:7272-7273, 7452-7459, 7548, configuration.c:3565, 3886, 3931, 3970-4010, 5174-5176, libretro-common/file/config_file.c:817" diff --git a/emulators/yabasanshiro.yml b/emulators/yabasanshiro.yml index 513e95600..cfe8bc346 100644 --- a/emulators/yabasanshiro.yml +++ b/emulators/yabasanshiro.yml @@ -49,8 +49,8 @@ config_reads: - key: "[0.9.11] General\\EnableEmulatedBios" source_ref: "yabasanshiro.exe 0x1400d248f-0x1400d2512" - key: "[0.9.11] General\\Bios" - source_ref: "yabasanshiro.exe 0x1400d251b-0x1400d258c, yabasanshiro.exe 0x1400cf162-0x1400cf166, yabasanshiro.exe 0x14016d957-0x14016d98f, yabasanshiro.exe 0x14016f3ad-0x14016f4b4" - condition: "General\\EnableEmulatedBios false; an empty value runs the HLE BIOS (0x14016d997-0x14016d9f7), a file that does not open stops init" + source_ref: "yabasanshiro.exe 0x1400d251b-0x1400d258c, yabasanshiro.exe 0x1400cf162-0x1400cf166, yabasanshiro.exe 0x14016d957-0x14016d98f, yabasanshiro.exe 0x14016f3ad-0x14016f4b4, yabasanshiro.exe 0x14016d997-0x14016d9f7" + condition: "General\\EnableEmulatedBios false; an empty value runs the HLE BIOS, a file that does not open stops init" notes: | YabaSanshiro is a Sega Saturn emulator by devmiyax, forked from Yabause.