kmoody/libretro
1
0
Fork 0
mirror of https://github.com/Abdess/retroarch_system.git synced 2026-04-20 15:52:35 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove incorrect size validation from desmume firmware.bin

Browse Source
This commit is contained in:
Abdessamad Derraz
2026-03-23 11:47:35 +01:00
parent 78fa5c3d0f
commit 88381b3b2c
1 changed files with 13 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
emulators/desmume.yml
+13 -15
View File
@@ -1,23 +1,19 @@
emulator: DeSmuME emulator: DeSmuME
type: libretro type: libretro
core_classification: community_fork
source: "https://github.com/libretro/desmume" source: "https://github.com/libretro/desmume"
profiled_date: "2026-03-18" upstream: "https://github.com/TASEmulators/desmume"
profiled_date: "2026-03-23"
core_version: "SVN" core_version: "SVN"
display_name: "Nintendo - DS (DeSmuME)" display_name: "Nintendo - DS (DeSmuME)"
cores: [desmume] cores: [desmume]
systems: [nintendo-ds] systems: [nintendo-ds]
notes: | notes: |
DeSmuME provides full HLE (High-Level Emulation) of all ARM7/ARM9 SWI Full HLE of ARM7/ARM9 SWI routines; BIOS files optional for most games.
routines, making BIOS files optional for most games. When external BIOS External BIOS enables SWI-from-BIOS mode. Firmware boot requires both
is disabled, a minimal fake BIOS with exception vectors and IRQ handler BIOS files loaded and interpreter mode (JIT incompatible).
stubs is generated at runtime (NDSSystem.cpp:2208-2224, 2263-2278). No DSi support. Core option: desmume_use_external_bios.
External BIOS enables SWI-from-BIOS mode and firmware boot animation.
Firmware boot requires both ARM7+ARM9 BIOS loaded AND interpreter mode
(JIT incompatible, see libretro.cpp:788).
ARM9 BIOS read size: 4096 bytes (0x1000). ARM7 BIOS read size: 16384
bytes (0x4000). No DSi support.
Libretro core option: desmume_use_external_bios (enabled/disabled).
files: files:
- name: "bios7.bin" - name: "bios7.bin"
@@ -26,8 +22,9 @@ files:
required: false required: false
hle_fallback: true hle_fallback: true
size: 16384 size: 16384
validation: [size]
source_ref: "desmume/src/NDSSystem.cpp:2178-2182, frontend/libretro/libretro.cpp:763" source_ref: "desmume/src/NDSSystem.cpp:2178-2182, frontend/libretro/libretro.cpp:763"
notes: "HLE fallback covers all SWI calls; native file needed for firmware boot and SWI-from-BIOS accuracy" notes: "Native file needed for firmware boot and SWI-from-BIOS accuracy"
- name: "bios9.bin" - name: "bios9.bin"
system: nintendo-ds system: nintendo-ds
@@ -35,13 +32,14 @@ files:
required: false required: false
hle_fallback: true hle_fallback: true
size: 4096 size: 4096
validation: [size]
source_ref: "desmume/src/NDSSystem.cpp:2236-2239, frontend/libretro/libretro.cpp:764" source_ref: "desmume/src/NDSSystem.cpp:2236-2239, frontend/libretro/libretro.cpp:764"
notes: "HLE fallback covers all SWI calls; native file needed for firmware boot and logo comparison (Pal Park)" notes: "Native file needed for firmware boot and logo comparison (Pal Park)"
- name: "firmware.bin" - name: "firmware.bin"
system: nintendo-ds system: nintendo-ds
description: "NDS firmware image" description: "NDS firmware image"
required: false required: false
hle_fallback: true hle_fallback: true
source_ref: "desmume/src/NDSSystem.cpp:2653-2655, frontend/libretro/libretro.cpp:765" source_ref: "desmume/src/firmware.cpp:249-280, frontend/libretro/libretro.cpp:765"
notes: "Dummy firmware generated when absent; native firmware needed for boot animation, wifi config, user settings" notes: "Loaded only if both BIOS files present; needed for boot animation, wifi config, user settings"