diff --git a/emulators/m64plus-fz.yml b/emulators/m64plus-fz.yml index a58a793fb..4f30c3228 100644 --- a/emulators/m64plus-fz.yml +++ b/emulators/m64plus-fz.yml @@ -148,7 +148,7 @@ files: source_ref: "app/src/main/java/paulscode/android/mupen64plusae/jni/CoreService.java:599-612,621-623, app/src/main/java/paulscode/android/mupen64plusae/jni/CoreInterface.java:455-484, app/src/main/java/paulscode/android/mupen64plusae/persistent/GlobalPrefs.java:417,715, mupen64plus-core/upstream/src/main/main.c:1080-1145" - name: "64DD_IPL_US.n64" - aliases: ["64DD_IPL_USA.bin", "IPL_USA.n64"] + aliases: ["64DD_IPL_USA.bin"] system: nintendo-64dd required: true validation: [signature] @@ -163,7 +163,7 @@ files: source_ref: "app/src/main/java/paulscode/android/mupen64plusae/util/RomHeader.java:180-212, app/src/main/java/paulscode/android/mupen64plusae/jni/CoreInterface.java:221,455-484, mupen64plus-core/upstream/src/main/main.c:1080-1145" - name: "64DD_IPL_DEV.n64" - aliases: ["64DD_IPL_DEV.bin", "IPL_DEV.n64"] + aliases: ["64DD_IPL_DEV.bin"] system: nintendo-64dd required: true validation: [signature] diff --git a/emulators/mupen64plus-ae.yml b/emulators/mupen64plus-ae.yml index 132c3405c..353763c22 100644 --- a/emulators/mupen64plus-ae.yml +++ b/emulators/mupen64plus-ae.yml @@ -148,7 +148,7 @@ files: source_ref: "app/src/main/java/paulscode/android/mupen64plusae/jni/CoreService.java:606-620,638-639, app/src/main/java/paulscode/android/mupen64plusae/jni/CoreInterface.java:459-488, app/src/main/java/paulscode/android/mupen64plusae/persistent/GlobalPrefs.java:421,727, mupen64plus-core/upstream/src/main/main.c:1080-1145" - name: "64DD_IPL_US.n64" - aliases: ["64DD_IPL_USA.bin", "IPL_USA.n64"] + aliases: ["64DD_IPL_USA.bin"] system: nintendo-64dd required: true validation: [signature] @@ -163,7 +163,7 @@ files: source_ref: "app/src/main/java/paulscode/android/mupen64plusae/util/RomHeader.java:180-220, app/src/main/java/paulscode/android/mupen64plusae/jni/CoreInterface.java:223,459-488, mupen64plus-core/upstream/src/main/main.c:1080-1145" - name: "64DD_IPL_DEV.n64" - aliases: ["64DD_IPL_DEV.bin", "IPL_DEV.n64"] + aliases: ["64DD_IPL_DEV.bin"] system: nintendo-64dd required: true validation: [signature] diff --git a/emulators/mupen64plus.yml b/emulators/mupen64plus.yml index 280ae6ec6..acd898a8b 100644 --- a/emulators/mupen64plus.yml +++ b/emulators/mupen64plus.yml @@ -89,7 +89,7 @@ files: source_ref: "src/main.c:321, src/main.c:729-732, src/main.c:874-877, upstream src/main/main.c:1183-1248" - name: "64DD_IPL_US.n64" - aliases: ["64DD_IPL_USA.bin", "IPL_USA.n64"] + aliases: ["64DD_IPL_USA.bin"] system: nintendo-64dd required: true unread_on: [amberelec] @@ -98,7 +98,7 @@ files: source_ref: "src/main.c:874-892, upstream src/main/main.c:1183-1248" - name: "64DD_IPL_DEV.n64" - aliases: ["64DD_IPL_DEV.bin", "IPL_DEV.n64"] + aliases: ["64DD_IPL_DEV.bin"] system: nintendo-64dd required: true unread_on: [amberelec] diff --git a/tests/test_launcher_aliases.py b/tests/test_launcher_aliases.py index bd4d5331d..fb0ba7b92 100644 --- a/tests/test_launcher_aliases.py +++ b/tests/test_launcher_aliases.py @@ -119,6 +119,18 @@ class ProfileAliasesAreCodeNames(unittest.TestCase): "code, stated in the entry's note with its source_ref, or removed", ) + def test_rosalies_mupen_gui_names_stay_out_of_mupen64plus(self) -> None: + """RetroBat's mupen64 generator configures Rosalie's Mupen GUI and + writes IPL_USA.n64 and IPL_DEV.n64 into its config + (Mupen64.Generator.cs:232-238). Mupen64Plus fixes no IPL name.""" + profiles = _profiles() + for key in ("mupen64plus", "mupen64plus-ae", "m64plus-fz"): + aliases = { + str(a) for entry in profiles[key].get("files") or [] + for a in entry.get("aliases") or [] + } + self.assertFalse(aliases & {"IPL_USA.n64", "IPL_DEV.n64"}, key) + def test_check_catches_a_launcher_name(self) -> None: self.assertFalse(_named_without_platform( "cerbios.bin", "Batocera writes bios/cerbios.bin into flashrom_path.",