mirror of
https://github.com/Abdess/retroarch_system.git
synced 2026-10-20 18:59:07 -05:00
feat: the pipeline runs the schema check first
PR validation runs validate_schemas.py --source-only and the pipeline did not, so a profile with an unquoted numeric core name passed every step and failed CI on push. It is step 0 now, skipped where jsonschema is not installed.
This commit is contained in:
1 parent
8a44161810
commit
8bd2d319b2
4 files changed
+33
No files matched your search
@@ -5572,5 +5572,20 @@ class AHashConflictIsReportedOnce(unittest.TestCase):
|
||||
self.assertEqual(err.getvalue().count("WARNING"), 1)
|
||||
|
||||
|
||||
class ThePipelineRunsTheSchemaCheckCIRuns(unittest.TestCase):
|
||||
"""The pipeline the repository asks for after every change never ran
|
||||
validate_schemas.py, which PR validation does: a profile with an
|
||||
unquoted numeric core name passed it and failed CI on push."""
|
||||
|
||||
def test_the_ci_command_is_a_pipeline_step(self):
|
||||
workflow = (ROOT / ".github" / "workflows" / "validate.yml").read_text(encoding="utf-8")
|
||||
command = re.search(r"python (scripts/validate_schemas\.py[^\n]*)", workflow).group(1)
|
||||
script, *flags = command.split()
|
||||
source = (ROOT / "scripts" / "pipeline.py").read_text(encoding="utf-8")
|
||||
self.assertIn(f'"{script}"', source)
|
||||
for flag in flags:
|
||||
self.assertIn(f'"{flag}"', source)
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
unittest.main()
|
||||
Reference in new issue
Block a user