From 8da4757538bfd84171475db1995f9a3026b630b8 Mon Sep 17 00:00:00 2001 From: Abdessamad Derraz <3028866+Abdess@users.noreply.github.com> Date: Tue, 20 Oct 2026 02:24:45 +0200 Subject: [PATCH] fix: an unclaimed pcem ROM fails the owner test The test skipped when slots stopped claiming pcem's ide_xt.bin. The profile declares it and the collection holds three copies, so that skip could only hide a claiming defect. It now skips only when the file is not collected and fails when it is not claimed. --- tests/test_owner_resolution.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/test_owner_resolution.py b/tests/test_owner_resolution.py index 621a6500..b9ffcb8b 100644 --- a/tests/test_owner_resolution.py +++ b/tests/test_owner_resolution.py @@ -55,9 +55,12 @@ class ReadersNameTheOwner(unittest.TestCase): held = { claim.destination.rsplit("/", 1)[-1]: claim.local_path for claim in claims } + # pcem declares ide_xt.bin and the collection holds it: an unclaimed + # file here is a claiming defect, not missing data. + if not any(e.get("path", "").endswith("/ide_xt.bin") for e in self.db["files"].values()): + self.skipTest("ide_xt.bin is not collected") local = held.get("ide_xt.bin") - if local is None: - self.skipTest("ide_xt.bin is not claimed") + self.assertIsNotNone(local, "pcem's ide_xt.bin is not claimed") self.assertTrue(local.startswith("bios/Other/pcem/"), local)