mirror of
https://github.com/Abdess/retroarch_system.git
synced 2026-11-15 22:43:48 -06:00
fix: refuse a target --verify-packs cannot honour
An unknown target, or one the platform does not publish, was dropped and the full pack verified under it with rc 0 (finding 34).
This commit is contained in:
1 parent
609710e2d7
commit
8ef4eb47fc
3 files changed
+41
-11
No files matched your search
@@ -4,7 +4,8 @@
|
||||
under the target's name (Recalbox, Lakka, BizHawk, MiSTer, ROCKNIX). The
|
||||
conformance check read the same target without the --all tolerance, raised
|
||||
FileNotFoundError on the first of those packs and stopped the run in a
|
||||
traceback after every pack had been written.
|
||||
traceback after every pack had been written. Such a platform is now left
|
||||
out of a targeted --all run, and the check refuses it as the build does.
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
@@ -31,7 +32,10 @@ class CheckReadsTheTargetLikeTheBuild(unittest.TestCase):
|
||||
contextlib.redirect_stdout(io.StringIO()):
|
||||
with self.assertRaises(ValueError):
|
||||
build_target_cores_cache(["recalbox"], "x86_64", platforms, is_all=True)
|
||||
self.assertIsNone(_target_cores_for("recalbox", "x86_64", platforms))
|
||||
# The build never packs such a platform under the target, so the
|
||||
# check refuses it too instead of reading the full pack.
|
||||
with self.assertRaises(FileNotFoundError):
|
||||
_target_cores_for("recalbox", "x86_64", platforms)
|
||||
|
||||
def test_a_platform_with_a_target_file_is_narrowed(self):
|
||||
cores = _target_cores_for("retroarch", "switch", str(REPO_ROOT / "platforms"))
|
||||
|
||||
Reference in new issue
Block a user