fix: publish target lists as the builder resolves them

tests/test_check_freshness.py

@@ -166,6 +166,28 @@ class CoreResolutionTests(unittest.TestCase):
             {"ghost": ["android", "linux"]},
         )
 
+    def test_a_default_override_drops_a_name_on_every_target(self):
+        index = cf.profile_name_index(self.PROFILES)
+        targets = {
+            "targets": {
+                "x86_64": {"cores": ["A500", "ghost"]},
+                "rpi": {"cores": ["A500", "na"]},
+            }
+        }
+        overrides = {
+            "plat": {
+                "targets": {
+                    "_default": {"remove_cores": ["A500"]},
+                    "rpi": {"remove_cores": ["na"]},
+                }
+            }
+        }
+        removed = cf._removed_cores(overrides, "plat")
+        self.assertEqual(
+            cf.unresolved_target_cores(targets, index, removed),
+            {"ghost": ["x86_64"]},
+        )
+
     def test_coreinfo_gaps_fold_case_and_flag_standalone_profiles(self):
         names = ["FreeIntvTSOverlay", "eka2l1", "wqxemu", "mednafen_psx"]
         unprofiled, standalone = cf.coreinfo_gaps(names, self.PROFILES)

tests/test_e2e.py

@@ -1747,6 +1747,33 @@ class TestE2E(unittest.TestCase):
         self.assertIn("core_a", cores)
         self.assertIn("core_b", cores)
 
+    def test_target_default_override_reaches_every_target(self):
+        """`_default` drops a name on every target, then the target adds its own."""
+        self._write_target_fixtures()
+        from common import load_target_config
+
+        targets_dir = os.path.join(self.platforms_dir, "targets")
+        overrides = {
+            "testplatform": {
+                "targets": {
+                    "_default": {"remove_cores": ["core_a"], "add_cores": ["core_z"]},
+                    "target-full": {"aliases": ["full"], "add_cores": ["core_a"]},
+                },
+            },
+        }
+        with open(os.path.join(targets_dir, "_overrides.yml"), "w") as f:
+            yaml.dump(overrides, f)
+        self.assertEqual(
+            load_target_config("testplatform", "target-minimal", self.platforms_dir),
+            {"core_z"},
+        )
+        self.assertEqual(
+            load_target_config("testplatform", "full", self.platforms_dir),
+            {"core_a", "core_b", "core_c", "core_z"},
+        )
+        with self.assertRaises(ValueError):
+            load_target_config("testplatform", "_default", self.platforms_dir)
+
     def test_target_single_target_noop(self):
         self._write_target_fixtures()
         from common import load_target_config

tests/test_install.py

@@ -821,6 +821,33 @@ class TargetFlagIsAppliedOrRefused(unittest.TestCase):
                         f"{alias} disagrees with what the builder resolves",
                     )
 
+    def test_every_published_target_is_the_list_the_builder_resolves(self):
+        """add_cores and remove_cores reach the installer, not only the builder.
+
+        The published lists were the scraped ones, untouched by the
+        overrides: Batocera x86_64 lacked citron and xenia, which the pack
+        for that target ships, and carried the Amiga machine variants and
+        the launchers the builder drops.
+        """
+        import sys as _sys
+
+        _sys.path.insert(0, str(REPO_ROOT / "scripts"))
+        from common import load_target_config
+
+        manifests = sorted((REPO_ROOT / "install" / "targets").glob("*.json"))
+        if not manifests:
+            self.skipTest("no target manifest generated yet")
+        for path in manifests:
+            targets = json.loads(path.read_text())
+            for target, cores in targets.items():
+                if cores is None:
+                    continue
+                with self.subTest(platform=path.stem, target=target):
+                    resolved = load_target_config(
+                        path.stem, target, str(REPO_ROOT / "platforms")
+                    )
+                    self.assertEqual(cores, sorted(resolved))
+
 
 class TestBaseUrlScheme(unittest.TestCase):
     """The bootstraps insist on HTTPS; the installer must not be laxer."""