mirror of
https://github.com/Abdess/retroarch_system.git
synced 2026-10-18 09:23:26 -05:00
fix: tell an offline cache miss from absence
Offline, fetch_file answered None for a path the cache never stored, the same answer as a path known to be absent, and profile_sync reported existing files as gone. A miss now raises NotCachedError and the profile is reported unverified.
This commit is contained in:
1 parent
b91449590d
commit
9802804a9a
6 files changed
+59
-9
No files matched your search
@@ -1803,7 +1803,7 @@ def build_report(
|
||||
return None
|
||||
try:
|
||||
return upstream.fetch_file(repo, sha, wanted, cache_dir, offline)
|
||||
except upstream.RateLimitError:
|
||||
except (upstream.RateLimitError, upstream.NotCachedError):
|
||||
raise
|
||||
except upstream.UpstreamError as exc:
|
||||
mute.add(key)
|
||||
@@ -3677,6 +3677,13 @@ def main() -> None:
|
||||
)
|
||||
except upstream.RateLimitError:
|
||||
raise
|
||||
except upstream.NotCachedError as exc:
|
||||
# Offline with a cache that never stored this file: the profile
|
||||
# is unverified, not wrong. Reporting GONE sent readers after
|
||||
# files that exist.
|
||||
report = ProfileReport(
|
||||
name=name, entries=[], counts={}, skipped=f"offline: {exc}"
|
||||
)
|
||||
except upstream.GoneError as exc:
|
||||
# The forge is not coming back: a takedown, or a host that no
|
||||
# longer resolves. Saying so once in the summary beats repeating
|
||||
|
||||
Reference in new issue
Block a user