From c9634996436f11932641d416bc81fb47942f7ae0 Mon Sep 17 00:00:00 2001
From: Abdessamad Derraz <3028866+Abdess@users.noreply.github.com>
Date: Mon, 9 Nov 2026 14:23:36 +0100
Subject: [PATCH] fix: wait for Confirm by its title in the tap test

The game-data tap test waited on the bare RetroBIOS: title, which the
screen before Confirm already showed, then pressed Enter only if one
settle had drawn Confirm. The runner drew it later and the install
never started. It now waits for the Confirm title and presses Enter.
---
 tests/test_install_tui.py | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/tests/test_install_tui.py b/tests/test_install_tui.py
index 6ef4f2147..996b81917 100644
--- a/tests/test_install_tui.py
+++ b/tests/test_install_tui.py
@@ -12367,12 +12367,14 @@ class TapsOnAPtySeeFirst(unittest.TestCase):
                 break
             term.send("\x1b[A")
         term.send("\r")
-        screen = term.wait("RetroBIOS:")
-        if "Confirm" in term.settle():
-            term.send("\r")
+        # The changed choices are counted again on Confirm. Waiting on the
+        # bare title matched the screen before it, and a runner that drew
+        # Confirm after one settle never pressed Enter there.
+        term.wait("RetroBIOS: Confirm")
+        term.settle()
+        term.send("\r")
         term.wait("files installed")
         self.assertEqual(repo.installed(), ["gba_bios.bin", "mgba/extra.bin"])
-        del screen
         term.send("q")
         term.close()