chore: merge review tag cleanup

This commit is contained in:
Abdessamad Derraz committed 2026-11-05 12:52:29 +01:00
commit a6aea140f0
68 files changed
+8451 -9191

No files matched your search

+2 -3
View File
@@ -223,8 +223,7 @@ def line_menu() -> str:
"""The line menu of a RetroArch run, g then Enter pressed, as install.py
prints it for the RetroArch list (install/retroarch.json): the very
function line mode runs, its questions answered here. The page carried
a copy typed by hand, whose keys and counts drifted from the installer
(code_audit_22, owner's note on which-pack)."""
a copy typed by hand, whose keys and counts drifted from the installer."""
import io # noqa: PLC0415
from unittest import mock # noqa: PLC0415
@@ -290,7 +289,7 @@ class _ListHandler(http.server.SimpleHTTPRequestHandler):
class _LoopbackServer(http.server.ThreadingHTTPServer):
"""The list server, named by its number: HTTPServer.server_bind looks
127.0.0.1 up with socket.getfqdn, a DNS query wherever /etc/hosts does
not name it (code_audit_24 P3-12)."""
not name it."""
def server_bind(self) -> None:
socketserver.TCPServer.server_bind(self)
+5 -5
View File
@@ -3248,7 +3248,7 @@ def with_setup_table(page: str, coverages: dict, registry: dict | None = None) -
# A platform's file lists are split by the share of a page they render to,
# in thousandths: their elements against validate_site's MAX_PAGE_ELEMENTS,
# their bytes against the 600,000 of test_site_r2_gate, whichever is
# their bytes against the 600,000 of test_site_built_gate, whichever is
# larger. Measured in Markdown characters, the lists split anew whenever
# their markup changed: rows written as tables moved 38 more systems to
# pages of their own.
@@ -3943,9 +3943,9 @@ def first_screen_words() -> list[str]:
installer = _installer()
# The screen it opens first: the setup found, or the list when none
# is. Install comes on the next one, Choose systems beside it and named
# above on the page (tui_audit_16 P3-10).
# above on the page.
# Nothing found, the folder comes before Install: which-pack left it
# out (tui_audit_17 P3-9).
# out.
return [f"It asks **{installer.TUI_FOUND_TITLE}** (or **{installer.TUI_CHOOSE_TITLE}** "
f"and **{installer.TUI_FOLDER_TITLE}**), then offers **{installer.TUI_INSTALL_ROW}**."]
@@ -3954,7 +3954,7 @@ def check_pass_line() -> str:
"""The pass line of "How to check": the words `--check` prints only when
no file is missing or wrong (install.py EVERYTHING_IN_PLACE), read from
the installer. Typed here, it kept "All files up to date." after the
installer said "Everything is in place." (tui_audit_15 P3-10)."""
installer said "Everything is in place."."""
return f"All good when it says `{_installer().EVERYTHING_IN_PLACE}`"
# Under "From your computer": a device with no network installs from the ZIP
@@ -9970,7 +9970,7 @@ def _emulator_part_page(
for n, (stem, _e) in enumerate(parts, 1)], number - 1),
f"# {emu_name} files, part {number} of {len(parts)}",
"",
# The crumbs end on the emulator, read from parent: (round 5, 7.5).
# The crumbs end on the emulator, read from parent:.
f"This part holds {_count(len(files), 'entry', 'entries')}, "
f"{_code(first)} to {_code(last)}. The other parts: {others}.",
"",
+2 -2
View File
@@ -45,7 +45,7 @@ PIN: dict[str, re.Pattern[str]] = {
# What the served copy says of a refused installer. It names a commit's
# install.py, which never changes, and both downloaders fail on a short
# transfer before the hash is read: neither a cut download nor caches of
# two ages explain a mismatch there (code_audit_21 P3-1).
# two ages explain a mismatch there.
SERVED_ADVICE = ("The file was changed on its way here, most often by a proxy or an "
"antivirus that rewrites downloads. Run the command again from another "
"network, or with that web protection paused.")
@@ -73,7 +73,7 @@ def served_text(name: str, root: Path, commit: str) -> str:
advice fitted to that. A pin that is not the SHA-256 of root's
install.py stops the build: published, that copy refused every install
until the next good deploy, where a failed build keeps the last good
pair served (code_audit_21 P3-2)."""
pair served."""
source, line = SOURCES[name]
text = (root / source).read_text(encoding="utf-8")
pinned = PIN[name].findall(text)