kmoody/libretro
1
0
Fork 0
mirror of https://github.com/Abdess/retroarch_system.git synced 2026-04-13 12:22:33 -05:00
Code Issues Packages Projects Releases Wiki Activity

refactor: fix code review findings across all scripts

Browse Source 
Critical: stream large file downloads (OOM fix), fix basename match
in auto_fetch, include hashes in pack grouping fingerprint, handle
not_in_zip status in verify, fix escaped quotes in batocera parser.

Important: deduplicate shared group includes, catch coreinfo network
errors, fix NODEDUP path component match, fix CI word splitting on
spaces, replace bare except Exception in 3 files.

Minor: argparse in list_platforms, specific exceptions in download.py.
This commit is contained in:
Abdessamad Derraz
2026-03-17 15:16:51 +01:00
parent ff38eebde7
commit af74fffa14
11 changed files with 41 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
scripts/common.py
View File

@@ -93,7 +93,11 @@ def load_platform_config(platform_name: str, platforms_dir: str = "platforms") -
for system in config.get("systems", {}).values():
for group_name in system.get("includes", []):
if group_name in shared_groups:
system.setdefault("files", []).extend(shared_groups[group_name])
existing_names = {f.get("name") for f in system.get("files", [])}
for gf in shared_groups[group_name]:
if gf.get("name") not in existing_names:
system.setdefault("files", []).append(gf)
existing_names.add(gf.get("name"))
return config