kmoody/libretro
1
0
Fork 0
mirror of https://github.com/Abdess/retroarch_system.git synced 2026-04-13 12:22:33 -05:00
Code Issues Packages Projects Releases Wiki Activity

feat: add include_all param to find_undeclared_files

Browse Source
This commit is contained in:
Abdessamad Derraz
2026-04-01 14:29:31 +02:00
parent 0a272dc4e9
commit b070fa41de
2 changed files with 38 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
scripts/verify.py
View File

@@ -313,6 +313,7 @@ def find_undeclared_files(
emu_profiles: dict | None = None, emu_profiles: dict | None = None,
target_cores: set[str] | None = None, target_cores: set[str] | None = None,
data_names: set[str] | None = None, data_names: set[str] | None = None,
include_all: bool = False,
) -> list[dict]: ) -> list[dict]:
"""Find files needed by cores but not declared in platform config.""" """Find files needed by cores but not declared in platform config."""
# Collect all filenames declared by this platform, enriched with # Collect all filenames declared by this platform, enriched with
@@ -385,12 +386,13 @@ def find_undeclared_files(
archive = f.get("archive") archive = f.get("archive")
# Skip files declared by the platform (by name or archive) # Skip files declared by the platform (by name or archive)
if fname in declared_names: if not include_all:
seen_files.add(fname) if fname in declared_names:
continue seen_files.add(fname)
if archive and archive in declared_names: continue
seen_files.add(fname) if archive and archive in declared_names:
continue seen_files.add(fname)
continue
seen_files.add(fname) seen_files.add(fname)

30
tests/test_e2e.py
View File

@@ -4451,5 +4451,35 @@ struct BurnDriver BurnDrvneogeo = {
self.assertEqual(result["core_version"], "v1.0.0.03") self.assertEqual(result["core_version"], "v1.0.0.03")
def _load_config(self, platform_name: str) -> dict:
return load_platform_config(platform_name, self.platforms_dir)
def test_200_find_undeclared_include_all(self):
"""include_all=True returns ALL core files, including declared ones."""
from verify import find_undeclared_files
config = self._load_config("test_existence")
profiles = load_emulator_profiles(self.emulators_dir)
# Without include_all: only undeclared files returned
undeclared = find_undeclared_files(
config, self.emulators_dir, self.db, profiles
)
undeclared_names = {u["name"] for u in undeclared}
# present_req.bin is declared in platform YAML, should NOT be in undeclared
self.assertNotIn("present_req.bin", undeclared_names)
# With include_all: ALL core files returned, including declared ones
all_files = find_undeclared_files(
config, self.emulators_dir, self.db, profiles, include_all=True
)
all_names = {u["name"] for u in all_files}
# present_req.bin IS declared but should be returned with include_all
self.assertIn("present_req.bin", all_names)
# undeclared files should still be present
self.assertIn("undeclared_req.bin", all_names)
# Launcher/alias files should still be excluded
self.assertNotIn("launcher_bios.bin", all_names)
if __name__ == "__main__": if __name__ == "__main__":
unittest.main() unittest.main()