From b5f28d7b7f82a41b248c54c1ceed9bb289e5768b Mon Sep 17 00:00:00 2001 From: Abdessamad Derraz <3028866+Abdess@users.noreply.github.com> Date: Tue, 11 Aug 2026 20:27:53 +0200 Subject: [PATCH] chore: drop three reads whose result went nowhere The requirement parser read core, hashMatchMandatory and note from each bios element and discarded all three, which reads like a dropped attribute: hashMatchMandatory decides whether a wrong hash is yellow or red on Recalbox. It is not lost -- the config parser below captures it for the YAML -- so these were leftovers, and they cost a look to confirm that. Two yaml imports left unused by the move to the shared loader go too. --- scripts/scraper/_hash_merge.py | 1 - scripts/scraper/batocera_scraper.py | 1 - scripts/scraper/recalbox_scraper.py | 3 --- 3 files changed, 5 deletions(-) diff --git a/scripts/scraper/_hash_merge.py b/scripts/scraper/_hash_merge.py index 0db1353e..067a30e0 100644 --- a/scripts/scraper/_hash_merge.py +++ b/scripts/scraper/_hash_merge.py @@ -13,7 +13,6 @@ import shutil from pathlib import Path from typing import Any -import yaml from common import yaml_load diff --git a/scripts/scraper/batocera_scraper.py b/scripts/scraper/batocera_scraper.py index 81b2f31e..d9917619 100644 --- a/scripts/scraper/batocera_scraper.py +++ b/scripts/scraper/batocera_scraper.py @@ -16,7 +16,6 @@ import urllib.error import urllib.request from pathlib import Path -import yaml from common import yaml_load diff --git a/scripts/scraper/recalbox_scraper.py b/scripts/scraper/recalbox_scraper.py index 7992b50d..59fece86 100644 --- a/scripts/scraper/recalbox_scraper.py +++ b/scripts/scraper/recalbox_scraper.py @@ -140,10 +140,7 @@ class Scraper(BaseScraper): for bios_elem in system_elem.findall("bios"): paths_str = bios_elem.get("path", "") md5_str = bios_elem.get("md5", "") - bios_elem.get("core", "") mandatory = bios_elem.get("mandatory", "true") != "false" - bios_elem.get("hashMatchMandatory", "true") != "false" - bios_elem.get("note", "") paths = [p.strip() for p in paths_str.split("|") if p.strip()] if not paths: