fix: drop archive checks mame forks never run

This commit is contained in:
Abdessamad Derraz committed 2026-10-16 06:46:56 +02:00
1 parent 4b38e25505
commit b8049f757b
4 files changed
+22 -11

No files matched your search

-3
View File
@@ -67,7 +67,6 @@ files:
Merged console BIOS archive documented by the manual at bios/a7800.zip. Merged console BIOS archive documented by the manual at bios/a7800.zip.
Serves all eight machines through the parent chain, since the PAL Serves all eight machines through the parent chain, since the PAL
machines are clones of a7800 rather than of a7800p. machines are clones of a7800 rather than of a7800p.
validation: [size, crc32, sha1]
contents: contents:
- name: 7800.u7 - name: 7800.u7
description: NTSC BIOS, default system BIOS "a7800", mapped at 0x3000 description: NTSC BIOS, default system BIOS "a7800", mapped at 0x3000
@@ -94,7 +93,6 @@ files:
Software list set for the High Score Cartridge configuration (CX78HSC, Software list set for the High Score Cartridge configuration (CX78HSC,
slot a78_hsc). Fatal when that configuration is selected and the set is slot a78_hsc). Fatal when that configuration is selected and the set is
absent. absent.
validation: [size, crc32, sha1]
contents: contents:
- name: highscre.bin - name: highscre.bin
description: High Score Cartridge ROM, read through the pass-through cart description: High Score Cartridge ROM, read through the pass-through cart
@@ -112,7 +110,6 @@ files:
a78_xm), which reuses the High Score Cartridge ROM alongside 128KB RAM, a78_xm), which reuses the High Score Cartridge ROM alongside 128KB RAM,
POKEY and YM2151. Fatal when that configuration is selected and the set POKEY and YM2151. Fatal when that configuration is selected and the set
is absent. is absent.
validation: [size, crc32, sha1]
contents: contents:
- name: highscre.bin - name: highscre.bin
description: High Score Cartridge ROM, gated by XM control register bit 3 description: High Score Cartridge ROM, gated by XM control register bit 3
-1
View File
@@ -22,7 +22,6 @@ files:
required: true required: true
category: bios_zip category: bios_zip
source_ref: "src/osd/retro/retromain.c:1989, src/mame/drivers/cdi.c:421" source_ref: "src/osd/retro/retromain.c:1989, src/mame/drivers/cdi.c:421"
validation: [crc32, sha1]
contents: contents:
- name: cdi200.rom - name: cdi200.rom
description: Magnavox CD-i 200 BIOS (default) description: Magnavox CD-i 200 BIOS (default)
-4
View File
@@ -3709,7 +3709,6 @@ files:
system: vtech-vsmile system: vtech-vsmile
source_ref: "src/mame/vtech/vsmile.cpp:364-394" source_ref: "src/mame/vtech/vsmile.cpp:364-394"
note: "MACHINE_IMPERFECT_SOUND | MACHINE_IMPERFECT_GRAPHICS. Clone: vsmilem (V.Smile Motion)." note: "MACHINE_IMPERFECT_SOUND | MACHINE_IMPERFECT_GRAPHICS. Clone: vsmilem (V.Smile Motion)."
validation: [crc32]
contents: contents:
- name: "vsmile_v103.bin" - name: "vsmile_v103.bin"
description: "System ROM v1.03 (default, also used on V.Smile Pocket)" description: "System ROM v1.03 (default, also used on V.Smile Pocket)"
@@ -4340,7 +4339,6 @@ files:
note: >- note: >-
QSound DSP program ROM. Required by qsound_device and QSound DSP program ROM. Required by qsound_device and
qsound_hle_device for Capcom QSound audio (CPS-2, CPS-3, ZN). qsound_hle_device for Capcom QSound audio (CPS-2, CPS-3, ZN).
validation: [crc32]
contents: contents:
- name: "dl-1425.bin" - name: "dl-1425.bin"
description: "QSound DSP microcode" description: "QSound DSP microcode"
@@ -4354,7 +4352,6 @@ files:
note: >- note: >-
YM2413 (OPLL) instrument ROM table. Required by ym2413_device YM2413 (OPLL) instrument ROM table. Required by ym2413_device
for FM synthesis preset instruments. for FM synthesis preset instruments.
validation: [crc32]
contents: contents:
- name: "ym2413_instruments.bin" - name: "ym2413_instruments.bin"
description: "OPLL preset instrument table" description: "OPLL preset instrument table"
@@ -4369,7 +4366,6 @@ files:
YM2608 (OPNA) ADPCM rhythm sample ROM. Required by ym2608_device YM2608 (OPNA) ADPCM rhythm sample ROM. Required by ym2608_device
for internal rhythm sound source (bass drum, snare, cymbal, hi-hat, for internal rhythm sound source (bass drum, snare, cymbal, hi-hat,
tom, rim shot). tom, rim shot).
validation: [crc32]
contents: contents:
- name: "ym2608_adpcm_rom.bin" - name: "ym2608_adpcm_rom.bin"
description: "OPNA ADPCM rhythm samples" description: "OPNA ADPCM rhythm samples"
+22 -3
View File
@@ -197,12 +197,31 @@ class AdvanceMameArchives(_Probe):
archive values.""" archive values."""
def test_no_archive_level_check(self): def test_no_archive_level_check(self):
for entry in _profile("advancemame")["files"]: # a7800's MAME warns the same way (src/emu/romload.cpp:427-452 at 7a2afdc).
if entry.get("category") == "bios_zip": for emulator in ("advancemame", "a7800"):
with self.subTest(name=entry["name"]): for entry in _profile(emulator)["files"]:
if entry.get("category") != "bios_zip":
continue
with self.subTest(emulator=emulator, name=entry["name"]):
self.assertFalse(entry.get("validation")) self.assertFalse(entry.get("validation"))
self.assertTrue(entry.get("contents")) self.assertTrue(entry.get("contents"))
class MameMemberChecksOnlyWarn(unittest.TestCase):
"""libretro MAME and mame2015 warn on a member's wrong length or checksums
and run (src/emu/romload.cpp:602-625 at 9069f39, src/emu/romload.c:501-519
at 7adbf44); an archive-level check with no archive value ran nothing."""
def test_no_valueless_archive_check(self):
for emulator, names in (
("mame", ("vsmile.zip", "qsound.zip", "ym2413.zip", "ym2608.zip")),
("cdi2015", ("cdimono1.zip",)),
):
entries = {f["name"]: f for f in _profile(emulator)["files"]}
for name in names:
with self.subTest(emulator=emulator, name=name):
self.assertFalse(entries[name].get("validation"))
if __name__ == "__main__": if __name__ == "__main__":
unittest.main() unittest.main()