From ba84f5701fe395fd849c2890152f587220a1ac06 Mon Sep 17 00:00:00 2001
From: Abdessamad Derraz <3028866+Abdess@users.noreply.github.com>
Date: Mon, 10 Aug 2026 16:54:39 +0200
Subject: [PATCH] chore: cover region filter with split and target

---
 tests/test_e2e.py | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/tests/test_e2e.py b/tests/test_e2e.py
index 1b4943461..4051bed9a 100644
--- a/tests/test_e2e.py
+++ b/tests/test_e2e.py
@@ -5369,6 +5369,7 @@ struct BurnDriver BurnDrvneogeo = {
             "rgncore": {
                 "emulator": "RegionCore",
                 "type": "libretro",
+                "cores": ["rgncore"],
                 "systems": ["region-console"],
                 "files": [
                     {"name": "rgn_us.bin", "region": ["north-america"]},
@@ -5512,6 +5513,31 @@ struct BurnDriver BurnDrvneogeo = {
             self.assertNotIn("rgn_jp.bin", names)
             self.assertNotIn("rgn_eu.bin", names)
 
+    def test_region_composes_with_split_and_target(self):
+        from generate_pack import generate_split_packs
+
+        self._create_region_fixtures()
+        paths = generate_split_packs(
+            "regionplat",
+            self.platforms_dir,
+            self.db,
+            self.bios_dir,
+            self.root,
+            emu_profiles=self._region_profiles(),
+            target_cores={"rgncore"},
+            regions=["north-america"],
+        )
+        self.assertTrue(paths)
+        for p in paths:
+            self.assertIn("NorthAmerica", os.path.basename(p))
+            names = self._names_in(p)
+            self.assertNotIn("rgn_jp.bin", names)
+            self.assertNotIn("rgn_eu.bin", names)
+        self.assertTrue(
+            any("rgn_us.bin" in self._names_in(p) for p in paths),
+            "target filtering removed the whole system",
+        )
+
     def test_region_composes_with_manifest(self):
         from generate_pack import generate_manifest