From d0312428e4ebfa92950bdb54b046606b49c32b67 Mon Sep 17 00:00:00 2001 From: Abdessamad Derraz <3028866+Abdess@users.noreply.github.com> Date: Sun, 18 Oct 2026 05:24:10 +0200 Subject: [PATCH] fix: let the parity test pass a complete system The system pack parity test guarded against an empty parse by requiring files to stay missing, so it would fail once the MSX and Neo Geo gaps are collected. It now requires both reports to have run and the pack's own missing count to match the lines it parsed. --- tests/test_system_pack_parity.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tests/test_system_pack_parity.py b/tests/test_system_pack_parity.py index cc4401e6..84c319b7 100644 --- a/tests/test_system_pack_parity.py +++ b/tests/test_system_pack_parity.py @@ -57,7 +57,13 @@ class SystemPackMatchesVerify(unittest.TestCase): if d["status"] == "missing" and not d.get("unsourceable") }) verify_missing = sorted(name for _dest, name in verify_missing) - self.assertTrue(pack_missing or verify_missing) + # Both sides reported, so an empty list is a finding and not a + # parse that matched nothing. Requiring missing files instead + # would fail the day the collection fills them. + summary = re.search(r"(\d+) files packed, (\d+) missing", packed) + self.assertIsNotNone(summary, packed[-500:]) + self.assertGreater(report["total_files"], 0) + self.assertEqual(int(summary.group(2)), len(pack_missing)) self.assertEqual(pack_missing, verify_missing)