mirror of
https://github.com/Abdess/retroarch_system.git
synced 2026-10-23 20:29:06 -05:00
fix: keep a mister entry whole without a size
Downloader rejects an entry without an integer size (db_entity.py:187) and compares it after each fetch (fetch_file_worker.py:127). A new hash the truth gives no size for is withheld and named, not written beside the old size nor reported as a size removal.
This commit is contained in:
1 parent
2e29b3be03
commit
d48e81861c
2 files changed
+47
-2
No files matched your search
@@ -113,6 +113,7 @@ class Exporter(BaseExporter):
|
||||
database = json.loads(original, object_pairs_hook=OrderedDict)
|
||||
indexed = self._by_path(systems)
|
||||
self._written = set()
|
||||
self._unsized: list[str] = []
|
||||
|
||||
for path, entry in database.get("files", {}).items():
|
||||
fe = indexed.get(path)
|
||||
@@ -124,9 +125,17 @@ class Exporter(BaseExporter):
|
||||
# entry without one, a new size beside the old hash describes
|
||||
# no file, and the entry is left as MiSTer wrote it.
|
||||
continue
|
||||
size = fe.size()
|
||||
if md5 != entry.get("hash") and not size:
|
||||
# Downloader refuses an entry without an integer size
|
||||
# (db_entity.py:187) and compares it after each fetch
|
||||
# (fetch_file_worker.py:127). The old size beside the new
|
||||
# hash describes the dump the truth rejects, so the entry
|
||||
# stays as MiSTer wrote it.
|
||||
self._unsized.append(path)
|
||||
continue
|
||||
self._written.add(id(fe))
|
||||
entry["hash"] = md5
|
||||
size = fe.size()
|
||||
if size:
|
||||
entry["size"] = size
|
||||
|
||||
@@ -143,6 +152,14 @@ class Exporter(BaseExporter):
|
||||
produced[_ARCHIVE] = archive if unchanged else rebuild_archive(archive, _DB_NAME, text)
|
||||
return produced
|
||||
|
||||
def withheld(self) -> list[str]:
|
||||
"""Each hash correction left out for want of the new dump's size."""
|
||||
return [
|
||||
f"{path} keeps its hash: the truth states no size for the new "
|
||||
"dump, and the Downloader checks every entry by size"
|
||||
for path in getattr(self, "_unsized", [])
|
||||
]
|
||||
|
||||
def validate(
|
||||
self,
|
||||
systems: dict[str, NativeSystem],
|
||||
@@ -169,6 +186,9 @@ class Exporter(BaseExporter):
|
||||
for path, fe in indexed.items():
|
||||
declared = files.get(path)
|
||||
md5 = fe.hash("md5")
|
||||
if declared is not None and md5 and declared.get("hash") != md5:
|
||||
if (
|
||||
declared is not None and md5 and declared.get("hash") != md5
|
||||
and path not in getattr(self, "_unsized", [])
|
||||
):
|
||||
issues.append(f"hash not applied: {path}")
|
||||
return issues
|
||||
Reference in new issue
Block a user