From dd1625d1fbed8db96bb6d56e29bd5f18ffc4c159 Mon Sep 17 00:00:00 2001 From: Abdessamad Derraz <3028866+Abdess@users.noreply.github.com> Date: Wed, 11 Nov 2026 14:31:12 +0100 Subject: [PATCH] fix: read the omission line the installer writes not_installable_words writes "436 files, 264 of them required. Why: ...": the count is followed by a comma, never a space, so the pattern found no line and the test read the dry run as omitting nothing. The page and the installer agree, the pattern did not follow them. --- tests/test_doc_pages.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_doc_pages.py b/tests/test_doc_pages.py index f0b5270c8..cacea5f66 100644 --- a/tests/test_doc_pages.py +++ b/tests/test_doc_pages.py @@ -137,7 +137,7 @@ class InstallerOutputExample(unittest.TestCase): manifest = json.loads((ROOT / "install" / "retroarch.json").read_text(encoding="utf-8")) # The line as the installer writes it (not_installable_words), or # its earlier "(1 required, not found: 37)" form. - omitted = re.search(r"Not installable: \d+ files? (?:\(\d+ required, (.*)\)\.|(?:is|are) " + omitted = re.search(r"Not installable: \d+ files?(?: \(\d+ required, (.*)\)\.| (?:is|are) " r"not in the collection|.*Why: (.*)\.)", run) self.assertEqual(omitted is not None, bool(manifest.get("omitted_files"))) if omitted and (omitted.group(1) or omitted.group(2)):