mirror of
https://github.com/Abdess/retroarch_system.git
synced 2026-11-13 05:23:51 -06:00
fix: generate_truth refuses a target it lacks
--platform bizhawk --target switch printed skipped, then Done., and exited 0 with no model written. generate_truth now resolves targets through build_target_cores_cache, as verify and generate_pack do: a named platform without the target is refused with exit 1, --all leaves such platforms out and says so.
This commit is contained in:
1 parent
25b9c85208
commit
dfa1cc31d3
2 files changed
+31
-12
No files matched your search
@@ -60,6 +60,22 @@ class ATargetedModelIsItsOwnArtifact(unittest.TestCase):
|
||||
)
|
||||
|
||||
|
||||
def test_a_named_platform_without_the_target_is_refused(self):
|
||||
"""bizhawk --target switch printed "skipped", then Done., exit 0,
|
||||
and wrote no model: the diff after it failed instead."""
|
||||
repo = pathlib.Path(__file__).resolve().parent.parent
|
||||
with tempfile.TemporaryDirectory(dir=str(repo / "tmp")) as directory:
|
||||
proc = subprocess.run(
|
||||
[sys.executable, "scripts/generate_truth.py", "--platform", "bizhawk",
|
||||
"--target", "switch", "--output-dir", directory],
|
||||
capture_output=True, check=False, text=True, cwd=str(repo), timeout=400,
|
||||
)
|
||||
self.assertEqual(proc.returncode, 1, proc.stdout + proc.stderr)
|
||||
self.assertIn("bizhawk has no hardware targets", proc.stderr)
|
||||
self.assertNotIn("Done.", proc.stdout)
|
||||
self.assertEqual(list(pathlib.Path(directory).iterdir()), [])
|
||||
|
||||
|
||||
class ADiffThatComparedNothingFails(unittest.TestCase):
|
||||
"""diff_truth --all skipped every platform without a model and exited 0."""
|
||||
|
||||
|
||||
Reference in new issue
Block a user