mirror of
https://github.com/Abdess/retroarch_system.git
synced 2026-10-17 17:03:27 -05:00
fix: write a group's pack under the group's name
The RetroArch and Lakka pack was built under RetroArch's own name and renamed afterwards, which overwrote then carried away a --platform retroarch pack in the same directory, and failed on Windows where os.rename refuses an existing target.
This commit is contained in:
1 parent
29fb1a58e4
commit
e26516fc0e
2 files changed
+37
-22
No files matched your search
@@ -2207,6 +2207,18 @@ class APackNameFitsAFileName(unittest.TestCase):
|
||||
self.assertIn("pack_name=final_name", source)
|
||||
|
||||
|
||||
class AGroupPackIsWrittenUnderItsOwnName(unittest.TestCase):
|
||||
"""The RetroArch + Lakka pack was written as RetroArch_..._BIOS_Pack.zip
|
||||
and renamed: a `--platform retroarch` pack already in the directory was
|
||||
overwritten then carried away, and os.rename refuses an existing target
|
||||
on Windows."""
|
||||
|
||||
def test_no_pack_is_renamed_after_its_build(self):
|
||||
source = (ROOT / "scripts" / "generate_pack.py").read_text(encoding="utf-8")
|
||||
self.assertNotIn("os.rename(", source)
|
||||
self.assertIn("pack_name=group_name", source)
|
||||
|
||||
|
||||
class TheDatabaseCacheIsWrittenWhole(unittest.TestCase):
|
||||
"""A crash while serializing left a truncated db_cache.json behind, and
|
||||
the next run rehashed the whole collection from scratch."""
|
||||
|
||||
Reference in new issue
Block a user