fix: drop the --include-extras flag nothing read

tests/test_directory_entries.py

@@ -201,7 +201,7 @@ class PackCarriesADirectory(DirectoryFixture):
         out.mkdir()
         zip_path = builder.generate_pack(
             "demo", str(self.platforms), self._db(), str(self.bios), str(out),
-            include_extras=True, emulators_dir=str(self.emulators),
+            emulators_dir=str(self.emulators),
             emu_profiles=profiles, offline=True,
         )
         with zipfile.ZipFile(zip_path) as archive:

tests/test_e2e.py

@@ -6018,6 +6018,9 @@ struct BurnDriver BurnDrvneogeo = {
             (["--from-md5", "d8f1"], ["--include-archived"], "refuse"),
             (["--platform", "retroarch", "--verify-packs"], ["--include-archived"],
              "refuse"),
+            # Documented as adding core files, read by nothing.
+            (["--emulator", "handy"], ["--include-extras"], "refuse"),
+            (["--system", "atari-lynx"], ["--include-extras"], "refuse"),
         ]
         for mode, flag, expected in matrix:
             with self.subTest(mode=mode, flag=flag):

tests/test_pack_counts.py

@@ -123,7 +123,7 @@ class ManifestStatesWhatThePackHolds(PackCountFixture):
         out.mkdir()
         zip_path = builder.generate_pack(
             "demo", str(self.platforms), self.db, str(self.bios), str(out),
-            include_extras=True, emulators_dir=str(self.emulators),
+            emulators_dir=str(self.emulators),
             emu_profiles=self.profiles, data_registry=self.registry,
             offline=True,
         )
@@ -184,7 +184,7 @@ class ManifestFollowsTheBuilder(PackCountFixture):
         out.mkdir(exist_ok=True)
         zip_path = builder.generate_pack(
             "demo", str(self.platforms), self.db, str(self.bios), str(out),
-            include_extras=True, emulators_dir=str(self.emulators),
+            emulators_dir=str(self.emulators),
             emu_profiles=self.profiles, data_registry=self.registry,
             offline=True,
         )

tests/test_pack_failures.py

@@ -38,7 +38,7 @@ class FailedPlatformFailsTheRun(unittest.TestCase):
         return argparse.Namespace(
             all_variants=False, source="full", required_only=False,
             platforms_dir="platforms", target=None, split=False,
-            include_extras=False, emulators_dir="emulators", regions=[],
+            emulators_dir="emulators", regions=[],
             one_per_slot=False, offline=True, bios_dir="bios",
             output_dir=self.tmp.name, verify_packs=False,
         )

tests/test_verify_pack_choice.py

@@ -119,7 +119,7 @@ class GroupRenameKeepsSystemTag(unittest.TestCase):
             args = argparse.Namespace(
                 all_variants=False, source="full", required_only=False,
                 platforms_dir="platforms", target=None, split=False,
-                include_extras=False, emulators_dir="emulators", regions=[],
+                emulators_dir="emulators", regions=[],
                 one_per_slot=False, offline=True, bios_dir="bios",
                 output_dir=tmp,
             )