fix: free a path the builder refuses to fill

verify counted a declaration whose hash the frontend refuses as
occupying its path, while the builder leaves it out and a core file
takes the place; the report then called that core file missing from
the pack. It now reads the builder's verdict. The hidden-extras tests
move to RetroArch and RetroBat, which still fold case, and test the
same-bytes twin again instead of skipping.
This commit is contained in:
Abdessamad Derraz committed 2026-10-17 08:51:45 +02:00
1 parent 6e8f2df24f
commit e3c5d97b94
2 files changed
+33 -7

No files matched your search

+9 -1
View File
@@ -72,6 +72,7 @@ from nativemode import (
reads_file_contents,
)
from validation import (
baseline_verdict,
declaration_settles,
frontend_digest_matches,
existence_discrepancy,
@@ -1027,7 +1028,14 @@ def verify_platform(
validation_index,
)
details.append(result)
if local_path and result["status"] != Status.MISSING:
# Occupied only where the builder ships the declaration: a hash
# the frontend refuses is left out, and the destination stays free
# for a core's file the pack does carry.
if (
local_path
and result["status"] != Status.MISSING
and baseline_verdict(file_entry, local_path, resolve_status, mode)[1] is None
):
shipped.setdefault(
f"{base_dest}/{destination}" if base_dest else destination,
local_path,