fix: clear the raw error flag on each run

--verbose set it and no run cleared it, so a later run in the same process ended its clock message with the raw SSL text. Also: --target named again in its refusal, three names mypy read as another type, a semicolon and a tooling file named in test comments.
This commit is contained in:
Abdessamad Derraz committed 2026-11-10 08:43:20 +01:00
1 parent 8e15f94ed1
commit e8e2215a49
8 files changed
+45 -35

No files matched your search

+18
View File
@@ -7834,5 +7834,23 @@ class TheNextStepFitsWhereTheInstallerRuns(unittest.TestCase):
install.NEXT_ON_CARD)
class EachRunSaysErrorsFromItsOwnOptions(unittest.TestCase):
"""--verbose set the raw-cause flag and nothing cleared it: a later run
in the same process ended its clock message with the raw SSL text."""
def test_a_run_without_verbose_clears_it(self):
install._RAW_ERRORS.set()
self.addCleanup(install._RAW_ERRORS.clear)
with unittest.mock.patch.object(sys, "argv",
["install.py", "--list-platforms", "--offline"]), \
contextlib.redirect_stdout(io.StringIO()), \
contextlib.redirect_stderr(io.StringIO()):
try:
install.main()
except SystemExit:
pass
self.assertFalse(install._RAW_ERRORS.is_set())
if __name__ == "__main__":
unittest.main()
+2 -4
View File
@@ -55,10 +55,8 @@ JOURNEY_KEYS = {
# Words each journey's screens show by default, summed over the screens it
# stops on, and the most one screen of the default path may show (owner,
# 2026-11-09: a beginner lost the important line in text). A path is no
# word: its length is the machine's. The counts from before the Details
# screen took the plan's and the result's notes are in claudedocs/
# user_research/installer_ux/phase1_measure.md. A change that adds words
# raises a number here and says why.
# word: its length is the machine's. A change that adds words raises a
# number here and says why.
JOURNEY_WORDS = {
"first_install": 63,
"card_with_games": 106,
+1 -1
View File
@@ -14934,7 +14934,7 @@ class GamesEndToEnd(unittest.TestCase):
# The most words each screen may show by default, one count per size of
# SIZES (owner, 2026-11-09: a beginner lost the important line in text). A
# path is no word. The plan, Confirm and the result say what happens, where
# and what next; their counts, notes and commands wait on Details. A list
# and what next, and their counts, notes and commands wait on Details. A list
# shows more rows on a taller window. A change that adds words to a screen
# raises its numbers here and says why: the result names its failed files
# (review of 2026-11-10), what the user acts on.