From f6acd96c789fcf0f27422f362f6ad736e09b8c4b Mon Sep 17 00:00:00 2001 From: Abdessamad Derraz <3028866+Abdess@users.noreply.github.com> Date: Fri, 6 Nov 2026 04:15:08 +0100 Subject: [PATCH] fix: teknoparrot's COH-H image is found by content The entry documents the pcsx2x6 component, whose FindBiosImage (pcsx2/ps2/BiosTools.cpp:268-291 at 583f0e90) takes the first 4 to 8 MB romdir image whatever its name. pcsx2x6.yml already said so, and the RetroBat truth gave the file two identities. The guard no longer needs an agnostic flag to read an entry. --- emulators/teknoparrot.yml | 1 + tests/test_audit_regressions.py | 7 ++++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/emulators/teknoparrot.yml b/emulators/teknoparrot.yml index 2b2f4c0de..59a2a4a5f 100644 --- a/emulators/teknoparrot.yml +++ b/emulators/teknoparrot.yml @@ -158,6 +158,7 @@ files: # pcsx2x6 component, System 246/256 (RetroBat core pcsx2x6) - name: COH-H31100.rom0 + found_by: content path: "pcsx2x6/TeknoParrot/bios/COH-H31100.rom0" system: namco-system246 required: true diff --git a/tests/test_audit_regressions.py b/tests/test_audit_regressions.py index 39935fe74..00fa6424f 100644 --- a/tests/test_audit_regressions.py +++ b/tests/test_audit_regressions.py @@ -7089,11 +7089,12 @@ class Ps2BiosImagesAreFoundByContent(unittest.TestCase): named = [] for path in sorted((ROOT / "emulators").glob("*.yml")): profile = yaml.safe_load(path.read_text(encoding="utf-8")) or {} - agnostic = profile.get("bios_mode") == "agnostic" + # Whatever the profile's own flags: TeknoParrot documents its + # pcsx2x6 component, whose scan is the same (BiosTools.cpp:268-291 + # at 583f0e90), and carries no agnostic flag. for entry in profile.get("files") or []: if ( - (agnostic or entry.get("agnostic")) - and entry.get("min_size") in (2097152, 4194304) + entry.get("min_size") in (2097152, 4194304) and entry.get("max_size") == 8388608 and opens_by_name(entry, profile) ):