mirror of
https://github.com/Abdess/retroarch_system.git
synced 2026-11-01 07:33:45 -06:00
refactor: check job subjects with the repo hook
The runner carried its own copy of the refused vocabulary, which put those words in a tracked file. It now runs the commit-msg hook on each job's subject when the job list loads, and checks only the shape where no hook exists.
This commit is contained in:
1 parent
07c34781e7
commit
faa79c5920
2 files changed
+45
-8
No files matched your search
+20
-8
@@ -43,6 +43,7 @@ import shlex
|
||||
import shutil
|
||||
import subprocess
|
||||
import sys
|
||||
import tempfile
|
||||
import time
|
||||
from collections.abc import Callable, Iterator, Sequence
|
||||
from dataclasses import dataclass, field
|
||||
@@ -73,11 +74,6 @@ HOST_MISREAD_MARKERS = ("SystemError", "unknown opcode")
|
||||
VOLATILE_KEYS = frozenset({"generated_at", "generated", "imported_at"})
|
||||
|
||||
SUBJECT_TYPES = re.compile(r"^(feat|refactor|chore|docs|fix): [a-z0-9]")
|
||||
FORBIDDEN_WORDS = re.compile(
|
||||
r"\b(bug|regression|revert|dead code|broken|wrong|hack|workaround|"
|
||||
r"comprehensive|implement)",
|
||||
re.IGNORECASE,
|
||||
)
|
||||
CI_RED = frozenset({"failure", "timed_out", "startup_failure"})
|
||||
CI_GREEN = frozenset({"success", "skipped", "neutral"})
|
||||
|
||||
@@ -190,16 +186,32 @@ class Context:
|
||||
|
||||
|
||||
def check_subject(subject: str, body: str = "") -> list[str]:
|
||||
"""What the repository's commit-msg hook would refuse in this message."""
|
||||
"""What the repository's commit-msg hook would refuse in this message.
|
||||
|
||||
The hook holds the vocabulary rules, so they live in one place: a job
|
||||
list is checked against it when it loads, not two hours into the job.
|
||||
Without a hook (another clone) only the shape is checked.
|
||||
"""
|
||||
problems = []
|
||||
if len(subject) > 50:
|
||||
problems.append(f"subject is {len(subject)} characters, 50 at most")
|
||||
if not SUBJECT_TYPES.match(subject):
|
||||
problems.append("subject must read 'type: description'")
|
||||
if FORBIDDEN_WORDS.search(f"{subject}\n{body}"):
|
||||
problems.append("message uses a word the history does not carry")
|
||||
if re.search(r"^co-authored-by", body, re.IGNORECASE | re.MULTILINE):
|
||||
problems.append("no Co-Authored-By trailer")
|
||||
hook = subprocess.run(["git", "rev-parse", "--git-path", "hooks/commit-msg"],
|
||||
capture_output=True, text=True, cwd=REPO_ROOT, check=False).stdout.strip()
|
||||
hook_path = (REPO_ROOT / hook) if hook else None
|
||||
if hook_path and hook_path.is_file() and os.access(hook_path, os.X_OK):
|
||||
with tempfile.NamedTemporaryFile("w", suffix=".msg", delete=False) as message:
|
||||
message.write(f"{subject}\n\n{body}\n" if body else f"{subject}\n")
|
||||
try:
|
||||
refused = subprocess.run([str(hook_path), message.name], capture_output=True,
|
||||
text=True, check=False)
|
||||
finally:
|
||||
os.unlink(message.name)
|
||||
if refused.returncode:
|
||||
problems.append((refused.stderr or refused.stdout).strip() or "refused by commit-msg")
|
||||
return problems
|
||||
|
||||
|
||||
|
||||
Reference in new issue
Block a user