From fac47dc4c09b9cc1d5392ed9559b2bec671fd757 Mon Sep 17 00:00:00 2001
From: Abdessamad Derraz <3028866+Abdess@users.noreply.github.com>
Date: Wed, 21 Oct 2026 10:09:28 +0200
Subject: [PATCH] fix: say how to run the schema check step 0 skips

Without jsonschema the step printed only the missing module, and the run then read COMPLETE while PR validation runs the same check. The skip now names the install command and the PR check.
---
 scripts/pipeline.py         |  8 +++++++-
 tests/test_tool_messages.py | 21 +++++++++++++++++++++
 2 files changed, 28 insertions(+), 1 deletion(-)

diff --git a/scripts/pipeline.py b/scripts/pipeline.py
index 46f83506..ed56a98e 100644
--- a/scripts/pipeline.py
+++ b/scripts/pipeline.py
@@ -721,7 +721,13 @@ def main() -> None:
     # `cores: [81]` unquoted passed the whole pipeline and failed CI on push.
     # jsonschema is tooling only, so its absence skips the step.
     if importlib.util.find_spec("jsonschema") is None:
-        skip_notice("validate_schemas", "jsonschema not installed")
+        # The skip names the install and what still runs the check, or a
+        # contributor read SKIPPED, then COMPLETE, and met the failure on push.
+        skip_notice(
+            "validate_schemas",
+            "jsonschema not installed. PR validation runs this check: "
+            'pip install "jsonschema[format-nongpl]"',
+        )
         results["validate_schemas"] = SKIPPED
     else:
         ok, _ = run(
diff --git a/tests/test_tool_messages.py b/tests/test_tool_messages.py
index abda8a50..977772a3 100644
--- a/tests/test_tool_messages.py
+++ b/tests/test_tool_messages.py
@@ -181,6 +181,27 @@ class ThePipelineCountsItsRealSteps(unittest.TestCase):
         self.assertEqual(title, f"8b render site [{total}/{total}]")
         self.assertNotIn("/8", pipeline.step_title(pipeline.STEP_LABELS["verify"]))
 
+    def test_a_skipped_schema_check_says_how_to_run_it(self):
+        """Step 0 said only "jsonschema not installed", then the run read
+        COMPLETE and the schema failed in PR validation."""
+        argv = ["pipeline.py", "--offline", "--skip-packs", "--skip-docs"]
+        out = io.StringIO()
+        real_find_spec = pipeline.importlib.util.find_spec
+        with mock.patch.object(sys, "argv", argv), mock.patch.object(
+            pipeline, "run", return_value=(True, "")
+        ), mock.patch.object(
+            pipeline.importlib.util, "find_spec",
+            side_effect=lambda name, *a: None if name == "jsonschema"
+            else real_find_spec(name, *a),
+        ), contextlib.redirect_stdout(out), contextlib.suppress(SystemExit):
+            pipeline.main()
+        line = next(
+            row for row in out.getvalue().splitlines()
+            if "0 validate schemas" in row and "SKIPPED" in row
+        )
+        self.assertIn('pip install "jsonschema[format-nongpl]"', line)
+        self.assertIn("PR validation runs this check", line)
+
     def test_an_offline_buildbot_check_has_a_summary_row(self):
         argv = ["pipeline.py", "--offline", "--check-buildbot", "--skip-packs",
                 "--skip-docs"]