From fcfa29a870b0ed30a935fe9b31bb1d1b4015207e Mon Sep 17 00:00:00 2001
From: Abdessamad Derraz <3028866+Abdess@users.noreply.github.com>
Date: Fri, 6 Nov 2026 19:58:08 +0100
Subject: [PATCH] fix: type the torrentzip member sources

---
 scripts/archive_build.py |  3 ++-
 scripts/torrentzip.py    | 21 +++++++++++++++++----
 2 files changed, 19 insertions(+), 5 deletions(-)

diff --git a/scripts/archive_build.py b/scripts/archive_build.py
index 9602d0613..0b4fdbec2 100644
--- a/scripts/archive_build.py
+++ b/scripts/archive_build.py
@@ -45,6 +45,7 @@ from typing import BinaryIO
 
 sys.path.insert(0, str(Path(__file__).resolve().parent))
 
+from torrentzip import Source as Readable
 from torrentzip import write_torrentzip, zlib_ng_version  # noqa: E402
 
 REPO_ROOT = Path(__file__).resolve().parent.parent
@@ -141,7 +142,7 @@ class _Member(io.RawIOBase):
         super().close()
 
 
-def _opener(source: Path, member: str | None) -> Callable[[], BinaryIO]:
+def _opener(source: Path, member: str | None) -> Callable[[], Readable]:
     if member is None:
         return lambda: source.open("rb")
     return lambda: _Member(source, member)
diff --git a/scripts/torrentzip.py b/scripts/torrentzip.py
index bf5cf7e86..c66d1e319 100644
--- a/scripts/torrentzip.py
+++ b/scripts/torrentzip.py
@@ -23,6 +23,7 @@ CLI:
 from __future__ import annotations
 
 import argparse
+import functools
 import hashlib
 import io
 import struct
@@ -30,7 +31,19 @@ import zipfile
 import zlib
 from collections.abc import Callable, Iterable
 from pathlib import Path
-from typing import BinaryIO, NamedTuple
+from typing import Any, NamedTuple, Protocol
+
+
+class Source(Protocol):
+    """An open member: read in chunks, closed by its ``with`` block."""
+
+    def read(self, size: int = -1, /) -> bytes: ...
+    def __enter__(self) -> Source: ...
+    def __exit__(self, *exc: Any) -> Any: ...
+
+
+class Sink(Protocol):
+    def write(self, data: bytes, /) -> int: ...
 
 # TorrentZip constants: 1996-12-24 23:32:00, deflate level 9
 _DOS_DATE = ((1996 - 1980) << 9) | (12 << 5) | 24
@@ -70,7 +83,7 @@ def zlib_ng_version(module: object = zlib) -> str | None:
     return runtime if "zlib-ng" in runtime.lower() else None
 
 
-def _deflate(stream: BinaryIO) -> tuple[bytes, Written]:
+def _deflate(stream: Source) -> tuple[bytes, Written]:
     compressor = zlib.compressobj(9, zlib.DEFLATED, -15)
     blob = bytearray()
     crc, size, sha1 = 0, 0, hashlib.sha1()
@@ -84,7 +97,7 @@ def _deflate(stream: BinaryIO) -> tuple[bytes, Written]:
 
 
 def write_torrentzip(
-    sink: BinaryIO, members: Iterable[tuple[str, Callable[[], BinaryIO]]]
+    sink: Sink, members: Iterable[tuple[str, Callable[[], Source]]]
 ) -> list[Written]:
     """Write a TorrentZip archive to *sink*, one member in memory at a time.
 
@@ -154,7 +167,7 @@ def build_torrentzip(members: list[tuple[str, bytes]]) -> bytes:
     """
     sink = io.BytesIO()
     write_torrentzip(
-        sink, [(name, lambda data=data: io.BytesIO(data)) for name, data in members]
+        sink, [(name, functools.partial(io.BytesIO, data)) for name, data in members]
     )
     return sink.getvalue()