mirror of
https://github.com/Abdess/retroarch_system.git
synced 2026-11-14 14:03:47 -06:00
fix: drop region tags chosen by machine model
XRoar reads the Dragon 200-E and Alice ROMs for those machine configs (src/xroar.c:437-444, 552-558 at 1.12.1), and VICE the Japanese kernal and chargen for the C64 JAP and VIC-1001 models: a (Japan) file name selects the NTSC model (libretro-core.c:2018-2034). No code branches on a territory for these files, so region: is removed, as profiling.md rules for a model enum.
This commit is contained in:
1 parent
34ef0cda1d
commit
fd93381c3e
5 files changed
+27
-13
No files matched your search
@@ -1384,5 +1384,32 @@ class YmirLibretroRegions(unittest.TestCase):
|
||||
if e["name"] == "sega_101.bin"))
|
||||
|
||||
|
||||
class MachineModelRomsCarryNoTerritory(unittest.TestCase):
|
||||
"""XRoar reads d200e_1.rom for the dragon200e machine and alice.rom for
|
||||
the alice machine (src/xroar.c:437-444, 552-558), and VICE the Japanese
|
||||
kernal and chargen for the C64 JAP and VIC-1001 models, which a file name
|
||||
tagged (Japan) never selects (libretro-core.c:2018-2034 sets NTSC). The
|
||||
site told a Spanish Dragon 64 owner to start with d200e_1.rom."""
|
||||
|
||||
CASES = {
|
||||
"xroar": ("d200e_1.rom", "d200e_2.rom", "d200e_26.rom", "alice.rom"),
|
||||
"x64sdl": ("jpkernal", "jpchrgen"),
|
||||
"vice_xvic": ("kernal.901486-02.bin", "chargen-901460-02.bin"),
|
||||
}
|
||||
|
||||
def test_model_roms_are_unregioned(self):
|
||||
profiles = common.load_emulator_profiles(
|
||||
os.path.join(os.path.dirname(__file__), "..", "emulators")
|
||||
)
|
||||
for profile, names in self.CASES.items():
|
||||
for entry in profiles[profile]["files"]:
|
||||
if entry["name"] in names:
|
||||
with self.subTest(profile=profile, name=entry["name"]):
|
||||
self.assertNotIn("region", entry)
|
||||
self.assertFalse(
|
||||
[e["name"] for e in profiles["c64-emu"]["files"] if e.get("region")]
|
||||
)
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
unittest.main()
|
||||
Reference in new issue
Block a user