Comments, docstrings and test texts ended on tags that name private review notes no clone holds. The tags go, the facts stay. Test methods named after a finding number are named after what they hold. test_prose_style refuses a tag that comes back. install.py changes in comments only: its pin and the launcher index follow.
In a fork's clone origin/main is the fork: once pushed it is HEAD, and
profile_sync --changed --strict checked nothing and passed while the PR's
CI then failed. The default base is now the line validate_pr.py reads:
upstream/main or origin/main when that remote is the project, the
project's main fetched otherwise.
openMSX reaches a ROM in share/systemroms through its file pool by SHA1
alone. A filename is only looked up beside the machine's XML
(src/memory/Rom.cc:121-170, HardwareConfig.cc:279-280,
FileContext.cc:152-156 at a557de7b). The labels read as names the core
opens, and the export added 15 of them to KNULLI and 2 to Batocera.
DEV9 opens eeprom.dat and flash.dat by bare name (pcsx2/DEV9/DEV9.cpp:144
at f0523f8a, AetherSX2 DEV9/flash.cpp:89, PCSX2 1.6 dev9ghzdrk/flash.cpp:73),
so the process working directory answers, never the BIOS folder. Only
yaps2 said so: the other PCSX2 profiles had the file packed into the BIOS
folder and the RetroDECK export add it there.
PCSX2 and its forks keep the first 4 to 8 MB image with a romdir in
the BIOS folder (pcsx2/ps2/BiosTools.cpp:258-282, 317-332 at f0523f8a),
and PCSX2 1.6 lists the same test in its BIOS picker
(BiosSelectorPanel.cpp:151-177). The names are labels. Without found_by
the truth model read ps2-0230a-20080220.bin as a name the core opens, and
the RetroDECK export added it as a required file.
Notes compared a core with another profile of this directory (unlike
beetle_pce, unlike the other engines in this directory), which means
nothing once a profile is read alone, and shouted NOT, ALL and MUST. The
facts stay, the comparisons and capitals go. Comparisons with a core's
own upstream remain.
The profile declared libretro/redream, which answers 404, with no pin and
no source_ref: profile_sync skipped it and the boot.bin md5 came from the
libretro docs. It now reads inolen/redream at ffb73022, the last public
tree, whose libretro core opens dc/boot.bin and dc/flash.bin in the system
directory. boot.bin is checked against four md5 and the flash against its
size, and both fall back to the high level BIOS, so neither is required.
needs_review counts an orphaned pin and a moved repository, but the
triage line only added stale prose and unchecked refs, so pcem read
"1 to review" for an upstream_commit outside its branch history.
idtech4a++ cites xash3d-fwgs filesystem/filesystem.c, starship and
ghostship Torch src/Companion.cpp: files of submodules of the declared
repository. No blob of the declared tree answers, so the parts stayed
external and a bump moved the submodule commit with nothing checked.
A project word now also resolves to the one submodule named after it,
and a file under a submodule is read in the repository .gitmodules
names, at the commit the declared revision pins it to.
The integrity check let a platform file the frontend's hash refuses
hold its path, so the core file the builder ships there was never
compared (finding 3).
Abdessamad Derraz