#!/usr/bin/env python3 """Generate platform-specific BIOS ZIP packs. Usage: python scripts/generate_pack.py --platform retroarch [--output-dir dist/] python scripts/generate_pack.py --all [--output-dir dist/] Reads platform YAML config + database.json -> creates ZIP with correct file layout for each platform. Handles inheritance, shared groups, variants, and 3-tier storage (embedded/external/user_provided). """ from __future__ import annotations import argparse import hashlib import json import os import re import sys import tempfile import urllib.request import urllib.error import zipfile from pathlib import Path sys.path.insert(0, os.path.dirname(__file__)) from common import ( MANUFACTURER_PREFIXES, build_target_cores_cache, build_zip_contents_index, check_inside_zip, compute_hashes, fetch_large_file, group_identical_platforms, list_emulator_profiles, list_platform_system_ids, list_registered_platforms, filter_systems_by_target, list_system_ids, load_database, load_data_dir_registry, load_emulator_profiles, load_platform_config, md5_composite, require_yaml, resolve_local_file, ) from validation import ( _build_validation_index, check_file_validation, filter_files_by_mode, ) from deterministic_zip import rebuild_zip_deterministic yaml = require_yaml() DEFAULT_PLATFORMS_DIR = "platforms" DEFAULT_DB_FILE = "database.json" DEFAULT_OUTPUT_DIR = "dist" DEFAULT_BIOS_DIR = "bios" MAX_ENTRY_SIZE = 512 * 1024 * 1024 # 512MB _HEX_RE = re.compile(r"\b([0-9a-fA-F]{8,40})\b") def _detect_hash_type(h: str) -> str: n = len(h) if n == 40: return "sha1" if n == 32: return "md5" if n == 8: return "crc32" return "md5" def parse_hash_input(raw: str) -> list[tuple[str, str]]: """Parse comma-separated hash string into (type, hash) tuples.""" results: list[tuple[str, str]] = [] for part in raw.split(","): part = part.strip().lower() if not part: continue m = _HEX_RE.search(part) if m: h = m.group(1) results.append((_detect_hash_type(h), h)) return results def parse_hash_file(path: str) -> list[tuple[str, str]]: """Parse hash file (one per line, comments with #, mixed formats).""" results: list[tuple[str, str]] = [] with open(path) as f: for line in f: line = line.strip() if not line or line.startswith("#"): continue m = _HEX_RE.search(line.lower()) if m: h = m.group(1) results.append((_detect_hash_type(h), h)) return results def lookup_hashes( hashes: list[tuple[str, str]], db: dict, bios_dir: str, emulators_dir: str, platforms_dir: str, ) -> None: """Print diagnostic info for each hash.""" files_db = db.get("files", {}) by_md5 = db.get("indexes", {}).get("by_md5", {}) by_crc32 = db.get("indexes", {}).get("by_crc32", {}) for hash_type, hash_val in hashes: sha1 = None if hash_type == "sha1" and hash_val in files_db: sha1 = hash_val elif hash_type == "md5": sha1 = by_md5.get(hash_val) elif hash_type == "crc32": sha1 = by_crc32.get(hash_val) if not sha1 or sha1 not in files_db: print(f"\n{hash_type.upper()}: {hash_val}") print(" NOT FOUND in database") continue entry = files_db[sha1] name = entry.get("name", "?") md5 = entry.get("md5", "?") paths = entry.get("paths") or [] aliases = entry.get("aliases") or [] print(f"\n{hash_type.upper()}: {hash_val}") print(f" SHA1: {sha1}") print(f" MD5: {md5}") print(f" Name: {name}") if paths: print(f" Path: {paths[0]}") if aliases: print(f" Aliases: {aliases}") # Check if file exists in repo (by path or by resolve_local_file) in_repo = False if paths: primary = os.path.join(bios_dir, paths[0]) if os.path.exists(primary): in_repo = True if not in_repo: try: fe_check = {"name": name, "sha1": sha1, "md5": md5} local, status = resolve_file(fe_check, db, bios_dir, {}) if local and status != "not_found": in_repo = True except (KeyError, OSError): pass print(f" In repo: {'YES' if in_repo else 'NO'}") def _find_candidate_satisfying_both( file_entry: dict, db: dict, local_path: str, validation_index: dict, bios_dir: str, ) -> str | None: """Search for a repo file that satisfies both platform MD5 and emulator validation. When the current file passes platform verification but fails emulator checks, search all candidates with the same name for one that passes both. Returns a better path, or None if no upgrade found. """ fname = file_entry.get("name", "") if not fname: return None entry = validation_index.get(fname) if not entry: return None md5_expected = file_entry.get("md5", "") md5_set = {m.strip().lower() for m in md5_expected.split(",") if m.strip()} if md5_expected else set() by_name = db.get("indexes", {}).get("by_name", {}) files_db = db.get("files", {}) for sha1 in by_name.get(fname, []): candidate = files_db.get(sha1, {}) path = candidate.get("path", "") if not path or not os.path.exists(path) or os.path.realpath(path) == os.path.realpath(local_path): continue # Must still satisfy platform MD5 if md5_set and candidate.get("md5", "").lower() not in md5_set: continue # Check emulator validation reason = check_file_validation(path, fname, validation_index, bios_dir) if reason is None: return path return None def _sanitize_path(raw: str) -> str: """Strip path traversal components from a relative path.""" raw = raw.replace("\\", "/") parts = [p for p in raw.split("/") if p and p not in ("..", ".")] return "/".join(parts) def _path_parents(dest: str) -> list[str]: """Return all parent directory segments of a path.""" parts = dest.split("/") return ["/".join(parts[:i]) for i in range(1, len(parts))] def _has_path_conflict(dest: str, seen_files: set[str], seen_parents: set[str]) -> bool: """Check if dest conflicts with existing paths (file vs directory). Returns True if adding dest would create an impossible extraction: - A parent of dest is already a file (e.g., adding X/Y when X is a file) - dest itself is already used as a directory (e.g., adding X when X/Y exists) """ for parent in _path_parents(dest): if parent in seen_files: return True if dest in seen_parents: return True return False def _register_path(dest: str, seen_files: set[str], seen_parents: set[str]) -> None: """Track a file path and its parent directories.""" seen_files.add(dest) for parent in _path_parents(dest): seen_parents.add(parent) def resolve_file(file_entry: dict, db: dict, bios_dir: str, zip_contents: dict | None = None, dest_hint: str = "", data_dir_registry: dict | None = None) -> tuple[str | None, str]: """Resolve a BIOS file with storage tiers and release asset fallback. Wraps common.resolve_local_file() with pack-specific logic for storage tiers (external/user_provided), large file release assets, and MAME clone mapping (deduped ZIPs). """ storage = file_entry.get("storage", "embedded") if storage == "user_provided": return None, "user_provided" if storage == "external": return None, "external" path, status = resolve_local_file(file_entry, db, zip_contents, dest_hint=dest_hint, data_dir_registry=data_dir_registry) if path and status != "hash_mismatch": return path, status # Large files from GitHub release assets -tried when local file is # missing OR has a hash mismatch (wrong variant on disk) name = file_entry.get("name", "") sha1 = file_entry.get("sha1") md5_raw = file_entry.get("md5", "") md5_list = [m.strip().lower() for m in md5_raw.split(",") if m.strip()] if md5_raw else [] first_md5 = md5_list[0] if md5_list else "" cached = fetch_large_file(name, expected_sha1=sha1 or "", expected_md5=first_md5) if cached: return cached, "release_asset" # Fall back to hash_mismatch local file if release asset unavailable if path: return path, status return None, "not_found" def download_external(file_entry: dict, dest_path: str) -> bool: """Download an external BIOS file, verify hash, save to dest_path.""" url = file_entry.get("source_url") if not url: return False sha256 = file_entry.get("sha256") sha1 = file_entry.get("sha1") md5 = file_entry.get("md5") if not (sha256 or sha1 or md5): print(f" WARNING: no hash for {file_entry['name']}, skipping unverifiable download") return False try: req = urllib.request.Request(url, headers={"User-Agent": "retrobios-pack-gen/1.0"}) with urllib.request.urlopen(req, timeout=120) as resp: data = resp.read() except urllib.error.URLError as e: print(f" WARNING: Failed to download {url}: {e}") return False if sha256: actual = hashlib.sha256(data).hexdigest() if actual != sha256: print(f" WARNING: SHA256 mismatch for {file_entry['name']}") return False elif sha1: actual = hashlib.sha1(data).hexdigest() if actual != sha1: print(f" WARNING: SHA1 mismatch for {file_entry['name']}") return False elif md5: actual = hashlib.md5(data).hexdigest() if actual != md5: print(f" WARNING: MD5 mismatch for {file_entry['name']}") return False os.makedirs(os.path.dirname(dest_path), exist_ok=True) with open(dest_path, "wb") as f: f.write(data) return True def _collect_emulator_extras( config: dict, emulators_dir: str, db: dict, seen: set, base_dest: str, emu_profiles: dict | None = None, target_cores: set[str] | None = None, ) -> list[dict]: """Collect core requirement files from emulator profiles not in the platform pack. Uses the same system-overlap matching as verify.py cross-reference: - Matches emulators by shared system IDs with the platform - Filters mode: standalone, type: launcher, type: alias - Respects data_directories coverage - Only returns files that exist in the repo (packable) When the same file is needed at multiple destinations by different cores (e.g. cdimono1.zip at root for cdi2015 and at same_cdi/bios/ for same_cdi), all destinations are included so every core finds its files. Works for ANY platform (RetroArch, Batocera, Recalbox, etc.) """ from common import resolve_platform_cores from verify import find_undeclared_files undeclared = find_undeclared_files(config, emulators_dir, db, emu_profiles, target_cores=target_cores) extras = [] seen_dests: set[str] = set(seen) for u in undeclared: if not u["in_repo"]: continue # For archive entries, use the archive name for resolution archive = u.get("archive") name = archive if archive else u["name"] dest = archive if archive else (u.get("path") or u["name"]) full_dest = f"{base_dest}/{dest}" if base_dest else dest if full_dest in seen_dests: continue seen_dests.add(full_dest) extras.append({ "name": name, "destination": dest, "required": u.get("required", False), "hle_fallback": u.get("hle_fallback", False), "source_emulator": u.get("emulator", ""), }) # Second pass: find alternative destinations for files already in the pack. # A file declared by the platform or emitted above may also be needed at a # different path by another core (e.g. neocd/ vs root, same_cdi/bios/ vs root). # Only adds a copy when the file is ALREADY covered at a different path - # never introduces a file that wasn't selected by the first pass. profiles = emu_profiles if emu_profiles is not None else load_emulator_profiles(emulators_dir) relevant = resolve_platform_cores(config, profiles, target_cores=target_cores) standalone_set = {str(c) for c in config.get("standalone_cores", [])} by_name = db.get("indexes", {}).get("by_name", {}) by_path_suffix = db.get("indexes", {}).get("by_path_suffix", {}) # Build set of filenames already covered (platform baseline + first pass extras) covered_names: set[str] = set() for sys_id, system in config.get("systems", {}).items(): for fe in system.get("files", []): n = fe.get("name", "") if n: covered_names.add(n) for e in extras: covered_names.add(e["name"]) for emu_name, profile in sorted(profiles.items()): if profile.get("type") in ("launcher", "alias"): continue if emu_name not in relevant: continue is_standalone = emu_name in standalone_set or bool( standalone_set & {str(c) for c in profile.get("cores", [])} ) for f in profile.get("files", []): fname = f.get("name", "") if not fname: continue # Only duplicate files already covered at another destination if fname not in covered_names: continue file_mode = f.get("mode") if file_mode == "standalone" and not is_standalone: continue if file_mode == "libretro" and is_standalone: continue # Skip files loaded from non-system directories (save_dir, content_dir) load_from = f.get("load_from", "") if load_from and load_from != "system_dir": continue if is_standalone: dest = f.get("standalone_path") or f.get("path") or fname else: dest = f.get("path") or fname if dest == fname: continue # no alternative destination full_dest = f"{base_dest}/{dest}" if base_dest else dest if full_dest in seen_dests: continue # Check file exists in repo or data dirs if not (by_name.get(fname) or by_name.get(dest.rsplit("/", 1)[-1]) or by_path_suffix.get(dest)): continue seen_dests.add(full_dest) extras.append({ "name": fname, "destination": dest, "required": f.get("required", False), "hle_fallback": f.get("hle_fallback", False), "source_emulator": profile.get("emulator", emu_name), }) return extras def _build_readme(platform_name: str, platform_display: str, base_dest: str, total_files: int, num_systems: int) -> str: """Build a personalized step-by-step README for each platform pack.""" sep = "=" * 50 header = ( f"{sep}\n" f" RETROBIOS - {platform_display} BIOS Pack\n" f" {total_files} files for {num_systems} systems\n" f"{sep}\n\n" ) guides: dict[str, str] = { "retroarch": ( "INSTALLATION GUIDE\n\n" " Option A: Automatic (recommended)\n" " ---------------------------------\n" " Run this in a terminal:\n\n" " curl -fsSL https://raw.githubusercontent.com/Abdess/retrobios/main/install.sh | sh\n\n" " The script auto-detects your RetroArch install and copies\n" " files to the correct location.\n\n" " Option B: Manual (PC)\n" " ---------------------\n" " 1. Find your RetroArch system directory:\n" " - RetroArch > Settings > Directory > System/BIOS\n" " - Default: retroarch/system/\n" " 2. Open the \"system\" folder from this archive\n" " 3. Copy ALL contents into your system directory\n" " 4. Overwrite if asked\n\n" " Option C: Manual (handheld / SD card)\n" " -------------------------------------\n" " Anbernic, Retroid, Miyoo, Trimui, etc.:\n" " 1. Connect your SD card to your PC\n" " 2. Find the BIOS folder (usually BIOS/ or system/)\n" " 3. Copy ALL contents of \"system\" from this archive\n" " 4. Eject SD card and reboot your device\n\n" " Common paths by device:\n" " Anbernic (ArkOS/JELOS): BIOS/\n" " Retroid (RetroArch): RetroArch/system/\n" " Miyoo Mini (Onion OS): BIOS/\n" " Steam Deck (RetroArch): ~/.config/retroarch/system/\n\n" ), "batocera": ( "INSTALLATION GUIDE\n\n" " Option A: Automatic (recommended)\n" " ---------------------------------\n" " Open a terminal (F1 from Batocera menu) and run:\n\n" " curl -fsSL https://raw.githubusercontent.com/Abdess/retrobios/main/install.sh | sh\n\n" " Option B: Manual (network share)\n" " --------------------------------\n" " 1. On your PC, open the Batocera network share:\n" " - Windows: \\\\BATOCERA\\share\\bios\\\n" " - Mac/Linux: smb://batocera/share/bios/\n" " 2. Open the \"bios\" folder from this archive\n" " 3. Copy ALL contents into the share\n" " 4. Overwrite if asked\n\n" " Option C: Manual (SD card)\n" " --------------------------\n" " 1. Put the SD card in your PC\n" " 2. Navigate to /userdata/bios/ on the SHARE partition\n" " 3. Copy ALL contents of \"bios\" from this archive\n\n" " NOTE: Dreamcast flash memory is named dc_nvmem.bin\n" " (if your setup asks for dc_flash.bin, same file).\n\n" ), "recalbox": ( "INSTALLATION GUIDE\n\n" " Option A: Automatic\n" " -------------------\n" " curl -fsSL https://raw.githubusercontent.com/Abdess/retrobios/main/install.sh | sh\n\n" " Option B: Manual (network share)\n" " --------------------------------\n" " 1. On your PC, open the Recalbox network share:\n" " - Windows: \\\\RECALBOX\\share\\bios\\\n" " - Mac/Linux: smb://recalbox/share/bios/\n" " 2. Open the \"bios\" folder from this archive\n" " 3. Copy ALL contents into the share\n\n" " Option C: Manual (SD card)\n" " --------------------------\n" " 1. Put the SD card in your PC\n" " 2. Navigate to /recalbox/share/bios/\n" " 3. Copy ALL contents of \"bios\" from this archive\n\n" ), "emudeck": ( "INSTALLATION GUIDE (Steam Deck / Linux)\n\n" " Option A: Automatic (recommended)\n" " ---------------------------------\n" " Open Konsole (or any terminal) and run:\n\n" " curl -fsSL https://raw.githubusercontent.com/Abdess/retrobios/main/install.sh | sh\n\n" " The script places BIOS files AND sets up standalone\n" " emulator keys automatically.\n\n" " Option B: Manual\n" " ----------------\n" " 1. Open Dolphin file manager\n" " 2. Navigate to ~/Emulation/bios/\n" " 3. Open the \"bios\" folder from this archive\n" " 4. Copy ALL contents into ~/Emulation/bios/\n\n" " STANDALONE EMULATORS (extra step)\n" " Switch and 3DS emulators need keys in specific folders:\n" " prod.keys -> ~/.local/share/yuzu/keys/\n" " prod.keys -> ~/.local/share/eden/keys/\n" " prod.keys -> ~/.config/Ryujinx/system/\n" " aes_keys.txt -> ~/Emulation/bios/citra/keys/\n" " The automatic installer handles this for you.\n\n" ), "retrodeck": ( "INSTALLATION GUIDE (Steam Deck / Linux)\n\n" " Option A: Automatic (recommended)\n" " ---------------------------------\n" " Open Konsole (or any terminal) and run:\n\n" " curl -fsSL https://raw.githubusercontent.com/Abdess/retrobios/main/install.sh | sh\n\n" " Option B: Manual\n" " ----------------\n" " 1. Open Dolphin file manager\n" " 2. Show hidden files (Ctrl+H)\n" " 3. Navigate to ~/retrodeck/bios/\n" " 4. Open this archive and go into the top-level folder\n" " 5. Copy ALL contents into ~/retrodeck/bios/\n\n" " NOTE: RetroDECK uses its own BIOS checker. After\n" " copying, open RetroDECK > Tools > BIOS Checker to\n" " verify everything is detected.\n\n" ), "retrobat": ( "INSTALLATION GUIDE (Windows)\n\n" " Option A: Automatic (recommended)\n" " ---------------------------------\n" " Download and run install.bat from:\n" " https://github.com/Abdess/retrobios/releases\n\n" " Option B: Manual\n" " ----------------\n" " 1. Open your RetroBat installation folder\n" " 2. Navigate to the bios\\ subfolder\n" " (default: C:\\RetroBat\\bios\\)\n" " 3. Open the \"bios\" folder from this archive\n" " 4. Copy ALL contents into your bios\\ folder\n" " 5. Overwrite if asked\n\n" ), "bizhawk": ( "INSTALLATION GUIDE\n\n" " 1. Open your BizHawk installation folder\n" " 2. Navigate to the Firmware subfolder:\n" " - Windows: BizHawk\\Firmware\\\n" " - Linux: ~/.config/BizHawk/Firmware/\n" " 3. Open the \"Firmware\" folder from this archive\n" " 4. Copy ALL contents into your Firmware folder\n" " 5. In BizHawk: Config > Paths > Firmware should\n" " point to this folder\n\n" ), "romm": ( "INSTALLATION GUIDE (RomM server)\n\n" " 1. Locate your RomM library folder\n" " 2. Navigate to the bios/ subdirectory\n" " 3. Copy ALL contents of \"bios\" from this archive\n" " 4. Restart the RomM service to detect new files\n\n" ), "retropie": ( "INSTALLATION GUIDE (Raspberry Pi)\n\n" " Option A: Via network share\n" " --------------------------\n" " 1. On your PC, open: \\\\RETROPIE\\bios\\\n" " 2. Copy ALL contents of \"BIOS\" from this archive\n\n" " Option B: Via SSH\n" " -----------------\n" " 1. SSH into your Pi: ssh pi@retropie\n" " 2. Copy files to ~/RetroPie/BIOS/\n\n" " Option C: Via SD card\n" " ---------------------\n" " 1. Put the SD card in your PC\n" " 2. Navigate to /home/pi/RetroPie/BIOS/\n" " 3. Copy ALL contents of \"BIOS\" from this archive\n\n" ), } # Lakka uses same guide as RetroArch guides["lakka"] = guides["retroarch"] guide = guides.get(platform_name, ( f"INSTALLATION\n\n" f" 1. Open the \"{base_dest or 'files'}\" folder in this archive\n" f" 2. Copy ALL contents to your BIOS directory\n" f" 3. Overwrite if asked\n\n" )) footer = ( "TROUBLESHOOTING\n\n" " - Core says BIOS missing? Check the exact filename\n" " and make sure it's in the right subfolder.\n" " - Wrong region? Some systems have regional BIOS\n" " variants (USA/EUR/JAP). All are included.\n" " - Need help? https://github.com/Abdess/retrobios/issues\n\n" f"{sep}\n" f" https://github.com/Abdess/retrobios\n" f"{sep}\n" ) return header + guide + footer def generate_pack( platform_name: str, platforms_dir: str, db: dict, bios_dir: str, output_dir: str, include_extras: bool = False, emulators_dir: str = "emulators", zip_contents: dict | None = None, data_registry: dict | None = None, emu_profiles: dict | None = None, target_cores: set[str] | None = None, required_only: bool = False, system_filter: list[str] | None = None, precomputed_extras: list[dict] | None = None, ) -> str | None: """Generate a ZIP pack for a platform. Returns the path to the generated ZIP, or None on failure. """ config = load_platform_config(platform_name, platforms_dir) if zip_contents is None: zip_contents = {} verification_mode = config.get("verification_mode", "existence") platform_display = config.get("platform", platform_name) base_dest = config.get("base_destination", "") version = config.get("version", config.get("dat_version", "")) version_tag = f"_{version.replace(' ', '')}" if version else "" req_tag = "_Required" if required_only else "" sys_tag = "" if system_filter: display_parts = [] for sid in system_filter: s = sid.lower().replace("_", "-") for prefix in MANUFACTURER_PREFIXES: if s.startswith(prefix): s = s[len(prefix):] break parts = s.split("-") display_parts.append("_".join(p.title() for p in parts if p)) sys_tag = "_" + "_".join(display_parts) zip_name = f"{platform_display.replace(' ', '_')}{version_tag}{req_tag}_BIOS_Pack{sys_tag}.zip" zip_path = os.path.join(output_dir, zip_name) os.makedirs(output_dir, exist_ok=True) # Case-insensitive dedup only for platforms targeting Windows/macOS. # Linux-only platforms (Batocera, Recalbox, RetroDECK, Lakka, RomM) # are case-sensitive and may have distinct files like DISK.ROM vs disk.rom. case_insensitive = config.get("case_insensitive_fs", False) total_files = 0 missing_files = [] user_provided = [] seen_destinations: set[str] = set() seen_lower: set[str] = set() # only used when case_insensitive=True seen_parents: set[str] = set() # parent dirs of added files (path conflict detection) # Per-file status: worst status wins (missing > untested > ok) file_status: dict[str, str] = {} file_reasons: dict[str, str] = {} # Build emulator-level validation index (same as verify.py) validation_index = {} if emu_profiles: validation_index = _build_validation_index(emu_profiles) # Filter systems by target if specified from common import resolve_platform_cores plat_cores = resolve_platform_cores(config, emu_profiles or {}) if target_cores else None pack_systems = filter_systems_by_target( config.get("systems", {}), emu_profiles or {}, target_cores, platform_cores=plat_cores, ) if system_filter: from common import _norm_system_id norm_filter = {_norm_system_id(s) for s in system_filter} filtered = {sid: sys_data for sid, sys_data in pack_systems.items() if sid in system_filter or _norm_system_id(sid) in norm_filter} if not filtered: available = sorted(pack_systems.keys())[:10] print(f" WARNING: no systems matched filter {system_filter} " f"(available: {', '.join(available)})") return None pack_systems = filtered with zipfile.ZipFile(zip_path, "w", zipfile.ZIP_DEFLATED) as zf: for sys_id, system in sorted(pack_systems.items()): for file_entry in system.get("files", []): if required_only and file_entry.get("required") is False: continue dest = _sanitize_path(file_entry.get("destination", file_entry["name"])) if not dest: # EmuDeck-style entries (system:md5 whitelist, no filename). fkey = f"{sys_id}/{file_entry.get('name', '')}" md5 = file_entry.get("md5", "") if md5 and md5 in db.get("indexes", {}).get("by_md5", {}): file_status.setdefault(fkey, "ok") else: file_status[fkey] = "missing" continue if base_dest: full_dest = f"{base_dest}/{dest}" else: full_dest = dest dedup_key = full_dest already_packed = dedup_key in seen_destinations or (case_insensitive and dedup_key.lower() in seen_lower) if _has_path_conflict(full_dest, seen_destinations, seen_parents): continue storage = file_entry.get("storage", "embedded") if storage == "user_provided": if already_packed: continue seen_destinations.add(dedup_key) _register_path(dedup_key, seen_destinations, seen_parents) if case_insensitive: seen_lower.add(dedup_key.lower()) file_status.setdefault(dedup_key, "ok") instructions = file_entry.get("instructions", "Please provide this file manually.") instr_name = f"INSTRUCTIONS_{file_entry['name']}.txt" instr_path = f"{base_dest}/{instr_name}" if base_dest else instr_name zf.writestr(instr_path, f"File needed: {file_entry['name']}\n\n{instructions}\n") user_provided.append(file_entry["name"]) total_files += 1 continue local_path, status = resolve_file( file_entry, db, bios_dir, zip_contents, data_dir_registry=data_registry, ) if status == "external": file_ext = os.path.splitext(file_entry["name"])[1] or "" with tempfile.NamedTemporaryFile(delete=False, suffix=file_ext) as tmp: tmp_path = tmp.name try: if download_external(file_entry, tmp_path): extract = file_entry.get("extract", False) if extract and tmp_path.endswith(".zip"): _extract_zip_to_archive(tmp_path, full_dest, zf) else: zf.write(tmp_path, full_dest) seen_destinations.add(dedup_key) _register_path(dedup_key, seen_destinations, seen_parents) if case_insensitive: seen_lower.add(dedup_key.lower()) file_status.setdefault(dedup_key, "ok") total_files += 1 else: missing_files.append(file_entry["name"]) file_status[dedup_key] = "missing" finally: if os.path.exists(tmp_path): os.unlink(tmp_path) continue if status == "not_found": if not already_packed: missing_files.append(file_entry["name"]) file_status[dedup_key] = "missing" continue if status == "hash_mismatch" and verification_mode != "existence": zf_name = file_entry.get("zipped_file") if zf_name and local_path: inner_md5_raw = file_entry.get("md5", "") inner_md5_list = ( [m.strip() for m in inner_md5_raw.split(",") if m.strip()] if inner_md5_raw else [""] ) zip_ok = False last_result = "not_in_zip" for md5_candidate in inner_md5_list: last_result = check_inside_zip(local_path, zf_name, md5_candidate) if last_result == "ok": zip_ok = True break if zip_ok: file_status.setdefault(dedup_key, "ok") elif last_result == "not_in_zip": file_status[dedup_key] = "untested" file_reasons[dedup_key] = f"{zf_name} not found inside ZIP" elif last_result == "error": file_status[dedup_key] = "untested" file_reasons[dedup_key] = "cannot read ZIP" else: file_status[dedup_key] = "untested" file_reasons[dedup_key] = f"{zf_name} MD5 mismatch inside ZIP" else: file_status[dedup_key] = "untested" file_reasons[dedup_key] = "hash mismatch" else: file_status.setdefault(dedup_key, "ok") # Emulator-level validation: informational only for platform packs. # Platform verification (existence/md5) is the authority for pack status. # Emulator checks are supplementary -logged but don't downgrade. # When a discrepancy is found, try to find a file satisfying both. if (file_status.get(dedup_key) == "ok" and local_path and validation_index): fname = file_entry.get("name", "") reason = check_file_validation(local_path, fname, validation_index, bios_dir) if reason: better = _find_candidate_satisfying_both( file_entry, db, local_path, validation_index, bios_dir, ) if better: local_path = better else: ventry = validation_index.get(fname, {}) emus = ", ".join(ventry.get("emulators", [])) file_reasons.setdefault( dedup_key, f"{platform_display} says OK but {emus} says {reason}", ) if already_packed: continue seen_destinations.add(dedup_key) _register_path(dedup_key, seen_destinations, seen_parents) if case_insensitive: seen_lower.add(dedup_key.lower()) extract = file_entry.get("extract", False) if extract and local_path.endswith(".zip"): _extract_zip_to_archive(local_path, full_dest, zf) elif local_path.endswith(".zip"): _normalize_zip_for_pack(local_path, full_dest, zf) else: zf.write(local_path, full_dest) total_files += 1 # Core requirements: files platform's cores need but YAML doesn't declare if emu_profiles is None: emu_profiles = load_emulator_profiles(emulators_dir) if precomputed_extras is not None: core_files = precomputed_extras elif system_filter: core_files = [] else: core_files = _collect_emulator_extras( config, emulators_dir, db, seen_destinations, base_dest, emu_profiles, target_cores=target_cores, ) core_count = 0 for fe in core_files: if required_only and fe.get("required") is False: continue dest = _sanitize_path(fe.get("destination", fe["name"])) if not dest: continue # Core extras use flat filenames; prepend base_destination or # default to the platform's most common BIOS path prefix if base_dest: full_dest = f"{base_dest}/{dest}" elif "/" not in dest: # Bare filename with empty base_destination -infer bios/ prefix # to match platform conventions (RetroDECK: ~/retrodeck/bios/) full_dest = f"bios/{dest}" else: full_dest = dest if full_dest in seen_destinations: continue # Skip case-insensitive duplicates (Windows/macOS FS safety) if full_dest.lower() in seen_lower and case_insensitive: continue # Skip file/directory path conflicts (e.g., SGB1.sfc file vs SGB1.sfc/ dir) if _has_path_conflict(full_dest, seen_destinations, seen_parents): continue local_path, status = resolve_file( fe, db, bios_dir, zip_contents, data_dir_registry=data_registry, ) if status in ("not_found", "external", "user_provided"): continue if local_path.endswith(".zip"): _normalize_zip_for_pack(local_path, full_dest, zf) else: zf.write(local_path, full_dest) seen_destinations.add(full_dest) _register_path(full_dest, seen_destinations, seen_parents) if case_insensitive: seen_lower.add(full_dest.lower()) core_count += 1 total_files += 1 # Data directories from _data_dirs.yml for sys_id, system in sorted(pack_systems.items()): for dd in system.get("data_directories", []): ref_key = dd.get("ref", "") if not ref_key or not data_registry or ref_key not in data_registry: continue entry = data_registry[ref_key] allowed = entry.get("for_platforms") if allowed and platform_name not in allowed: continue local_path = entry.get("local_cache", "") if not local_path or not os.path.isdir(local_path): print(f" WARNING: data directory '{ref_key}' not cached at {local_path} -run refresh_data_dirs.py") continue dd_dest = dd.get("destination", "") if base_dest and dd_dest: dd_prefix = f"{base_dest}/{dd_dest}" elif base_dest: dd_prefix = base_dest else: dd_prefix = dd_dest for root, _dirs, filenames in os.walk(local_path): for fname in filenames: src = os.path.join(root, fname) rel = os.path.relpath(src, local_path) full = f"{dd_prefix}/{rel}" if full in seen_destinations or (full.lower() in seen_lower and case_insensitive): continue if _has_path_conflict(full, seen_destinations, seen_parents): continue seen_destinations.add(full) _register_path(full, seen_destinations, seen_parents) if case_insensitive: seen_lower.add(full.lower()) zf.write(src, full) total_files += 1 # README.txt for users -personalized step-by-step per platform num_systems = len(pack_systems) readme_text = _build_readme(platform_name, platform_display, base_dest, total_files, num_systems) zf.writestr("README.txt", readme_text) files_ok = sum(1 for s in file_status.values() if s == "ok") files_untested = sum(1 for s in file_status.values() if s == "untested") files_miss = sum(1 for s in file_status.values() if s == "missing") total_checked = len(file_status) parts = [f"{files_ok}/{total_checked} files OK"] if files_untested: parts.append(f"{files_untested} untested") if files_miss: parts.append(f"{files_miss} missing") baseline = total_files - core_count print(f" {zip_path}: {total_files} files packed ({baseline} baseline + {core_count} from cores), {', '.join(parts)} [{verification_mode}]") for key, reason in sorted(file_reasons.items()): status = file_status.get(key, "") label = "UNTESTED" if status == "untested" else "DISCREPANCY" print(f" {label}: {key} -{reason}") for name in missing_files: print(f" MISSING: {name}") return zip_path def _extract_zip_to_archive(source_zip: str, dest_prefix: str, target_zf: zipfile.ZipFile): """Extract contents of a source ZIP into target ZIP under dest_prefix.""" with zipfile.ZipFile(source_zip, "r") as src: for info in src.infolist(): if info.is_dir(): continue clean_name = _sanitize_path(info.filename) if not clean_name: continue data = src.read(info.filename) target_path = f"{dest_prefix}/{clean_name}" if dest_prefix else clean_name target_zf.writestr(target_path, data) def _normalize_zip_for_pack(source_zip: str, dest_path: str, target_zf: zipfile.ZipFile): """Add a MAME BIOS ZIP to the pack as a deterministic rebuild. Instead of copying the original ZIP (with non-deterministic metadata), extracts the ROM atoms, rebuilds the ZIP deterministically, and writes the normalized version into the pack. This ensures: - Same ROMs -> same ZIP hash in every pack build - No dependency on how the user built their MAME ROM set - Bit-identical ZIPs across platforms and build times """ import tempfile as _tmp tmp_fd, tmp_path = _tmp.mkstemp(suffix=".zip", dir="tmp") os.close(tmp_fd) try: rebuild_zip_deterministic(source_zip, tmp_path) target_zf.write(tmp_path, dest_path) finally: os.unlink(tmp_path) # Emulator/system mode pack generation def _resolve_destination(file_entry: dict, pack_structure: dict | None, standalone: bool) -> str: """Resolve the ZIP destination path for a file entry.""" # 1. standalone_path override if standalone and file_entry.get("standalone_path"): rel = file_entry["standalone_path"] # 2. path field elif file_entry.get("path"): rel = file_entry["path"] # 3. name fallback else: rel = file_entry.get("name", "") rel = _sanitize_path(rel) # Prepend pack_structure prefix if pack_structure: mode_key = "standalone" if standalone else "libretro" prefix = pack_structure.get(mode_key, "") if prefix: rel = f"{prefix}/{rel}" return rel def generate_emulator_pack( profile_names: list[str], emulators_dir: str, db: dict, bios_dir: str, output_dir: str, standalone: bool = False, zip_contents: dict | None = None, required_only: bool = False, ) -> str | None: """Generate a ZIP pack for specific emulator profiles.""" all_profiles = load_emulator_profiles(emulators_dir, skip_aliases=False) if zip_contents is None: zip_contents = build_zip_contents_index(db) # Resolve and validate profile names selected: list[tuple[str, dict]] = [] for name in profile_names: if name not in all_profiles: available = sorted(k for k, v in all_profiles.items() if v.get("type") not in ("alias", "test")) print(f"Error: emulator '{name}' not found", file=sys.stderr) print(f"Available: {', '.join(available[:10])}...", file=sys.stderr) return None p = all_profiles[name] if p.get("type") == "alias": alias_of = p.get("alias_of", "?") print(f"Error: {name} is an alias of {alias_of} -use --emulator {alias_of}", file=sys.stderr) return None if p.get("type") == "launcher": print(f"Error: {name} is a launcher -use the emulator it launches", file=sys.stderr) return None ptype = p.get("type", "libretro") if standalone and "standalone" not in ptype: print(f"Error: {name} ({ptype}) does not support --standalone", file=sys.stderr) return None selected.append((name, p)) # ZIP naming display_names = [p.get("emulator", n).replace(" ", "") for n, p in selected] zip_name = "_".join(display_names) + "_BIOS_Pack.zip" zip_path = os.path.join(output_dir, zip_name) os.makedirs(output_dir, exist_ok=True) total_files = 0 missing_files = [] seen_destinations: set[str] = set() seen_lower: set[str] = set() seen_parents: set[str] = set() # parent dirs of added files (path conflict detection) seen_hashes: set[str] = set() # SHA1 dedup for same file, different path data_dir_notices: list[str] = [] data_registry = load_data_dir_registry( os.path.join(os.path.dirname(__file__), "..", "platforms") ) with zipfile.ZipFile(zip_path, "w", zipfile.ZIP_DEFLATED) as zf: for emu_name, profile in sorted(selected): pack_structure = profile.get("pack_structure") files = filter_files_by_mode(profile.get("files", []), standalone) for dd in profile.get("data_directories", []): ref_key = dd.get("ref", "") if not ref_key or not data_registry or ref_key not in data_registry: if ref_key: data_dir_notices.append(ref_key) continue entry = data_registry[ref_key] local_cache = entry.get("local_cache", "") if not local_cache or not os.path.isdir(local_cache): data_dir_notices.append(ref_key) continue dd_dest = dd.get("destination", "") if pack_structure: mode_key = "standalone" if standalone else "libretro" prefix = pack_structure.get(mode_key, "") if prefix: dd_dest = f"{prefix}/{dd_dest}" if dd_dest else prefix for root, _dirs, filenames in os.walk(local_cache): for fname in filenames: src = os.path.join(root, fname) rel = os.path.relpath(src, local_cache) full = f"{dd_dest}/{rel}" if dd_dest else rel if full.lower() in seen_lower: continue if _has_path_conflict(full, seen_destinations, seen_parents): continue seen_destinations.add(full) _register_path(full, seen_destinations, seen_parents) seen_lower.add(full.lower()) zf.write(src, full) total_files += 1 if not files: print(f" No files needed for {profile.get('emulator', emu_name)}") continue # Collect archives as atomic units archives: set[str] = set() for fe in files: archive = fe.get("archive") if archive: archives.add(archive) # Pack archives as units for archive_name in sorted(archives): archive_dest = _sanitize_path(archive_name) if pack_structure: mode_key = "standalone" if standalone else "libretro" prefix = pack_structure.get(mode_key, "") if prefix: archive_dest = f"{prefix}/{archive_dest}" if archive_dest.lower() in seen_lower: continue if _has_path_conflict(archive_dest, seen_destinations, seen_parents): continue archive_entry = {"name": archive_name} local_path, status = resolve_file( archive_entry, db, bios_dir, zip_contents, data_dir_registry=data_registry, ) if local_path and status not in ("not_found",): if local_path.endswith(".zip"): _normalize_zip_for_pack(local_path, archive_dest, zf) else: zf.write(local_path, archive_dest) seen_destinations.add(archive_dest) _register_path(archive_dest, seen_destinations, seen_parents) seen_lower.add(archive_dest.lower()) total_files += 1 else: missing_files.append(archive_name) # Pack individual files (skip archived ones) for fe in files: if required_only and fe.get("required") is False: continue if fe.get("archive"): continue dest = _resolve_destination(fe, pack_structure, standalone) if not dest: continue if dest.lower() in seen_lower: continue if _has_path_conflict(dest, seen_destinations, seen_parents): continue storage = fe.get("storage", "embedded") if storage == "user_provided": seen_destinations.add(dest) _register_path(dest, seen_destinations, seen_parents) seen_lower.add(dest.lower()) instr = fe.get("instructions", "Please provide this file manually.") instr_name = f"INSTRUCTIONS_{fe['name']}.txt" zf.writestr(instr_name, f"File needed: {fe['name']}\n\n{instr}\n") total_files += 1 continue dest_hint = fe.get("path", "") local_path, status = resolve_file( fe, db, bios_dir, zip_contents, dest_hint=dest_hint, data_dir_registry=data_registry, ) if status == "external": file_ext = os.path.splitext(fe["name"])[1] or "" with tempfile.NamedTemporaryFile(delete=False, suffix=file_ext) as tmp: tmp_path = tmp.name try: if download_external(fe, tmp_path): zf.write(tmp_path, dest) seen_destinations.add(dest) _register_path(dest, seen_destinations, seen_parents) seen_lower.add(dest.lower()) total_files += 1 else: missing_files.append(fe["name"]) finally: if os.path.exists(tmp_path): os.unlink(tmp_path) continue if status in ("not_found", "user_provided"): missing_files.append(fe["name"]) continue # SHA1 dedup: skip if same physical file AND same destination # (but allow same file to be packed under different destinations, # e.g., IPL.bin in GC/USA/ and GC/EUR/ from same source) if local_path: real = os.path.realpath(local_path) dedup_key_hash = f"{real}:{dest}" if dedup_key_hash in seen_hashes: continue seen_hashes.add(dedup_key_hash) if local_path.endswith(".zip"): _normalize_zip_for_pack(local_path, dest, zf) else: zf.write(local_path, dest) seen_destinations.add(dest) _register_path(dest, seen_destinations, seen_parents) seen_lower.add(dest.lower()) total_files += 1 # Remove empty ZIP (no files packed and no missing = nothing to ship) if total_files == 0 and not missing_files: os.unlink(zip_path) # Report label = " + ".join(p.get("emulator", n) for n, p in selected) missing_count = len(missing_files) ok_count = total_files parts = [f"{ok_count} files packed"] if missing_count: parts.append(f"{missing_count} missing") print(f" {zip_path}: {', '.join(parts)}") for name in missing_files: print(f" MISSING: {name}") for ref in sorted(set(data_dir_notices)): print(f" Note: data directory '{ref}' required but not included (use refresh_data_dirs.py)") return zip_path if total_files > 0 or missing_files else None def generate_system_pack( system_ids: list[str], emulators_dir: str, db: dict, bios_dir: str, output_dir: str, standalone: bool = False, zip_contents: dict | None = None, required_only: bool = False, ) -> str | None: """Generate a ZIP pack for all emulators supporting given system IDs.""" profiles = load_emulator_profiles(emulators_dir) matching = [] for name, profile in sorted(profiles.items()): if profile.get("type") in ("launcher", "alias", "test"): continue emu_systems = set(profile.get("systems", [])) if emu_systems & set(system_ids): ptype = profile.get("type", "libretro") if standalone and "standalone" not in ptype: continue matching.append(name) if not matching: all_systems: set[str] = set() for p in profiles.values(): all_systems.update(p.get("systems", [])) if standalone: print(f"No standalone emulators found for system(s): {', '.join(system_ids)}", file=sys.stderr) else: print(f"No emulators found for system(s): {', '.join(system_ids)}", file=sys.stderr) print(f"Available systems: {', '.join(sorted(all_systems)[:20])}...", file=sys.stderr) return None # Use system-based ZIP name sys_display = "_".join( "_".join(w.title() for w in sid.split("-")) for sid in system_ids ) result = generate_emulator_pack( matching, emulators_dir, db, bios_dir, output_dir, standalone, zip_contents, required_only=required_only, ) if result: # Rename to system-based name new_name = f"{sys_display}_BIOS_Pack.zip" new_path = os.path.join(output_dir, new_name) if new_path != result: os.rename(result, new_path) result = new_path return result def list_platforms(platforms_dir: str) -> list[str]: """List available platform names from registry.""" return list_registered_platforms(platforms_dir, include_archived=True) def _system_display_name(system_id: str) -> str: """Convert system ID to display name for ZIP naming.""" s = system_id.lower().replace("_", "-") for prefix in MANUFACTURER_PREFIXES: if s.startswith(prefix): s = s[len(prefix):] break parts = s.split("-") return "_".join(p.title() for p in parts if p) def _group_systems_by_manufacturer( systems: dict[str, dict], db: dict, bios_dir: str, ) -> dict[str, list[str]]: """Group system IDs by manufacturer for --split --group-by manufacturer.""" from common import derive_manufacturer groups: dict[str, list[str]] = {} for sid, sys_data in systems.items(): mfr = derive_manufacturer(sid, sys_data) groups.setdefault(mfr, []).append(sid) return groups def generate_split_packs( platform_name: str, platforms_dir: str, db: dict, bios_dir: str, output_dir: str, group_by: str = "system", emulators_dir: str = "emulators", zip_contents: dict | None = None, data_registry: dict | None = None, emu_profiles: dict | None = None, target_cores: set[str] | None = None, required_only: bool = False, ) -> list[str]: """Generate split packs (one ZIP per system or manufacturer).""" config = load_platform_config(platform_name, platforms_dir) platform_display = config.get("platform", platform_name) split_dir = os.path.join(output_dir, f"{platform_display.replace(' ', '_')}_Split") os.makedirs(split_dir, exist_ok=True) systems = config.get("systems", {}) if group_by == "manufacturer": groups = _group_systems_by_manufacturer(systems, db, bios_dir) else: groups = {_system_display_name(sid): [sid] for sid in systems} # Pre-compute core extras once (expensive: scans 260+ emulator profiles) # then distribute per group based on emulator system overlap if emu_profiles is None: emu_profiles = load_emulator_profiles(emulators_dir) base_dest = config.get("base_destination", "") if emu_profiles: all_extras = _collect_emulator_extras( config, emulators_dir, db, set(), base_dest, emu_profiles, target_cores=target_cores, ) else: all_extras = [] # Map each extra to matching systems via source_emulator. # Index by both profile key AND display name (source_emulator uses display). from common import _norm_system_id emu_system_map: dict[str, set[str]] = {} for name, p in emu_profiles.items(): raw = set(p.get("systems", [])) norm = {_norm_system_id(s) for s in raw} combined = raw | norm emu_system_map[name] = combined display = p.get("emulator", "") if display and display != name: emu_system_map[display] = combined plat_norm = {_norm_system_id(s): s for s in systems} results = [] for group_name, group_system_ids in sorted(groups.items()): group_sys_set = set(group_system_ids) group_norm = {_norm_system_id(s) for s in group_system_ids} group_match = group_sys_set | group_norm group_extras = [ fe for fe in all_extras if emu_system_map.get(fe.get("source_emulator", ""), set()) & group_match ] zip_path = generate_pack( platform_name, platforms_dir, db, bios_dir, split_dir, emulators_dir=emulators_dir, zip_contents=zip_contents, data_registry=data_registry, emu_profiles=emu_profiles, target_cores=target_cores, required_only=required_only, system_filter=group_system_ids, precomputed_extras=group_extras, ) if zip_path: version = config.get("version", config.get("dat_version", "")) ver_tag = f"_{version.replace(' ', '')}" if version else "" req_tag = "_Required" if required_only else "" safe_group = group_name.replace(" ", "_") new_name = f"{platform_display.replace(' ', '_')}{ver_tag}{req_tag}_{safe_group}_BIOS_Pack.zip" new_path = os.path.join(split_dir, new_name) if new_path != zip_path: os.rename(zip_path, new_path) zip_path = new_path results.append(zip_path) # Warn about extras that couldn't be distributed (emulators without systems: field) all_groups_match = set() for group_system_ids in groups.values(): group_norm = {_norm_system_id(s) for s in group_system_ids} all_groups_match |= set(group_system_ids) | group_norm undistributed = [ fe for fe in all_extras if not emu_system_map.get(fe.get("source_emulator", ""), set()) & all_groups_match ] if undistributed: emus = sorted({fe.get("source_emulator", "?") for fe in undistributed}) print(f" NOTE: {len(undistributed)} core extras from {len(emus)} emulators " f"not in split packs (missing systems: field in profiles: " f"{', '.join(emus[:5])}{'...' if len(emus) > 5 else ''})") return results def generate_md5_pack( hashes: list[tuple[str, str]], db: dict, bios_dir: str, output_dir: str, zip_contents: dict | None = None, platform_name: str | None = None, platforms_dir: str | None = None, emulator_name: str | None = None, emulators_dir: str | None = None, standalone: bool = False, ) -> str | None: """Build a pack from an explicit list of hashes with layout context.""" files_db = db.get("files", {}) by_md5 = db.get("indexes", {}).get("by_md5", {}) by_crc32 = db.get("indexes", {}).get("by_crc32", {}) if zip_contents is None: zip_contents = {} plat_file_index: dict[str, dict] = {} base_dest = "" plat_display = "Custom" if platform_name and platforms_dir: config = load_platform_config(platform_name, platforms_dir) base_dest = config.get("base_destination", "") plat_display = config.get("platform", platform_name) for _sys_id, system in config.get("systems", {}).items(): for fe in system.get("files", []): plat_file_index[fe.get("name", "").lower()] = fe emu_pack_structure = None emu_display = "" if emulator_name and emulators_dir: profiles = load_emulator_profiles(emulators_dir, skip_aliases=False) if emulator_name in profiles: profile = profiles[emulator_name] emu_display = profile.get("emulator", emulator_name) emu_pack_structure = profile.get("pack_structure") for fe in profile.get("files", []): plat_file_index[fe.get("name", "").lower()] = fe for alias in fe.get("aliases", []): plat_file_index[alias.lower()] = fe context_name = plat_display if platform_name else (emu_display or "Custom") zip_name = f"{context_name.replace(' ', '_')}_Custom_BIOS_Pack.zip" zip_path = os.path.join(output_dir, zip_name) os.makedirs(output_dir, exist_ok=True) packed: list[tuple[str, str]] = [] not_in_repo: list[tuple[str, str]] = [] not_in_db: list[str] = [] seen: set[str] = set() with zipfile.ZipFile(zip_path, "w", zipfile.ZIP_DEFLATED) as zf: for hash_type, hash_val in hashes: sha1 = None if hash_type == "sha1" and hash_val in files_db: sha1 = hash_val elif hash_type == "md5": sha1 = by_md5.get(hash_val) elif hash_type == "crc32": sha1 = by_crc32.get(hash_val) if not sha1 or sha1 not in files_db: not_in_db.append(hash_val) continue entry = files_db[sha1] name = entry.get("name", "") aliases = entry.get("aliases") or [] paths = entry.get("paths") or [] dest = name matched_fe = None for lookup_name in [name] + aliases: if lookup_name.lower() in plat_file_index: matched_fe = plat_file_index[lookup_name.lower()] break if matched_fe: if emulator_name and emu_pack_structure is not None: dest = _resolve_destination(matched_fe, emu_pack_structure, standalone) else: dest = matched_fe.get("destination", matched_fe.get("name", name)) elif paths: dest = paths[0] if base_dest and not dest.startswith(base_dest): full_dest = f"{base_dest}/{dest}" else: full_dest = dest if full_dest in seen: continue seen.add(full_dest) fe_for_resolve = {"name": name, "sha1": sha1, "md5": entry.get("md5", "")} local_path, status = resolve_file(fe_for_resolve, db, bios_dir, zip_contents) if status == "not_found" or not local_path: not_in_repo.append((name, hash_val)) continue zf.write(local_path, full_dest) packed.append((name, hash_val)) total = len(hashes) print(f"\nPacked {len(packed)}/{total} requested files") for name, h in packed: print(f" PACKED: {name} ({h[:16]}...)") for name, h in not_in_repo: print(f" NOT IN REPO: {name} ({h[:16]}...)") for h in not_in_db: print(f" NOT IN DB: {h}") if not packed: if os.path.exists(zip_path): os.unlink(zip_path) return None return zip_path def generate_target_manifests(targets_dir: str, output_dir: str) -> None: """Convert target YAMLs to installer JSON manifests.""" os.makedirs(output_dir, exist_ok=True) targets_path = Path(targets_dir) if not targets_path.is_dir(): print(f"No targets directory at {targets_dir}", file=sys.stderr) return count = 0 for yml_file in sorted(targets_path.glob("*.yml")): if yml_file.name.startswith("_"): continue with open(yml_file) as f: data = yaml.safe_load(f) or {} targets = data.get("targets", {}) result: dict[str, list[str] | None] = {} for target_name, target_info in targets.items(): cores = target_info.get("cores") if isinstance(target_info, dict) else None result[target_name] = cores if cores else None out_path = Path(output_dir) / f"{yml_file.stem}.json" with open(out_path, "w") as f: json.dump(result, f, indent=2, sort_keys=True) f.write("\n") count += 1 print(f" {yml_file.stem}: {len(result)} targets") print(f"Generated {count} target manifest(s) in {output_dir}") def _validate_args(args, parser): """Validate argument combinations and mutual exclusion rules.""" has_platform = bool(args.platform) has_all = args.all has_emulator = bool(args.emulator) has_system = bool(args.system) has_from_md5 = bool(args.from_md5 or getattr(args, 'from_md5_file', None)) if args.from_md5 and getattr(args, 'from_md5_file', None): parser.error("--from-md5 and --from-md5-file are mutually exclusive") if has_from_md5 and has_all: parser.error("--from-md5 requires --platform or --emulator, not --all") if has_from_md5 and has_system: parser.error("--from-md5 and --system are mutually exclusive") if has_from_md5 and args.split: parser.error("--split and --from-md5 are mutually exclusive") # --platform/--all and --system can combine (system filters within platform) # --emulator is exclusive with everything else if has_emulator and (has_platform or has_all or has_system): parser.error("--emulator is mutually exclusive with --platform, --all, and --system") if has_platform and has_all: parser.error("--platform and --all are mutually exclusive") if not (has_platform or has_all or has_emulator or has_system or has_from_md5): parser.error("Specify --platform, --all, --emulator, --system, or --from-md5") if args.standalone and not (has_emulator or (has_system and not has_platform and not has_all)): parser.error("--standalone requires --emulator or --system (without --platform)") if args.split and not (has_platform or has_all): parser.error("--split requires --platform or --all") if args.split and has_emulator: parser.error("--split is incompatible with --emulator") if args.group_by != "system" and not args.split: parser.error("--group-by requires --split") if args.target and not (has_platform or has_all): parser.error("--target requires --platform or --all") if args.target and has_emulator: parser.error("--target is incompatible with --emulator") if args.manifest and not (has_platform or has_all): parser.error("--manifest requires --platform or --all") if args.manifest and has_emulator: parser.error("--manifest is incompatible with --emulator") if args.manifest and args.split: parser.error("--manifest is incompatible with --split") def _run_manifest_mode(args, groups, db, zip_contents, emu_profiles, target_cores_cache): """Generate JSON manifests instead of ZIP packs.""" registry_path = os.path.join(args.platforms_dir, "_registry.yml") os.makedirs(args.output_dir, exist_ok=True) registry: dict = {} if os.path.exists(registry_path): with open(registry_path) as _rf: registry = yaml.safe_load(_rf) or {} for group_platforms, representative in groups: print(f"\nGenerating manifest for {representative}...") try: tc = target_cores_cache.get(representative) if args.target else None manifest = generate_manifest( representative, args.platforms_dir, db, args.bios_dir, registry_path, emulators_dir=args.emulators_dir, zip_contents=zip_contents, emu_profiles=emu_profiles, target_cores=tc, ) out_path = os.path.join(args.output_dir, f"{representative}.json") with open(out_path, "w") as f: json.dump(manifest, f, indent=2) print(f" {out_path}: {manifest['total_files']} files, " f"{manifest['total_size']} bytes") # Create aliases for grouped platforms (e.g., lakka -> retroarch) for alias_plat in group_platforms: if alias_plat != representative: alias_path = os.path.join(args.output_dir, f"{alias_plat}.json") alias_manifest = dict(manifest) alias_manifest["platform"] = alias_plat alias_cfg = load_platform_config(alias_plat, args.platforms_dir) alias_manifest["display_name"] = alias_cfg.get("platform", alias_plat) alias_registry = registry.get("platforms", {}).get(alias_plat, {}) alias_install = alias_registry.get("install", {}) alias_manifest["detect"] = alias_install.get("detect", []) alias_manifest["standalone_copies"] = alias_install.get("standalone_copies", []) with open(alias_path, "w") as f: json.dump(alias_manifest, f, indent=2) print(f" {alias_path}: alias of {representative}") except (FileNotFoundError, OSError, yaml.YAMLError) as e: print(f" ERROR: {e}") def _run_platform_packs(args, groups, db, zip_contents, data_registry, emu_profiles, target_cores_cache, system_filter): """Generate ZIP packs for platform groups and verify.""" for group_platforms, representative in groups: variants = [p for p in group_platforms if p != representative] if variants: all_names = [load_platform_config(p, args.platforms_dir).get("platform", p) for p in group_platforms] label = " / ".join(all_names) print(f"\nGenerating pack for {label}...") else: print(f"\nGenerating pack for {representative}...") try: tc = target_cores_cache.get(representative) if args.target else None if args.split: zip_paths = generate_split_packs( representative, args.platforms_dir, db, args.bios_dir, args.output_dir, group_by=args.group_by, emulators_dir=args.emulators_dir, zip_contents=zip_contents, data_registry=data_registry, emu_profiles=emu_profiles, target_cores=tc, required_only=args.required_only, ) print(f" Split into {len(zip_paths)} packs") else: zip_path = generate_pack( representative, args.platforms_dir, db, args.bios_dir, args.output_dir, include_extras=args.include_extras, emulators_dir=args.emulators_dir, zip_contents=zip_contents, data_registry=data_registry, emu_profiles=emu_profiles, target_cores=tc, required_only=args.required_only, system_filter=system_filter, ) if not args.split and zip_path and variants: rep_cfg = load_platform_config(representative, args.platforms_dir) ver = rep_cfg.get("version", rep_cfg.get("dat_version", "")) ver_tag = f"_{ver.replace(' ', '')}" if ver else "" all_names = [load_platform_config(p, args.platforms_dir).get("platform", p) for p in group_platforms] combined = "_".join(n.replace(" ", "") for n in all_names) + f"{ver_tag}_BIOS_Pack.zip" new_path = os.path.join(os.path.dirname(zip_path), combined) if new_path != zip_path: os.rename(zip_path, new_path) print(f" Renamed -> {os.path.basename(new_path)}") except (FileNotFoundError, OSError, yaml.YAMLError) as e: print(f" ERROR: {e}") print("\nVerifying packs and generating manifests...") skip_conf = bool(system_filter or args.split) all_ok = verify_and_finalize_packs(args.output_dir, db, skip_conformance=skip_conf, data_registry=data_registry) if args.split: for entry in os.listdir(args.output_dir): sub = os.path.join(args.output_dir, entry) if os.path.isdir(sub) and entry.endswith("_Split"): ok = verify_and_finalize_packs(sub, db, skip_conformance=True, data_registry=data_registry) all_ok = all_ok and ok if not all_ok: print("WARNING: some packs have verification errors") sys.exit(1) def main(): parser = argparse.ArgumentParser(description="Generate platform BIOS ZIP packs") parser.add_argument("--platform", "-p", help="Platform name (e.g., retroarch)") parser.add_argument("--all", action="store_true", help="Generate packs for all active platforms") parser.add_argument("--emulator", "-e", help="Emulator profile name(s), comma-separated") parser.add_argument("--system", "-s", help="System ID(s), comma-separated") parser.add_argument("--standalone", action="store_true", help="Use standalone mode") parser.add_argument("--list-emulators", action="store_true", help="List available emulators") parser.add_argument("--list-systems", action="store_true", help="List available systems") parser.add_argument("--include-archived", action="store_true", help="Include archived platforms") parser.add_argument("--platforms-dir", default=DEFAULT_PLATFORMS_DIR) parser.add_argument("--db", default=DEFAULT_DB_FILE, help="Path to database.json") parser.add_argument("--bios-dir", default=DEFAULT_BIOS_DIR) parser.add_argument("--output-dir", "-o", default=DEFAULT_OUTPUT_DIR) parser.add_argument("--include-extras", action="store_true", help="(no-op) Core requirements are always included") parser.add_argument("--emulators-dir", default="emulators") parser.add_argument("--offline", action="store_true", help="Skip data directory freshness check, use cache only") parser.add_argument("--refresh-data", action="store_true", help="Force re-download all data directories") parser.add_argument("--list", action="store_true", help="List available platforms") parser.add_argument("--required-only", action="store_true", help="Only include required files, skip optional") parser.add_argument("--split", action="store_true", help="Generate one ZIP per system/manufacturer") parser.add_argument("--group-by", choices=["system", "manufacturer"], default="system", help="Grouping for --split (default: system)") parser.add_argument("--target", "-t", help="Hardware target (e.g., switch, rpi4)") parser.add_argument("--list-targets", action="store_true", help="List available targets for the platform") parser.add_argument("--from-md5", help="Hash(es) to look up or pack (comma-separated)") parser.add_argument("--from-md5-file", help="File with hashes (one per line)") parser.add_argument("--manifest", action="store_true", help="Output JSON manifests instead of ZIP packs") parser.add_argument("--manifest-targets", action="store_true", help="Convert target YAMLs to installer JSON") args = parser.parse_args() # Quick-exit modes if args.manifest_targets: generate_target_manifests( os.path.join(args.platforms_dir, "targets"), args.output_dir) return if args.list: for p in list_platforms(args.platforms_dir): print(p) return if args.list_emulators: list_emulator_profiles(args.emulators_dir) return if args.list_systems: if args.platform: list_platform_system_ids(args.platform, args.platforms_dir) else: list_system_ids(args.emulators_dir) return if args.list_targets: if not args.platform: parser.error("--list-targets requires --platform") from common import list_available_targets targets = list_available_targets(args.platform, args.platforms_dir) if not targets: print(f"No targets configured for platform '{args.platform}'") return for t in targets: aliases = f" (aliases: {', '.join(t['aliases'])})" if t['aliases'] else "" print(f" {t['name']:30s} {t['architecture']:10s} {t['core_count']:>4d} cores{aliases}") return _validate_args(args, parser) # Hash lookup / pack mode has_from_md5 = bool(args.from_md5 or getattr(args, 'from_md5_file', None)) if has_from_md5: hashes = parse_hash_input(args.from_md5) if args.from_md5 else parse_hash_file(args.from_md5_file) if not hashes: print("No valid hashes found in input", file=sys.stderr) sys.exit(1) db = load_database(args.db) if not args.platform and not args.emulator: lookup_hashes(hashes, db, args.bios_dir, args.emulators_dir, args.platforms_dir) return zip_contents = build_zip_contents_index(db) result = generate_md5_pack( hashes=hashes, db=db, bios_dir=args.bios_dir, output_dir=args.output_dir, zip_contents=zip_contents, platform_name=args.platform, platforms_dir=args.platforms_dir, emulator_name=args.emulator, emulators_dir=args.emulators_dir, standalone=getattr(args, "standalone", False), ) if not result: sys.exit(1) return db = load_database(args.db) zip_contents = build_zip_contents_index(db) # Emulator mode if args.emulator: names = [n.strip() for n in args.emulator.split(",") if n.strip()] if not generate_emulator_pack( names, args.emulators_dir, db, args.bios_dir, args.output_dir, args.standalone, zip_contents, required_only=args.required_only, ): sys.exit(1) return # System mode (standalone, without platform context) if args.system and not args.platform and not args.all: system_ids = [s.strip() for s in args.system.split(",") if s.strip()] if not generate_system_pack( system_ids, args.emulators_dir, db, args.bios_dir, args.output_dir, args.standalone, zip_contents, required_only=args.required_only, ): sys.exit(1) return system_filter = [s.strip() for s in args.system.split(",") if s.strip()] if args.system else None # Platform mode if args.all: platforms = list_registered_platforms( args.platforms_dir, include_archived=args.include_archived) elif args.platform: platforms = [args.platform] else: parser.error("Specify --platform or --all") return data_registry = load_data_dir_registry(args.platforms_dir) if data_registry and not args.offline: from refresh_data_dirs import refresh_all, load_registry registry = load_registry(os.path.join(args.platforms_dir, "_data_dirs.yml")) results = refresh_all(registry, force=args.refresh_data) updated = sum(1 for v in results.values() if v) if updated: print(f"Refreshed {updated} data director{'ies' if updated > 1 else 'y'}") emu_profiles = load_emulator_profiles(args.emulators_dir) target_cores_cache: dict[str, set[str] | None] = {} if args.target: try: target_cores_cache, platforms = build_target_cores_cache( platforms, args.target, args.platforms_dir, is_all=args.all, ) except (FileNotFoundError, ValueError) as e: print(f"ERROR: {e}", file=sys.stderr) sys.exit(1) groups = group_identical_platforms(platforms, args.platforms_dir, target_cores_cache if args.target else None) if args.manifest: _run_manifest_mode(args, groups, db, zip_contents, emu_profiles, target_cores_cache) else: _run_platform_packs(args, groups, db, zip_contents, data_registry, emu_profiles, target_cores_cache, system_filter) # Manifest generation (JSON inventory for install.py) _GITIGNORE_ENTRIES: set[str] | None = None def _load_gitignore_entries(repo_root: str) -> set[str]: """Load gitignored paths (large files) from .gitignore at repo root.""" global _GITIGNORE_ENTRIES if _GITIGNORE_ENTRIES is not None: return _GITIGNORE_ENTRIES gitignore = os.path.join(repo_root, ".gitignore") entries: set[str] = set() if os.path.exists(gitignore): with open(gitignore) as f: for line in f: line = line.strip() if line and not line.startswith("#"): entries.add(line) _GITIGNORE_ENTRIES = entries return entries def _is_large_file(local_path: str, repo_root: str) -> bool: """Check if a file is a large file (>50MB or in .gitignore).""" if local_path and os.path.exists(local_path): if os.path.getsize(local_path) > 50_000_000: return True gitignore = _load_gitignore_entries(repo_root) # Check if the path relative to repo root is in .gitignore try: rel = os.path.relpath(local_path, repo_root) except ValueError: rel = "" return rel in gitignore def _get_repo_path(sha1: str, db: dict) -> str: """Get the repo path for a file by SHA1 lookup.""" entry = db.get("files", {}).get(sha1, {}) return entry.get("path", "") def generate_manifest( platform_name: str, platforms_dir: str, db: dict, bios_dir: str, registry_path: str, emulators_dir: str = "emulators", zip_contents: dict | None = None, emu_profiles: dict | None = None, target_cores: set[str] | None = None, ) -> dict: """Generate a JSON manifest for a platform (same resolution as generate_pack). Returns a dict ready for JSON serialization with file inventory, install hints, and download metadata. """ config = load_platform_config(platform_name, platforms_dir) if zip_contents is None: zip_contents = {} if emu_profiles is None: emu_profiles = load_emulator_profiles(emulators_dir) platform_display = config.get("platform", platform_name) base_dest = config.get("base_destination", "") case_insensitive = config.get("case_insensitive_fs", False) # Load registry for install metadata registry: dict = {} if os.path.exists(registry_path): with open(registry_path) as f: registry = yaml.safe_load(f) or {} plat_registry = registry.get("platforms", {}).get(platform_name, {}) install_section = plat_registry.get("install", {}) detect = install_section.get("detect", []) standalone_copies = install_section.get("standalone_copies", []) repo_root = os.path.dirname(os.path.dirname(os.path.abspath(__file__))) # Filter systems by target from common import resolve_platform_cores plat_cores = resolve_platform_cores(config, emu_profiles) if target_cores else None pack_systems = filter_systems_by_target( config.get("systems", {}), emu_profiles, target_cores, platform_cores=plat_cores, ) seen_destinations: set[str] = set() seen_lower: set[str] = set() seen_parents: set[str] = set() manifest_files: list[dict] = [] total_size = 0 # Phase 1: baseline files for sys_id, system in sorted(pack_systems.items()): for file_entry in system.get("files", []): dest = _sanitize_path(file_entry.get("destination", file_entry["name"])) if not dest: continue full_dest = f"{base_dest}/{dest}" if base_dest else dest dedup_key = full_dest if dedup_key in seen_destinations: continue if case_insensitive and dedup_key.lower() in seen_lower: continue if _has_path_conflict(full_dest, seen_destinations, seen_parents): continue storage = file_entry.get("storage", "embedded") if storage == "user_provided": continue local_path, status = resolve_file(file_entry, db, bios_dir, zip_contents) if status in ("not_found", "external"): continue # Get SHA1 and size sha1 = file_entry.get("sha1", "") file_size = 0 if local_path and os.path.exists(local_path): file_size = os.path.getsize(local_path) if not sha1: hashes = compute_hashes(local_path) sha1 = hashes["sha1"] repo_path = _get_repo_path(sha1, db) if sha1 else "" entry: dict = { "dest": dest, "sha1": sha1, "size": file_size, "repo_path": repo_path, "cores": None, } if _is_large_file(local_path or "", repo_root): entry["storage"] = "release" entry["release_asset"] = os.path.basename(local_path) if local_path else file_entry["name"] manifest_files.append(entry) total_size += file_size seen_destinations.add(dedup_key) _register_path(dedup_key, seen_destinations, seen_parents) if case_insensitive: seen_lower.add(dedup_key.lower()) # Phase 2: core complement (emulator extras) core_files = _collect_emulator_extras( config, emulators_dir, db, seen_destinations, base_dest, emu_profiles, target_cores=target_cores, ) for fe in core_files: dest = _sanitize_path(fe.get("destination", fe["name"])) if not dest: continue if base_dest: full_dest = f"{base_dest}/{dest}" elif "/" not in dest: full_dest = f"bios/{dest}" else: full_dest = dest if full_dest in seen_destinations: continue if case_insensitive and full_dest.lower() in seen_lower: continue if _has_path_conflict(full_dest, seen_destinations, seen_parents): continue local_path, status = resolve_file(fe, db, bios_dir, zip_contents) if status in ("not_found", "external", "user_provided"): continue sha1 = "" file_size = 0 if local_path and os.path.exists(local_path): file_size = os.path.getsize(local_path) hashes = compute_hashes(local_path) sha1 = hashes["sha1"] repo_path = _get_repo_path(sha1, db) if sha1 else "" source_emu = fe.get("source_emulator", "") entry = { "dest": dest, "sha1": sha1, "size": file_size, "repo_path": repo_path, "cores": [source_emu] if source_emu else [], } if _is_large_file(local_path or "", repo_root): entry["storage"] = "release" entry["release_asset"] = os.path.basename(local_path) if local_path else fe["name"] manifest_files.append(entry) total_size += file_size seen_destinations.add(full_dest) _register_path(full_dest, seen_destinations, seen_parents) if case_insensitive: seen_lower.add(full_dest.lower()) # No phase 3 (data directories) -skipped for manifest now = __import__("datetime").datetime.now( __import__("datetime").timezone.utc ).strftime("%Y-%m-%dT%H:%M:%SZ") result: dict = { "manifest_version": 1, "platform": platform_name, "display_name": platform_display, "version": "1.0", "generated": now, "base_destination": base_dest, "detect": detect, "standalone_copies": standalone_copies, "total_files": len(manifest_files), "total_size": total_size, "files": manifest_files, } return result # Post-generation pack verification + manifest + SHA256SUMS def verify_pack(zip_path: str, db: dict, data_registry: dict | None = None) -> tuple[bool, dict]: """Verify a generated pack ZIP by re-hashing every file inside. Checks against database.json, data directory caches, and verifies rebuilt ZIP content by comparing inner CRC32s against source. Returns (all_ok, manifest_dict). """ files_db = db.get("files", {}) # SHA1 -> file_info by_md5 = db.get("indexes", {}).get("by_md5", {}) # MD5 -> SHA1 by_name = db.get("indexes", {}).get("by_name", {}) # name -> [SHA1] # Data directory file index _data_index: dict[str, list[str]] = {} _data_path_index: dict[str, str] = {} if data_registry: for _dk, _de in data_registry.items(): cache = _de.get("local_cache", "") if not cache or not os.path.isdir(cache): continue for _r, _d, _fns in os.walk(cache): for _fn in _fns: _fp = os.path.join(_r, _fn) _rel = os.path.relpath(_fp, cache) _data_path_index[_rel] = _fp _data_index.setdefault(_fn, []).append(_fp) manifest = { "version": 1, "generator": "retrobios generate_pack.py", "generated": __import__("datetime").datetime.now( __import__("datetime").timezone.utc ).strftime("%Y-%m-%dT%H:%M:%SZ"), "files": [], } errors = [] with zipfile.ZipFile(zip_path, "r") as zf: for info in zf.infolist(): if info.is_dir(): continue name = info.filename if name.startswith("INSTRUCTIONS_") or name in ("manifest.json", "README.txt"): continue with zf.open(info) as f: sha1_h = hashlib.sha1() md5_h = hashlib.md5() size = 0 for chunk in iter(lambda: f.read(65536), b""): sha1_h.update(chunk) md5_h.update(chunk) size += len(chunk) sha1 = sha1_h.hexdigest() md5 = md5_h.hexdigest() # Look up in database: files_db keyed by SHA1 db_entry = files_db.get(sha1) status = "verified" file_name = "" if db_entry: file_name = db_entry.get("name", "") else: # Try MD5 -> SHA1 lookup ref_sha1 = by_md5.get(md5) if ref_sha1: db_entry = files_db.get(ref_sha1) if db_entry: file_name = db_entry.get("name", "") status = "verified_md5" else: status = "untracked" else: status = "untracked" # Rebuilt ZIP: verify inner ROM CRC32s match source if status == "untracked" and name.endswith(".zip"): _bn = os.path.basename(name) for _src_sha1 in by_name.get(_bn, []): if _src_sha1 not in files_db: continue _src_path = files_db[_src_sha1]["path"] if not os.path.exists(_src_path): continue try: import io as _io with zipfile.ZipFile(_src_path) as _sz: _sc = {i.filename: i.CRC for i in _sz.infolist() if not i.is_dir()} with zipfile.ZipFile(_io.BytesIO(zf.read(name))) as _pz: _pc = {i.filename: i.CRC for i in _pz.infolist() if not i.is_dir()} if _sc == _pc: status = "verified_rebuild" file_name = _bn break except (zipfile.BadZipFile, OSError): continue # Data directory: check against cached files if status == "untracked" and _data_index: _bn = os.path.basename(name) _pr = name[len("system/"):] if name.startswith("system/") else name _cands = [] if _pr in _data_path_index: _cands.append(_data_path_index[_pr]) for _dp in _data_index.get(_bn, []): if _dp not in _cands: _cands.append(_dp) for _dp in _cands: if not os.path.exists(_dp): continue if os.path.getsize(_dp) == size: status = "verified_data" file_name = _bn break if name.endswith(".zip") and _dp.endswith(".zip"): try: import io as _io2 with zipfile.ZipFile(_io2.BytesIO(zf.read(name))) as _pz2: _pc2 = {i.filename: i.CRC for i in _pz2.infolist() if not i.is_dir()} with zipfile.ZipFile(_dp) as _dz: _dc = {i.filename: i.CRC for i in _dz.infolist() if not i.is_dir()} if _pc2 == _dc: status = "verified_data" file_name = _bn break except (zipfile.BadZipFile, OSError): continue manifest["files"].append({ "path": name, "sha1": sha1, "md5": md5, "size": size, "status": status, "name": file_name, }) # Corruption check: SHA1 in DB but doesn't match what we computed # This should never happen (we looked up by SHA1), but catches # edge cases where by_md5 resolved to a different SHA1 if db_entry and status == "verified_md5": expected_sha1 = db_entry.get("sha1", "") if expected_sha1 and expected_sha1.lower() != sha1.lower(): errors.append(f"{name}: SHA1 mismatch (expected {expected_sha1}, got {sha1})") verified = sum(1 for f in manifest["files"] if f["status"].startswith("verified")) untracked = sum(1 for f in manifest["files"] if f["status"] == "untracked") total = len(manifest["files"]) manifest["summary"] = { "total_files": total, "verified": verified, "untracked": untracked, "errors": len(errors), } manifest["errors"] = errors all_ok = len(errors) == 0 return all_ok, manifest def inject_manifest(zip_path: str, manifest: dict) -> None: """Inject manifest.json into an existing ZIP pack.""" manifest_json = json.dumps(manifest, indent=2, ensure_ascii=False) # Check if manifest already exists with zipfile.ZipFile(zip_path, "r") as zf: has_manifest = "manifest.json" in zf.namelist() if not has_manifest: # Fast path: append directly with zipfile.ZipFile(zip_path, "a") as zf: zf.writestr("manifest.json", manifest_json) else: # Rebuild to replace existing manifest import tempfile as _tempfile tmp_fd, tmp_path = _tempfile.mkstemp(suffix=".zip", dir=os.path.dirname(zip_path)) os.close(tmp_fd) try: with zipfile.ZipFile(zip_path, "r") as src, \ zipfile.ZipFile(tmp_path, "w", zipfile.ZIP_DEFLATED) as dst: for item in src.infolist(): if item.filename == "manifest.json": continue dst.writestr(item, src.read(item.filename)) dst.writestr("manifest.json", manifest_json) os.replace(tmp_path, zip_path) except (OSError, zipfile.BadZipFile): os.unlink(tmp_path) raise def generate_sha256sums(output_dir: str) -> str | None: """Generate SHA256SUMS.txt for all ZIP files in output_dir.""" sums_path = os.path.join(output_dir, "SHA256SUMS.txt") entries = [] for name in sorted(os.listdir(output_dir)): if not name.endswith(".zip"): continue path = os.path.join(output_dir, name) sha256 = hashlib.sha256() with open(path, "rb") as f: for chunk in iter(lambda: f.read(65536), b""): sha256.update(chunk) entries.append(f"{sha256.hexdigest()} {name}") if not entries: return None with open(sums_path, "w") as f: f.write("\n".join(entries) + "\n") print(f"\n{sums_path}: {len(entries)} pack checksums") return sums_path def verify_pack_against_platform( zip_path: str, platform_name: str, platforms_dir: str, db: dict | None = None, emulators_dir: str = "emulators", emu_profiles: dict | None = None, ) -> tuple[bool, int, int, list[str]]: """Verify a pack ZIP against its platform config and core requirements. Checks: 1. Every baseline file declared by the platform exists in the ZIP at the correct destination path 2. Every in-repo core extra file (from emulator profiles) is present 3. No duplicate entries 4. No path anomalies (double slash, absolute, traversal) 5. No unexpected zero-byte BIOS files Returns (all_ok, checked, present, errors). """ from collections import Counter from verify import find_undeclared_files config = load_platform_config(platform_name, platforms_dir) base_dest = config.get("base_destination", "") errors: list[str] = [] checked = 0 present = 0 if emu_profiles is None: emu_profiles = load_emulator_profiles(emulators_dir) with zipfile.ZipFile(zip_path, "r") as zf: zip_set = set(zf.namelist()) zip_lower = {n.lower(): n for n in zip_set} # Structural checks dupes = sum(1 for c in Counter(zf.namelist()).values() if c > 1) if dupes: errors.append(f"{dupes} duplicate entries") for n in zip_set: if "//" in n: errors.append(f"double slash: {n}") if n.startswith("/"): errors.append(f"absolute path: {n}") if ".." in n: errors.append(f"path traversal: {n}") # Zero-byte check (exclude Dolphin GraphicMods markers) for info in zf.infolist(): if info.file_size == 0 and not info.is_dir(): if "GraphicMods" not in info.filename and info.filename not in ("manifest.json", "README.txt"): errors.append(f"zero-byte: {info.filename}") # 1. Baseline file presence baseline_checked = 0 baseline_present = 0 for sys_id, system in config.get("systems", {}).items(): for fe in system.get("files", []): dest = fe.get("destination", fe.get("name", "")) if not dest: continue expected = f"{base_dest}/{dest}" if base_dest else dest baseline_checked += 1 if expected in zip_set or expected.lower() in zip_lower: baseline_present += 1 else: errors.append(f"baseline missing: {expected}") # 2. Core extras presence (files from emulator profiles, in repo) core_checked = 0 core_present = 0 if db is not None: undeclared = find_undeclared_files(config, emulators_dir, db, emu_profiles) for u in undeclared: if not u["in_repo"]: continue dest = u.get("path") or u["name"] if base_dest: full = f"{base_dest}/{dest}" elif "/" not in dest: full = f"bios/{dest}" else: full = dest core_checked += 1 if full in zip_set or full.lower() in zip_lower: core_present += 1 # Not an error if missing -some get deduped or filtered checked = baseline_checked + core_checked present = baseline_present + core_present return (len(errors) == 0, checked, present, errors, baseline_checked, baseline_present, core_checked, core_present) def verify_and_finalize_packs(output_dir: str, db: dict, platforms_dir: str = "platforms", skip_conformance: bool = False, data_registry: dict | None = None) -> bool: """Verify all packs, inject manifests, generate SHA256SUMS. Two-stage verification: 1. Hash check against database.json (integrity) 2. Extract + verify against platform config (conformance) Returns True if all packs pass verification. """ all_ok = True # Map ZIP names to platform names pack_to_platform: dict[str, list[str]] = {} for name in sorted(os.listdir(output_dir)): if not name.endswith(".zip"): continue for pname in list_registered_platforms(platforms_dir): cfg = load_platform_config(pname, platforms_dir) display = cfg.get("platform", pname).replace(" ", "_") if display in name or display.replace("_", "") in name.replace("_", ""): pack_to_platform.setdefault(name, []).append(pname) for name in sorted(os.listdir(output_dir)): if not name.endswith(".zip"): continue zip_path = os.path.join(output_dir, name) # Stage 1: database integrity ok, manifest = verify_pack(zip_path, db, data_registry=data_registry) summary = manifest["summary"] status = "OK" if ok else "ERRORS" print(f" verify {name}: {summary['verified']}/{summary['total_files']} verified, " f"{summary['untracked']} untracked, {summary['errors']} errors [{status}]") if not ok: for err in manifest["errors"]: print(f" ERROR: {err}") all_ok = False inject_manifest(zip_path, manifest) # Stage 2: platform conformance (extract + verify) # Skipped for filtered/split/custom packs (intentionally partial) if skip_conformance: continue platforms = pack_to_platform.get(name, []) for pname in platforms: (p_ok, total, matched, p_errors, bl_checked, bl_present, core_checked, core_present) = \ verify_pack_against_platform( zip_path, pname, platforms_dir, db=db, ) status = "OK" if p_ok else "FAILED" print(f" platform {pname}: {bl_present}/{bl_checked} baseline, " f"{core_present}/{core_checked} cores, {status}") if not p_ok: for err in p_errors: print(f" {err}") all_ok = False generate_sha256sums(output_dir) return all_ok if __name__ == "__main__": main()