fix: end listings quietly when the reader leaves

install.ps1

@@ -8,7 +8,7 @@ param(
 
 $ErrorActionPreference = "Stop"
 $defaultInstallUrl = "https://raw.githubusercontent.com/Abdess/retrobios/main/install.py"
-$defaultInstallSha256 = "d336ca66e88def775842bca2ed4fae67dabf1d3effcb18e84d057da78470459c"
+$defaultInstallSha256 = "61ffed8fddf816c02c1b45268dfd9bfdff9daeb1da2adedf2e13d14472f8654d"
 $maximumInstallerBytes = 2MB
 $installer = if ($PSScriptRoot) { Join-Path $PSScriptRoot "install.py" } else { $null }
 $temporary = $null

install.py

@@ -3210,4 +3210,11 @@ def _install(args: argparse.Namespace, real_stdout) -> None:
 
 
 if __name__ == "__main__":
-    main()
+    # A reader that stops early (`install.py --list | head`) ends the run
+    # quietly instead of on a BrokenPipeError traceback.
+    try:
+        main()
+        sys.stdout.flush()
+    except BrokenPipeError:
+        os.dup2(os.open(os.devnull, os.O_WRONLY), sys.stdout.fileno())
+        sys.exit(141)

install.sh

@@ -18,7 +18,7 @@ esac
 TEMP_INSTALLER=""
 TEMP_DIRECTORY=""
 DEFAULT_INSTALL_URL="https://raw.githubusercontent.com/Abdess/retrobios/main/install.py"
-DEFAULT_INSTALL_SHA256="d336ca66e88def775842bca2ed4fae67dabf1d3effcb18e84d057da78470459c"
+DEFAULT_INSTALL_SHA256="61ffed8fddf816c02c1b45268dfd9bfdff9daeb1da2adedf2e13d14472f8654d"
 MAX_INSTALLER_BYTES=2097152
 
 cleanup() {

scripts/auto_fetch.py

@@ -463,4 +463,6 @@ def main():
 
 
 if __name__ == "__main__":
-    main()
+    from common import run_cli
+
+    run_cli(main)

scripts/check_buildbot_system.py

@@ -218,4 +218,6 @@ def pending(report: dict) -> list[dict]:
 
 
 if __name__ == "__main__":
-    main()
+    from common import run_cli
+
+    run_cli(main)

scripts/check_freshness.py

@@ -1204,4 +1204,6 @@ def main() -> int:
 
 
 if __name__ == "__main__":
-    sys.exit(main())
+    from common import run_cli
+
+    run_cli(main)

scripts/check_release_assets.py

@@ -380,4 +380,6 @@ def main() -> int:
 
 
 if __name__ == "__main__":
-    sys.exit(main())
+    from common import run_cli
+
+    run_cli(main)

scripts/common.py

@@ -2378,3 +2378,20 @@ from dumpcatalog import (  # noqa: E402,F401
     annotate_provenance,
     write_provenance_snapshot,
 )
+
+
+def run_cli(main) -> None:
+    """Run a command-line entry point to its exit status.
+
+    A reader that stops early (`verify.py --all | head`) closed the pipe
+    and the next write died on a BrokenPipeError traceback. Output nobody
+    reads any more ends the run quietly, with the status a shell gives a
+    writer whose reader left.
+    """
+    try:
+        code = main()
+        sys.stdout.flush()
+    except BrokenPipeError:
+        os.dup2(os.open(os.devnull, os.O_WRONLY), sys.stdout.fileno())
+        sys.exit(141)
+    sys.exit(code)

scripts/cross_reference.py

@@ -776,4 +776,6 @@ def main():
 
 
 if __name__ == "__main__":
-    main()
+    from common import run_cli
+
+    run_cli(main)

scripts/dedup.py

@@ -318,4 +318,6 @@ def main() -> None:
 
 
 if __name__ == "__main__":
-    main()
+    from common import run_cli
+
+    run_cli(main)

scripts/diff_truth.py

@@ -222,4 +222,6 @@ def main() -> None:
 
 
 if __name__ == "__main__":
-    main()
+    from common import run_cli
+
+    run_cli(main)

scripts/download.py

@@ -383,4 +383,6 @@ To check files already in place, use: python install.py --check
 
 
 if __name__ == "__main__":
-    main()
+    from common import run_cli
+
+    run_cli(main)

scripts/export_native.py

@@ -519,4 +519,6 @@ def main() -> None:
 
 
 if __name__ == "__main__":
-    main()
+    from common import run_cli
+
+    run_cli(main)

scripts/fileless_audit.py

@@ -107,4 +107,6 @@ def main() -> None:
 
 
 if __name__ == "__main__":
-    main()
+    from common import run_cli
+
+    run_cli(main)

scripts/find_pinned_revision.py

@@ -99,4 +99,6 @@ def main() -> int:
 
 
 if __name__ == "__main__":
-    sys.exit(main())
+    from common import run_cli
+
+    run_cli(main)

scripts/generate_pack.py

@@ -4363,4 +4363,6 @@ from packresolve import (  # noqa: E402,F401
 )
 
 if __name__ == "__main__":
-    main()
+    from common import run_cli
+
+    run_cli(main)

scripts/generate_readme.py

@@ -768,4 +768,6 @@ def main():
 
 
 if __name__ == "__main__":
-    main()
+    from common import run_cli
+
+    run_cli(main)

scripts/generate_site.py

@@ -4028,4 +4028,6 @@ from siterender import (  # noqa: E402,F401
 )
 
 if __name__ == "__main__":
-    main()
+    from common import run_cli
+
+    run_cli(main)

scripts/generate_truth.py

@@ -153,4 +153,6 @@ def main(argv: list[str] | None = None) -> None:
 
 
 if __name__ == "__main__":
-    main()
+    from common import run_cli
+
+    run_cli(main)

scripts/identity.py

@@ -155,4 +155,6 @@ def main() -> int:
 
 
 if __name__ == "__main__":
-    raise SystemExit(main())
+    from common import run_cli
+
+    run_cli(main)

scripts/list_platforms.py

@@ -49,4 +49,6 @@ def main():
 
 
 if __name__ == "__main__":
-    main()
+    from common import run_cli
+
+    run_cli(main)

scripts/mame_ref_audit.py

@@ -141,4 +141,6 @@ def main() -> None:
 
 
 if __name__ == "__main__":
-    main()
+    from common import run_cli
+
+    run_cli(main)

scripts/migrate.py

@@ -564,4 +564,6 @@ def main():
 
 
 if __name__ == "__main__":
-    main()
+    from common import run_cli
+
+    run_cli(main)

scripts/pipeline.py

@@ -688,4 +688,6 @@ def main():
 
 
 if __name__ == "__main__":
-    main()
+    from common import run_cli
+
+    run_cli(main)

scripts/profile_sync.py

@@ -3660,4 +3660,6 @@ def _print_elided(
 
 
 if __name__ == "__main__":
-    main()
+    from common import run_cli
+
+    run_cli(main)

scripts/provenance_report.py

@@ -202,4 +202,6 @@ def main() -> int:
 
 
 if __name__ == "__main__":
-    sys.exit(main())
+    from common import run_cli
+
+    run_cli(main)

scripts/refresh_data_dirs.py

@@ -559,4 +559,6 @@ def main() -> None:
 
 
 if __name__ == "__main__":
-    main()
+    from common import run_cli
+
+    run_cli(main)

scripts/refresh_stale.py

@@ -470,4 +470,6 @@ def main() -> int:
 
 
 if __name__ == "__main__":
-    sys.exit(main())
+    from common import run_cli
+
+    run_cli(main)

scripts/region_audit.py

@@ -210,4 +210,6 @@ def main() -> int:
 
 
 if __name__ == "__main__":
-    raise SystemExit(main())
+    from common import run_cli
+
+    run_cli(main)

scripts/release_record.py

@@ -156,4 +156,6 @@ def main() -> int:
 
 
 if __name__ == "__main__":
-    sys.exit(main())
+    from common import run_cli
+
+    run_cli(main)

scripts/restore_large_files.py

@@ -103,4 +103,6 @@ def main() -> None:
 
 
 if __name__ == "__main__":
-    main()
+    from common import run_cli
+
+    run_cli(main)

scripts/romset_recipes.py

@@ -471,4 +471,6 @@ def main() -> int:
 
 
 if __name__ == "__main__":
-    sys.exit(main())
+    from common import run_cli
+
+    run_cli(main)

scripts/slots.py

@@ -900,4 +900,6 @@ def main() -> int:
 
 
 if __name__ == "__main__":
-    raise SystemExit(main())
+    from common import run_cli
+
+    run_cli(main)

scripts/split_pack.py

@@ -243,4 +243,6 @@ def main() -> int:
 
 
 if __name__ == "__main__":
-    sys.exit(main())
+    from common import run_cli
+
+    run_cli(main)

scripts/torrentzip.py

@@ -143,4 +143,6 @@ def main() -> int:
 
 
 if __name__ == "__main__":
-    sys.exit(main())
+    from common import run_cli
+
+    run_cli(main)

scripts/validate_pr.py

@@ -408,4 +408,6 @@ def main():
 
 
 if __name__ == "__main__":
-    main()
+    from common import run_cli
+
+    run_cli(main)

scripts/validate_schemas.py

@@ -391,4 +391,6 @@ def main() -> int:
 
 
 if __name__ == "__main__":
-    sys.exit(main())
+    from common import run_cli
+
+    run_cli(main)

scripts/validate_site.py

@@ -292,4 +292,6 @@ def main() -> None:
 
 
 if __name__ == "__main__":
-    main()
+    from common import run_cli
+
+    run_cli(main)

scripts/verify.py

@@ -2309,4 +2309,6 @@ def _overall_summary(group_results: list[tuple[dict, list[str]]]) -> str:
 
 
 if __name__ == "__main__":
-    main()
+    from common import run_cli
+
+    run_cli(main)

tests/test_audit_regressions.py

@@ -3442,5 +3442,28 @@ class MessagesSeparateWithAColon(unittest.TestCase):
         self.assertEqual(found, [])
 
 
+
+class AReaderThatLeavesEarlyIsNoCrash(unittest.TestCase):
+    """`verify.py --list-emulators | head -1` ended on a BrokenPipeError
+    traceback; every listing and report did."""
+
+    def test_a_closed_pipe_ends_quietly(self):
+        proc = subprocess.Popen(
+            [sys.executable, "scripts/verify.py", "--list-emulators"], cwd=ROOT,
+            stdout=subprocess.PIPE, stderr=subprocess.PIPE,
+        )
+        proc.stdout.readline()
+        proc.stdout.close()
+        _, err = proc.communicate(timeout=120)
+        self.assertNotIn(b"Traceback", err)
+        self.assertEqual(proc.returncode, 141)
+
+    def test_every_entry_point_goes_through_run_cli(self):
+        plain = re.compile(r'if __name__ == "__main__":\n    (main\(\)|sys\.exit\(main\(\)\))')
+        found = [p.name for p in sorted((ROOT / "scripts").glob("*.py"))
+                 if plain.search(p.read_text())]
+        self.assertEqual(found, [])
+
+
 if __name__ == "__main__":
     unittest.main()